yetangitu/Battery-Emulator
1
0
Fork 0
mirror of https://github.com/dalathegreat/Battery-Emulator.git synced 2025-10-05 19:42:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

LEAF - Setting cell voltage values after last cell frame values

Browse source 
Ensure that the values ​​in the cell voltage datalayer are only updated when all information from all cells is received from battery.
Changed the maximum cell reference in cellmonitor to use the specific datalayer information of the battery in use instead of the MAX_AMOUNT_CELLS which is the maximum possible value.
This commit is contained in:
amarofarinha 2024-05-27 16:01:46 +01:00
parent 9b00116029
commit 004397e48f
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Software/src/battery/NISSAN-LEAF-BATTERY.cpp
View file

@ -220,11 +220,6 @@ void update_values_battery() { /* This function maps all the values fetched via
datalayer.battery.status.max_charge_power_W = 0; //No need to charge further, set max power to 0
}
//Map all cell voltages to the global array
for (int i = 0; i < 96; ++i) {
datalayer.battery.status.cell_voltages_mV[i] = cell_voltages[i];
}
/*Extra safety functions below*/
if (LB_GIDS < 10) //700Wh left in battery!
{ //Battery is running abnormally low, some discharge logic might have failed. Zero it all out.
@ -486,6 +481,13 @@ void receive_can_battery(CAN_frame_t rx_frame) {
}
if (rx_frame.data.u8[6] == 0xFF && rx_frame.data.u8[0] == 0x2C) { //Last frame
//Last frame does not contain any cell data, calculate the result
//Map all cell voltages to the global array
for (int i = 0; i < 96; ++i) {
datalayer.battery.status.cell_voltages_mV[i] = cell_voltages[i];
}
//calculate min/max voltages
min_max_voltage[0] = 9999;
min_max_voltage[1] = 0;
for (cellcounter = 0; cellcounter < 96; cellcounter++) {

2
Software/src/devboard/webserver/cellmonitor_html.cpp
View file

@ -37,7 +37,7 @@ String cellmonitor_processor(const String& var) {
content += "<script>";
// Populate cell data
content += "const data = [";
for (uint8_t i = 0u; i < MAX_AMOUNT_CELLS; i++) {
for (uint8_t i = 0u; i < datalayer.battery.info.number_of_cells; i++) {
if (datalayer.battery.status.cell_voltages_mV[i] == 0) {
continue;
}