From 5faf6c1a9e3901abfe97d3515b6fdcb0bd814dab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Mon, 23 Dec 2024 15:53:35 +0200 Subject: [PATCH] Add TODOs to .cpp file --- Software/src/battery/BOLT-AMPERA-BATTERY.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Software/src/battery/BOLT-AMPERA-BATTERY.cpp b/Software/src/battery/BOLT-AMPERA-BATTERY.cpp index 510b90b7..90d85eb5 100644 --- a/Software/src/battery/BOLT-AMPERA-BATTERY.cpp +++ b/Software/src/battery/BOLT-AMPERA-BATTERY.cpp @@ -5,6 +5,20 @@ #include "../devboard/utils/events.h" #include "BOLT-AMPERA-BATTERY.h" +/* +TODOs left for this implementation +- The battery has 3 CAN ports. One of them is responsible for the 7E4 polls, the other for the 7E7 polls +- Current implementation only seems to get the 7E7 polls working. +- Could on of the CAN channels be GMLAN? + +- The values missing for a working implementation is: +- SOC% missing! This is absolutely mandatory to fix before starting to use this! +- Capacity (kWh) (can be estimated) +- Charge max power (can be estimated) +- Discharge max power (can be estimated) +- SOH% (low prio)) +*/ + /* Do not change code below unless you are sure what you are doing */ static unsigned long previousMillis20ms = 0; // will store last time a 20ms CAN Message was send static unsigned long previousMillis100ms = 0; // will store last time a 100ms CAN Message was send