Remove comment

This commit is contained in:
Daniel Öster 2024-11-14 18:40:09 +02:00
parent edb6dcd39b
commit 950b0bbb26
24 changed files with 25 additions and 50 deletions

View file

@ -1119,8 +1119,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "BMW i3", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
//Before we have started up and detected which battery is in use, use 60AH values
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_60AH;

View file

@ -780,8 +780,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "BMW iX and i4-7 platform",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
//Before we have started up and detected which battery is in use, use 108S values
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -400,8 +400,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "BYD Atto 3", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 126;
datalayer.battery.info.chemistry = battery_chemistry_enum::LFP;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -334,8 +334,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Cellpower BMS", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.system.status.battery_allows_contactor_closing = true;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -1034,8 +1034,7 @@ void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Chademo V2X mode",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
CHADEMO_Status = CHADEMO_IDLE;

View file

@ -226,8 +226,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "I-Miev / C-Zero / Ion Triplet",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;
datalayer.battery.info.max_cell_voltage_mV = MAX_CELL_VOLTAGE_MV;

View file

@ -255,8 +255,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Jaguar I-PACE", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 108;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -1039,8 +1039,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Kia/Hyundai EGMP platform",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
startMillis = millis(); // Record the starting time

View file

@ -536,8 +536,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Kia/Hyundai 64/40kWh battery",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_98S_DV; //Start with 98S value. Precised later
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_90S_DV; //Start with 90S value. Precised later
datalayer.battery.info.max_cell_voltage_mV = MAX_CELL_VOLTAGE_MV;

View file

@ -259,8 +259,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Kia/Hyundai Hybrid",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 56; // HEV , TODO: Make dynamic according to HEV/PHEV
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -136,8 +136,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "MG 5 battery", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -1226,8 +1226,7 @@ uint16_t Temp_fromRAW_to_F(uint16_t temperature) { //This function feels horrib
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Nissan LEAF battery",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 96;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -177,8 +177,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Pylon compatible battery",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -315,8 +315,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Range Rover 13kWh PHEV battery (L494/L405)",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -236,8 +236,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Renault Kangoo", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -133,8 +133,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Renault Twizy", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 14;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -520,8 +520,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Renault Zoe Gen1 22/40kWh",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.system.status.battery_allows_contactor_closing = true;
datalayer.battery.info.number_of_cells = 96;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -387,8 +387,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Renault Zoe Gen2 50kWh",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.system.status.battery_allows_contactor_closing = true;
datalayer.battery.info.number_of_cells = 96;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;

View file

@ -572,8 +572,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "RJXZS BMS, DIY battery",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;
datalayer.battery.info.max_cell_voltage_mV = MAX_CELL_VOLTAGE_MV;

View file

@ -403,8 +403,7 @@ uint8_t CalculateCRC8(CAN_frame rx_frame) {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Santa Fe PHEV", sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 96;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;

View file

@ -221,8 +221,7 @@ void update_values_serial_link() {
void setup_battery(void) {
strncpy(datalayer.system.info.battery_protocol, "Serial link to another LilyGo board",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
}
// Needed to make the compiler happy
void update_values_battery() {}

View file

@ -1254,8 +1254,7 @@ void setup_battery(void) { // Performs one time setup at startup
#ifdef TESLA_MODEL_SX_BATTERY // Always use NCM/A mode on S/X packs
strncpy(datalayer.system.info.battery_protocol, "Tesla Model S/X",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_SX_NCMA;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_SX_NCMA;
datalayer.battery.info.max_cell_voltage_mV = MAX_CELL_VOLTAGE_NCA_NCM;
@ -1273,8 +1272,7 @@ void setup_battery(void) { // Performs one time setup at startup
#ifdef TESLA_MODEL_3Y_BATTERY // Model 3/Y can be either LFP or NCM/A
strncpy(datalayer.system.info.battery_protocol, "Tesla Model 3/Y",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
#ifdef LFP_CHEMISTRY
datalayer.battery.info.chemistry = battery_chemistry_enum::LFP;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_3Y_LFP;

View file

@ -147,8 +147,7 @@ void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Fake battery for testing purposes",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.max_design_voltage_dV =
4040; // 404.4V, over this, charging is not possible (goes into forced discharge)

View file

@ -334,8 +334,7 @@ void send_can_battery() {
void setup_battery(void) { // Performs one time setup at startup
strncpy(datalayer.system.info.battery_protocol, "Volvo / Polestar 78kWh battery",
sizeof(datalayer.system.info.battery_protocol) - 1);
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] =
'\0'; // Ensure null termination
datalayer.system.info.battery_protocol[sizeof(datalayer.system.info.battery_protocol) - 1] = '\0';
datalayer.battery.info.number_of_cells = 108;
datalayer.battery.info.max_design_voltage_dV = MAX_PACK_VOLTAGE_DV;
datalayer.battery.info.min_design_voltage_dV = MIN_PACK_VOLTAGE_DV;