From 9b77b135b659853b2517f8fb2cb192d90e07d852 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Sun, 30 Mar 2025 22:25:34 +0300 Subject: [PATCH] Update TODO comments --- Software/src/battery/CMFA-EV-BATTERY.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/Software/src/battery/CMFA-EV-BATTERY.cpp b/Software/src/battery/CMFA-EV-BATTERY.cpp index a1c7364c..0190e8a0 100644 --- a/Software/src/battery/CMFA-EV-BATTERY.cpp +++ b/Software/src/battery/CMFA-EV-BATTERY.cpp @@ -5,15 +5,11 @@ #include "CMFA-EV-BATTERY.h" /* TODO: -Before this integration can be considered stable, we need to: -- Find the following data points in the transmitted CAN data: - - Pack voltage (Current implementation might be wrong) - - Cellvoltage min - - Cellvoltage max - - Alternatively all these values can be taken from OBD2 PID polling +Integration considered stable! Following points can still be improved: +- Cellvoltage Min missing. Value now mapped to same as Cellvoltage Max +- All individual cellvoltages can not yet be viewed in the cellmonitor /* - /* Do not change code below unless you are sure what you are doing */ CAN_frame CMFA_1EA = {.FD = false, .ext_ID = false, .DLC = 1, .ID = 0x1EA, .data = {0x00}}; CAN_frame CMFA_125 = {.FD = false, @@ -33,7 +29,6 @@ CAN_frame CMFA_3D3 = {.FD = false, .ID = 0x3D3, .data = {0x47, 0x30, 0x00, 0x02, 0x5D, 0x80, 0x5D, 0xE7}}; CAN_frame CMFA_59B = {.FD = false, .ext_ID = false, .DLC = 3, .ID = 0x59B, .data = {0x00, 0x02, 0x00}}; - CAN_frame CMFA_ACK = {.FD = false, .ext_ID = false, .DLC = 8,