From 31ea1f09289283c0d9da62826d314114dee1fc08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Tue, 30 Sep 2025 14:43:14 +0300 Subject: [PATCH 1/5] Update Software.cpp --- Software/Software.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Software/Software.cpp b/Software/Software.cpp index 9e627b51..955ea3d0 100644 --- a/Software/Software.cpp +++ b/Software/Software.cpp @@ -34,7 +34,7 @@ #endif // The current software version, shown on webserver -const char* version_number = "9.1.2"; +const char* version_number = "9.2.dev"; // Interval timers volatile unsigned long currentMillis = 0; From 18ee9d6c2708830d226a46700d76964802704ba7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Tue, 30 Sep 2025 22:16:05 +0300 Subject: [PATCH 2/5] Allow dash as special character in usernames/passwords --- .../src/devboard/webserver/settings_html.cpp | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Software/src/devboard/webserver/settings_html.cpp b/Software/src/devboard/webserver/settings_html.cpp index 5ebcc558..08ca1929 100644 --- a/Software/src/devboard/webserver/settings_html.cpp +++ b/Software/src/devboard/webserver/settings_html.cpp @@ -1249,14 +1249,14 @@ const char* getCANInterfaceName(CAN_Interface interface) { @@ -1266,8 +1266,8 @@ const char* getCANInterfaceName(CAN_Interface interface) { + pattern="[A-Za-z0-9!#*-]+" + title="Optional: Hostname may only contain letters, numbers and some special characters: !#*-" /> @@ -1312,11 +1312,11 @@ const char* getCANInterfaceName(CAN_Interface interface) { min="1" max="65535" step="1" title="Port number (1-65535)" /> + pattern="[A-Za-z0-9!#*-]+" + title="MQTT username can only contain letters, numbers and some special characters: !#*-" /> + pattern="[A-Za-z0-9!#*-]+" + title="MQTT password can only contain letters, numbers and some special characters: !#*-" /> Date: Tue, 30 Sep 2025 23:29:08 +0300 Subject: [PATCH 3/5] Make Wifi use actual set SSID for AP --- Software/src/devboard/wifi/wifi.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Software/src/devboard/wifi/wifi.cpp b/Software/src/devboard/wifi/wifi.cpp index 7d612fb0..c0283ccf 100644 --- a/Software/src/devboard/wifi/wifi.cpp +++ b/Software/src/devboard/wifi/wifi.cpp @@ -240,7 +240,6 @@ void init_mDNS() { } void init_WiFi_AP() { - ssidAP = std::string("BatteryEmulator") + WiFi.macAddress().c_str(); DEBUG_PRINTF("Creating Access Point: %s\n", ssidAP.c_str()); DEBUG_PRINTF("With password: %s\n", passwordAP.c_str()); From 867512eecd0c5bb6adb6f914cb71aa22a9866fda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Wed, 1 Oct 2025 21:13:41 +0300 Subject: [PATCH 4/5] Make Stark BMS power on by default --- Software/src/devboard/hal/hw_stark.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Software/src/devboard/hal/hw_stark.h b/Software/src/devboard/hal/hw_stark.h index 718eb04d..4f6989f4 100644 --- a/Software/src/devboard/hal/hw_stark.h +++ b/Software/src/devboard/hal/hw_stark.h @@ -21,6 +21,9 @@ class StarkHal : public Esp32Hal { public: const char* name() { return "Stark CMR Module"; } + //Always enable BMS power on Stark CMR, it does not collide with any pin definitions + virtual bool always_enable_bms_power() { return true; } + // Not needed, GPIO 16 has hardware pullup for PSRAM compatibility virtual gpio_num_t PIN_5V_EN() { return GPIO_NUM_NC; } From d8153c48bbe3dd6e0b69d417a7b1da0541f29d71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20=C3=96ster?= Date: Fri, 3 Oct 2025 13:52:14 +0300 Subject: [PATCH 5/5] Update CONTRIBUTING.md --- CONTRIBUTING.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 14e85c18..ca26fcc8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -106,3 +106,20 @@ Navigate to Battery-Emulator/test folder sudo cmake CMakeLists.txt sudo make ``` + +## Downloading a pull request build to test locally 🛜 +If you want to test a pull request, you can download the precompiled binaries from the build system. To do this,start by clicking on the "**Checks**" tab + +image + +Then select which hardware you need the binaries for. Currently we build for these hardwares: +- LilyGo T-CAN485 +- Stark CMR +- LilyGo T-2CAN + +image + +After selecting the hardware you need, click the "**Upload Artifact**", and there will be a download link. Download the file, and [OTA Update](https://github.com/dalathegreat/Battery-Emulator/wiki/OTA-Update) your device with this file! + +image +