Merge pull request #1592 from dalathegreat/improvement/stark-BMS-on-by-default

Stark CMR: Make BMS power on by default

Software/Software.cpp

@@ -34,7 +34,7 @@
 #endif
 
 // The current software version, shown on webserver
-const char* version_number = "9.1.2";
+const char* version_number = "9.2.dev";
 
 // Interval timers
 volatile unsigned long currentMillis = 0;

Software/src/devboard/hal/hw_stark.h

@@ -21,6 +21,9 @@ class StarkHal : public Esp32Hal {
  public:
   const char* name() { return "Stark CMR Module"; }
 
+  //Always enable BMS power on Stark CMR, it does not collide with any pin definitions
+  virtual bool always_enable_bms_power() { return true; }
+
   // Not needed, GPIO 16 has hardware pullup for PSRAM compatibility
   virtual gpio_num_t PIN_5V_EN() { return GPIO_NUM_NC; }
 

Software/src/devboard/webserver/settings_html.cpp

@@ -1249,14 +1249,14 @@ const char* getCANInterfaceName(CAN_Interface interface) {
 
         <label>Access point name: </label>
         <input type='text' name='APNAME' value="%APNAME%" 
-        pattern="[A-Za-z0-9!#*]{8,63}" 
+        pattern="[A-Za-z0-9!#*-]{8,63}" 
-        title="Name must be 8-63 characters long and may only contain letters, numbers and some special characters: !#*"
+        title="Name must be 8-63 characters long and may only contain letters, numbers and some special characters: !#*-"
         required />
 
         <label>Access point password: </label>
         <input type='text' name='APPASSWORD' value="%APPASSWORD%" 
-        pattern="[A-Za-z0-9!#*]{8,63}" 
+        pattern="[A-Za-z0-9!#*-]{8,63}" 
-        title="Password must be 8-63 characters long and may only contain letters, numbers and some special characters: !#*"
+        title="Password must be 8-63 characters long and may only contain letters, numbers and some special characters: !#*-"
         required />
 
         <label>Wifi channel 0-14: </label>
@@ -1266,8 +1266,8 @@ const char* getCANInterfaceName(CAN_Interface interface) {
 
         <label>Custom Wifi hostname: </label>
         <input type='text' name='HOSTNAME' value="%HOSTNAME%" 
-        pattern="[A-Za-z0-9!*]+"
+        pattern="[A-Za-z0-9!#*-]+"
-        title="Optional: Hostname may only contain only letters, numbers, ! and *" />
+        title="Optional: Hostname may only contain letters, numbers and some special characters: !#*-" />
 
         <label>Use static IP address: </label>
         <input type='checkbox' name='STATICIP' value='on' %STATICIP% />
@@ -1312,11 +1312,11 @@ const char* getCANInterfaceName(CAN_Interface interface) {
         min="1" max="65535" step="1"
         title="Port number (1-65535)" />
         <label>MQTT user: </label><input type='text' name='MQTTUSER' value="%MQTTUSER%"         
-        pattern="[A-Za-z0-9!#*]+"
+        pattern="[A-Za-z0-9!#*-]+"
-        title="MQTT username can only contain letters, numbers and some special characters: !#*" />
+        title="MQTT username can only contain letters, numbers and some special characters: !#*-" />
         <label>MQTT password: </label><input type='password' name='MQTTPASSWORD' value="%MQTTPASSWORD%" 
-        pattern="[A-Za-z0-9!#*]+"
+        pattern="[A-Za-z0-9!#*-]+"
-        title="MQTT password can only contain letters, numbers and some special characters: !#*" />
+        title="MQTT password can only contain letters, numbers and some special characters: !#*-" />
         <label>MQTT timeout ms: </label>
         <input name='MQTTTIMEOUT' type='number' value="%MQTTTIMEOUT%" 
         min="1" max="60000" step="1"

Software/src/devboard/wifi/wifi.cpp

@@ -240,7 +240,6 @@ void init_mDNS() {
 }
 
 void init_WiFi_AP() {
-  ssidAP = std::string("BatteryEmulator") + WiFi.macAddress().c_str();
 
   DEBUG_PRINTF("Creating Access Point: %s\n", ssidAP.c_str());
   DEBUG_PRINTF("With password: %s\n", passwordAP.c_str());