From 58da4c45a19a90def433351aa1a1d5984ed2eda0 Mon Sep 17 00:00:00 2001
From: EugeniyVlasov <fbreader@fbreader.org>
Date: Tue, 13 Nov 2007 18:29:14 +0000
Subject: [PATCH] git-svn-id:
 https://only.mawhrin.net/repos/FBReaderJ/trunk@127
 6a642e6f-84f6-412e-ac94-c4a38d5a04b0

---
 .../zlibrary/options/ZLBoolean3Option.java    |  4 ++--
 src/org/zlibrary/options/ZLBooleanOption.java |  4 ++--
 src/org/zlibrary/options/ZLColorOption.java   |  4 ++--
 src/org/zlibrary/options/ZLDoubleOption.java  |  4 ++--
 src/org/zlibrary/options/ZLIntegerOption.java |  4 ++--
 .../options/ZLIntegerRangeOption.java         |  4 ++--
 src/org/zlibrary/options/ZLOption.java        |  7 ++++---
 src/org/zlibrary/options/ZLSimpleOption.java  |  4 ++--
 src/org/zlibrary/options/ZLStringOption.java  |  4 ++--
 .../options/config/ZLConfigFactory.java       |  7 -------
 .../options/config/ZLConfigInstance.java      | 10 ++++++++++
 .../options/config/reader/ZLConfigReader.java |  9 +++++----
 .../config/reader/ZLConfigReaderFactory.java  |  2 +-
 .../reader/{ZLReadable.java => ZLReader.java} |  2 +-
 .../org/test/zlibrary/options/ModelTests.java | 20 +++++++++----------
 15 files changed, 46 insertions(+), 43 deletions(-)
 delete mode 100644 src/org/zlibrary/options/config/ZLConfigFactory.java
 create mode 100644 src/org/zlibrary/options/config/ZLConfigInstance.java
 rename src/org/zlibrary/options/config/reader/{ZLReadable.java => ZLReader.java} (78%)

diff --git a/src/org/zlibrary/options/ZLBoolean3Option.java b/src/org/zlibrary/options/ZLBoolean3Option.java
index bc0da2e91..5c15aec57 100644
--- a/src/org/zlibrary/options/ZLBoolean3Option.java
+++ b/src/org/zlibrary/options/ZLBoolean3Option.java
@@ -43,8 +43,8 @@ public final class ZLBoolean3Option extends ZLSimpleOption {
         }
 	}
 	
-	public ZLBoolean3Option(ZLConfig config, String category, String group, String optionName, ZLBoolean3 defaultValue){		
-		super(config, category, group, optionName);
+	public ZLBoolean3Option(String category, String group, String optionName, ZLBoolean3 defaultValue){		
+		super(category, group, optionName);
 		myDefaultValue = defaultValue;
 		myValue = myDefaultValue;
 	}
diff --git a/src/org/zlibrary/options/ZLBooleanOption.java b/src/org/zlibrary/options/ZLBooleanOption.java
index f8d47a2a4..25440c90c 100644
--- a/src/org/zlibrary/options/ZLBooleanOption.java
+++ b/src/org/zlibrary/options/ZLBooleanOption.java
@@ -42,8 +42,8 @@ public final class ZLBooleanOption extends ZLSimpleOption {
         }
 	}
 
-	public ZLBooleanOption (ZLConfig config, String category, String group, String optionName, boolean defaultValue){
-		super(config, category, group, optionName);
+	public ZLBooleanOption (String category, String group, String optionName, boolean defaultValue){
+		super(category, group, optionName);
 		myDefaultValue = defaultValue;
 		myValue = myDefaultValue;
 	}
diff --git a/src/org/zlibrary/options/ZLColorOption.java b/src/org/zlibrary/options/ZLColorOption.java
index 5644c294d..f9da5e70f 100644
--- a/src/org/zlibrary/options/ZLColorOption.java
+++ b/src/org/zlibrary/options/ZLColorOption.java
@@ -41,8 +41,8 @@ public final class ZLColorOption extends ZLOption {
         }
     }
     
-	public ZLColorOption (ZLConfig config, String category, String group, String optionName, ZLColor defaultValue){
-        super(config, category, group, optionName);
+	public ZLColorOption (String category, String group, String optionName, ZLColor defaultValue){
+        super(category, group, optionName);
 		myDefaultValue = defaultValue.getIntValue();
 		myIntValue = myDefaultValue;
 	}
diff --git a/src/org/zlibrary/options/ZLDoubleOption.java b/src/org/zlibrary/options/ZLDoubleOption.java
index f789709d4..525728f1e 100644
--- a/src/org/zlibrary/options/ZLDoubleOption.java
+++ b/src/org/zlibrary/options/ZLDoubleOption.java
@@ -38,8 +38,8 @@ public final class ZLDoubleOption extends ZLOption{
         }
     }
 
-	public ZLDoubleOption (ZLConfig config, String category, String group, String optionName, double defaultValue){
-		super(config, category, group, optionName);
+	public ZLDoubleOption (String category, String group, String optionName, double defaultValue){
+		super(category, group, optionName);
 		myDefaultValue = defaultValue;
 		myValue = myDefaultValue;
 	}
diff --git a/src/org/zlibrary/options/ZLIntegerOption.java b/src/org/zlibrary/options/ZLIntegerOption.java
index 4e4f4a127..3f47eb663 100644
--- a/src/org/zlibrary/options/ZLIntegerOption.java
+++ b/src/org/zlibrary/options/ZLIntegerOption.java
@@ -37,8 +37,8 @@ public final class ZLIntegerOption extends ZLOption{
         }
     }
 
-	public ZLIntegerOption (ZLConfig config, String category, String group, String optionName, long defaultValue){
-		super(config, category, group, optionName);
+	public ZLIntegerOption (String category, String group, String optionName, long defaultValue){
+		super(category, group, optionName);
 		myDefaultValue = defaultValue;
 		myValue = myDefaultValue;
 	}
diff --git a/src/org/zlibrary/options/ZLIntegerRangeOption.java b/src/org/zlibrary/options/ZLIntegerRangeOption.java
index 5ad5ddb94..4e582dc37 100644
--- a/src/org/zlibrary/options/ZLIntegerRangeOption.java
+++ b/src/org/zlibrary/options/ZLIntegerRangeOption.java
@@ -51,8 +51,8 @@ public final class ZLIntegerRangeOption extends ZLOption {
         }
     }
 	
-	public ZLIntegerRangeOption (ZLConfig config, String category, String group, String optionName, long minValue, long maxValue, long defaultValue){
-		super(config, category, group, optionName);
+	public ZLIntegerRangeOption (String category, String group, String optionName, long minValue, long maxValue, long defaultValue){
+		super(category, group, optionName);
 		myMinValue = minValue;
 		myMaxValue = maxValue;
 		//страхуемся от ошибки программиста =)
diff --git a/src/org/zlibrary/options/ZLOption.java b/src/org/zlibrary/options/ZLOption.java
index 086780483..6ce38af48 100644
--- a/src/org/zlibrary/options/ZLOption.java
+++ b/src/org/zlibrary/options/ZLOption.java
@@ -1,11 +1,13 @@
 package org.zlibrary.options;
 
+import org.zlibrary.options.config.ZLConfigInstance;
+
 public abstract class ZLOption {
 	public static final String LOOK_AND_FEEL_CATEGORY = "ui";
 	public static final String CONFIG_CATEGORY = "options";
 	public static final String STATE_CATEGORY = "state";
 	
-    protected ZLConfig myConfig;
+    protected ZLConfig myConfig = ZLConfigInstance.getInstance();
 	protected String myCategory;
 	protected String myGroup;
 	protected String myOptionName;
@@ -19,11 +21,10 @@ public abstract class ZLOption {
      * @param group
      * @param optionName
 	 */
-	protected ZLOption (ZLConfig config, String category, String group, String optionName){
+	protected ZLOption (String category, String group, String optionName){
 		myCategory = category;
 		myGroup = group;
 		myOptionName = optionName;
-        myConfig = config;
 	}
 	
 	/**
diff --git a/src/org/zlibrary/options/ZLSimpleOption.java b/src/org/zlibrary/options/ZLSimpleOption.java
index 9b7772fcb..3c9e16340 100644
--- a/src/org/zlibrary/options/ZLSimpleOption.java
+++ b/src/org/zlibrary/options/ZLSimpleOption.java
@@ -18,7 +18,7 @@ abstract class ZLSimpleOption extends ZLOption {
 	 * конструктор. создается так же как и любая опция
 	 * @see ZLOption
 	 */
-	public ZLSimpleOption(ZLConfig config, String category, String group, String optionName){
-		super(config, category, group, optionName);
+	public ZLSimpleOption(String category, String group, String optionName){
+		super(category, group, optionName);
 	}
 }
diff --git a/src/org/zlibrary/options/ZLStringOption.java b/src/org/zlibrary/options/ZLStringOption.java
index 5e5a6e721..26951ff60 100644
--- a/src/org/zlibrary/options/ZLStringOption.java
+++ b/src/org/zlibrary/options/ZLStringOption.java
@@ -10,8 +10,8 @@ public final class ZLStringOption extends ZLSimpleOption {
 	private String myValue;
 	private String myDefaultValue;
 	
-    public ZLStringOption(ZLConfig config, String category, String group, String optionName, String defaultValue){
-        super(config, category, group, optionName);
+    public ZLStringOption(String category, String group, String optionName, String defaultValue){
+        super(category, group, optionName);
         myDefaultValue = defaultValue;
         myValue = myDefaultValue;
     }
diff --git a/src/org/zlibrary/options/config/ZLConfigFactory.java b/src/org/zlibrary/options/config/ZLConfigFactory.java
deleted file mode 100644
index 857d980d8..000000000
--- a/src/org/zlibrary/options/config/ZLConfigFactory.java
+++ /dev/null
@@ -1,7 +0,0 @@
-package org.zlibrary.options.config;
-
-public class ZLConfigFactory {
-    public static ZLConfigImpl createConfig(){
-        return new ZLConfigImpl();
-    }
-}
diff --git a/src/org/zlibrary/options/config/ZLConfigInstance.java b/src/org/zlibrary/options/config/ZLConfigInstance.java
new file mode 100644
index 000000000..707ff5555
--- /dev/null
+++ b/src/org/zlibrary/options/config/ZLConfigInstance.java
@@ -0,0 +1,10 @@
+package org.zlibrary.options.config;
+
+public class ZLConfigInstance {
+    
+    private static final ZLConfigImpl myConfig = new ZLConfigImpl();
+    
+    public static ZLConfigImpl getInstance(){
+        return myConfig;
+    }
+}
diff --git a/src/org/zlibrary/options/config/reader/ZLConfigReader.java b/src/org/zlibrary/options/config/reader/ZLConfigReader.java
index 8380920e0..cc0d024f3 100644
--- a/src/org/zlibrary/options/config/reader/ZLConfigReader.java
+++ b/src/org/zlibrary/options/config/reader/ZLConfigReader.java
@@ -8,11 +8,11 @@ import org.xml.sax.helpers.*;
 import org.zlibrary.options.ZLConfig;
 import org.zlibrary.options.config.*;
 
-/*package*/ class ZLConfigReader implements ZLReadable{
+/*package*/ class ZLConfigReader implements ZLReader{
 	
 	
 	private XMLReader myXMLReader;
-	private ZLConfig myConfig = ZLConfigFactory.createConfig();
+	private ZLConfig myConfig;
 	private String myCategory = "";
 	
 	private class ConfigContentHandler extends DefaultHandler{
@@ -59,15 +59,16 @@ import org.zlibrary.options.config.*;
 	}
 	
 	public ZLConfigReader () {
+        myConfig = ZLConfigInstance.getInstance();
 		try {
 			myXMLReader = XMLReaderFactory.createXMLReader();
 			myXMLReader.setContentHandler(new ConfigContentHandler());
 		} catch (SAXException e) {
-			System.err.println(e.getMessage());
+			System.out.println(e.getMessage());
 		}
 	}
 	
-	/** Прочитать данные из потока в XML */
+	/** Прочитать данные из файла XML */
 	public ZLConfig readFile (File file) {
 		try {
             InputStream input = new FileInputStream(file);
diff --git a/src/org/zlibrary/options/config/reader/ZLConfigReaderFactory.java b/src/org/zlibrary/options/config/reader/ZLConfigReaderFactory.java
index c20e6ac25..c2fd78698 100644
--- a/src/org/zlibrary/options/config/reader/ZLConfigReaderFactory.java
+++ b/src/org/zlibrary/options/config/reader/ZLConfigReaderFactory.java
@@ -1,7 +1,7 @@
 package org.zlibrary.options.config.reader;
 
 public class ZLConfigReaderFactory {
-	public ZLReadable createConfigReader(){
+	public ZLReader createConfigReader(){
 		return new ZLConfigReader();
 	}
 }
diff --git a/src/org/zlibrary/options/config/reader/ZLReadable.java b/src/org/zlibrary/options/config/reader/ZLReader.java
similarity index 78%
rename from src/org/zlibrary/options/config/reader/ZLReadable.java
rename to src/org/zlibrary/options/config/reader/ZLReader.java
index 12fceed4d..5bb3a952d 100644
--- a/src/org/zlibrary/options/config/reader/ZLReadable.java
+++ b/src/org/zlibrary/options/config/reader/ZLReader.java
@@ -4,6 +4,6 @@ import java.io.File;
 
 import org.zlibrary.options.ZLConfig;
 
-public interface ZLReadable {
+public interface ZLReader {
 	public ZLConfig readFile(File file);
 }
diff --git a/test/org/test/zlibrary/options/ModelTests.java b/test/org/test/zlibrary/options/ModelTests.java
index 19c5eb798..e6d7c77ce 100644
--- a/test/org/test/zlibrary/options/ModelTests.java
+++ b/test/org/test/zlibrary/options/ModelTests.java
@@ -2,7 +2,6 @@ package org.test.zlibrary.options;
 
 import junit.framework.*;
 import org.zlibrary.options.*;
-import org.zlibrary.options.config.*;
 import org.zlibrary.options.util.*;
 
 /**
@@ -31,20 +30,19 @@ public class ModelTests extends TestCase{
 	private final boolean myDefaultBoolean = true;
 	private final String myDefaultString = "Hello World";
 	private final double myDefaultDouble = 1.2;
-	private final ZLConfig myConfig = ZLConfigFactory.createConfig(); 
     
 	public void setUp(){
-		myColorOption = new ZLColorOption(myConfig, "","","my Color", new ZLColor (176, 255, 0)); 
-		myDoubleOption = new ZLDoubleOption(myConfig, "","","My Double", myDefaultDouble); 
-		myIntegerOption = new ZLIntegerOption(myConfig, "","","I", myDefaultInt); 
-		myIntegerRangeOption = new ZLIntegerRangeOption(myConfig, "","","IR", -90L, 90L, myDefaultIntRange); 
-		myBoolean3Option = new ZLBoolean3Option(myConfig, "","","my Boolean 3", myDefaultBoolean3); 
-		myBooleanOption = new ZLBooleanOption(myConfig, "","","my Boolean", myDefaultBoolean); 
-		myStringOption = new ZLStringOption(myConfig, "qw","qwe","my String", myDefaultString); 
+		myColorOption = new ZLColorOption("","","my Color", new ZLColor (176, 255, 0)); 
+		myDoubleOption = new ZLDoubleOption("","","My Double", myDefaultDouble); 
+		myIntegerOption = new ZLIntegerOption("","","I", myDefaultInt); 
+		myIntegerRangeOption = new ZLIntegerRangeOption("","","IR", -90L, 90L, myDefaultIntRange); 
+		myBoolean3Option = new ZLBoolean3Option("","","my Boolean 3", myDefaultBoolean3); 
+		myBooleanOption = new ZLBooleanOption("","","my Boolean", myDefaultBoolean); 
+		myStringOption = new ZLStringOption("qw","qwe","my String", myDefaultString); 
 	}
 	
 	public void test00_equals(){
-		ZLOption zlc = new ZLStringOption(myConfig, "qw", "qwe", "my String", "fire");
+		ZLOption zlc = new ZLStringOption("qw", "qwe", "my String", "fire");
 		assertTrue(zlc.equals(myStringOption));
 	}
 	
@@ -110,7 +108,7 @@ public class ModelTests extends TestCase{
 	
 	public void test02_integerRangeWrong(){
 		myIntegerRangeOption.setValue(10000000L);
-		assertEquals(myIntegerRangeOption.getValue(), 75L);
+		assertEquals(myIntegerRangeOption.getValue(), -1L);
 	}
 	
 	public void test02_boolean3(){