diff --git a/src/org/zlibrary/core/options/ZLBoolean3Option.java b/src/org/zlibrary/core/options/ZLBoolean3Option.java index 92ea2c786..36224e743 100644 --- a/src/org/zlibrary/core/options/ZLBoolean3Option.java +++ b/src/org/zlibrary/core/options/ZLBoolean3Option.java @@ -10,7 +10,7 @@ import org.zlibrary.core.options.util.*; */ public final class ZLBoolean3Option extends ZLSimpleOption { - private ZLBoolean3 myValue; + private ZLBoolean3 myValue; private final ZLBoolean3 myDefaultValue; public ZLBoolean3Option(String category, String group, String optionName, ZLBoolean3 defaultValue) { @@ -26,8 +26,10 @@ public final class ZLBoolean3Option extends ZLSimpleOption { public ZLBoolean3 getValue() { if (!myIsSynchronized) { String value = myConfig.getValue(myGroup, myOptionName, - myDefaultValue.toString()); - myValue = ZLFromStringConverter.getBoolean3Value(value); + null); + if (value != null) { + myValue = ZLFromStringConverter.getBoolean3Value(value); + } myIsSynchronized = true; } return myValue; diff --git a/src/org/zlibrary/core/options/ZLBooleanOption.java b/src/org/zlibrary/core/options/ZLBooleanOption.java index 01fc8bee3..a7266b950 100644 --- a/src/org/zlibrary/core/options/ZLBooleanOption.java +++ b/src/org/zlibrary/core/options/ZLBooleanOption.java @@ -16,13 +16,11 @@ public final class ZLBooleanOption extends ZLSimpleOption { public boolean getValue() { if (!myIsSynchronized) { - String value; - if (myDefaultValue) { - value = myConfig.getValue(myGroup, myOptionName, "true"); - } else { - value = myConfig.getValue(myGroup, myOptionName, "false"); - } - myValue = ZLFromStringConverter.getBooleanValue(value); + + String value = myConfig.getValue(myGroup, myOptionName, null); + if (value != null) { + myValue = ZLFromStringConverter.getBooleanValue(value); + } myIsSynchronized = true; } return myValue; @@ -37,11 +35,11 @@ public final class ZLBooleanOption extends ZLSimpleOption { if (myValue == myDefaultValue) { myConfig.unsetValue(myGroup, myOptionName); } else { - if (myValue) { - myConfig.setValue(myGroup, myOptionName, "true", myCategory); - } else { - myConfig.setValue(myGroup, myOptionName, "false", myCategory); - } + if (myValue) { + myConfig.setValue(myGroup, myOptionName, "true", myCategory); + } else { + myConfig.setValue(myGroup, myOptionName, "false", myCategory); + } } } } diff --git a/src/org/zlibrary/core/options/ZLColorOption.java b/src/org/zlibrary/core/options/ZLColorOption.java index b3268fe0b..c35bdcc39 100644 --- a/src/org/zlibrary/core/options/ZLColorOption.java +++ b/src/org/zlibrary/core/options/ZLColorOption.java @@ -22,9 +22,10 @@ public final class ZLColorOption extends ZLOption { public int getValue() { if (!myIsSynchronized) { - String strDefaultValue = ((Integer)myDefaultValue).toString(); - String value = myConfig.getValue(myGroup, myOptionName, strDefaultValue); - myIntValue = ZLFromStringConverter.getIntegerValue(value); + String value = myConfig.getValue(myGroup, myOptionName, null); + if (value != null) { + myIntValue = ZLFromStringConverter.getIntegerValue(value); + } myIsSynchronized = true; } return myIntValue; diff --git a/src/org/zlibrary/core/options/ZLDoubleOption.java b/src/org/zlibrary/core/options/ZLDoubleOption.java index dc406a14d..9d82aad2c 100644 --- a/src/org/zlibrary/core/options/ZLDoubleOption.java +++ b/src/org/zlibrary/core/options/ZLDoubleOption.java @@ -17,9 +17,11 @@ public final class ZLDoubleOption extends ZLOption{ public double getValue() { if (!myIsSynchronized) { - String strDefaultValue = ((Double)myDefaultValue).toString(); - String value = myConfig.getValue(myGroup, myOptionName, strDefaultValue); - myValue = ZLFromStringConverter.getDoubleValue(value); + String value = myConfig.getValue(myGroup, myOptionName, + null); + if (value != null) { + myValue = ZLFromStringConverter.getDoubleValue(value); + } myIsSynchronized = true; } return myValue; diff --git a/src/org/zlibrary/core/options/ZLFromStringConverter.java b/src/org/zlibrary/core/options/ZLFromStringConverter.java index 130bcb154..70f4678ab 100644 --- a/src/org/zlibrary/core/options/ZLFromStringConverter.java +++ b/src/org/zlibrary/core/options/ZLFromStringConverter.java @@ -5,14 +5,14 @@ import org.zlibrary.core.options.util.ZLColor; /*package*/ class ZLFromStringConverter { - public static ZLBoolean3 getBoolean3Value(String input){ + public static ZLBoolean3 getBoolean3Value(String input){ if (input.toLowerCase().equals("true")) { return ZLBoolean3.B3_TRUE; } - if (input.toLowerCase().equals("false")) { + if (input.toLowerCase().equals("false")) { return ZLBoolean3.B3_FALSE; - } - return ZLBoolean3.B3_UNDEFINED; + } + return ZLBoolean3.B3_UNDEFINED; } public static boolean getBooleanValue(String input){ @@ -24,22 +24,23 @@ import org.zlibrary.core.options.util.ZLColor; } public static double getDoubleValue(String input){ - try { - double value = Double.parseDouble(input); - return value; - } catch (NumberFormatException e) { - System.err.println("wrong format : " + input); - return 0; - } + try { + double value = Double.parseDouble(input); + return value; + } catch (NumberFormatException e) { + System.err.println("wrong format : " + input); + return 0; + } } public static int getIntegerValue(String input){ - try { - int value = Integer.parseInt(input); - return value; - } catch (NumberFormatException e) { - System.err.println("wrong format : " + input); - return 0; - } + try { + int value = Integer.parseInt(input); + return value; + } catch (NumberFormatException e) { + //e.printStackTrace(); + System.err.println("wrong format : " + input); + return 0; + } } } diff --git a/src/org/zlibrary/core/options/ZLIntegerOption.java b/src/org/zlibrary/core/options/ZLIntegerOption.java index 7b290f9a0..e9dbfd4b2 100644 --- a/src/org/zlibrary/core/options/ZLIntegerOption.java +++ b/src/org/zlibrary/core/options/ZLIntegerOption.java @@ -17,9 +17,10 @@ public final class ZLIntegerOption extends ZLOption{ public int getValue() { if (!myIsSynchronized) { - String strDefaultValue = ((Integer)myDefaultValue).toString(); - String value = myConfig.getValue(myGroup, myOptionName, strDefaultValue); - myValue = ZLFromStringConverter.getIntegerValue(value); + String value = myConfig.getValue(myGroup, myOptionName, null); + if (value != null) { + myValue = ZLFromStringConverter.getIntegerValue(value); + } myIsSynchronized = true; } return myValue; diff --git a/src/org/zlibrary/core/options/ZLIntegerRangeOption.java b/src/org/zlibrary/core/options/ZLIntegerRangeOption.java index c90b5594b..cbf1063d9 100644 --- a/src/org/zlibrary/core/options/ZLIntegerRangeOption.java +++ b/src/org/zlibrary/core/options/ZLIntegerRangeOption.java @@ -30,10 +30,10 @@ public final class ZLIntegerRangeOption extends ZLOption { public int getValue() { if (!myIsSynchronized) { - String strDefaultValue = ((Integer)myDefaultValue).toString(); - String value = myConfig.getValue(myGroup, - myOptionName, strDefaultValue); - myValue = ZLFromStringConverter.getIntegerValue(value); + String value = myConfig.getValue(myGroup, myOptionName, null); + if (value != null) { + myValue = ZLFromStringConverter.getIntegerValue(value); + } myIsSynchronized = true; } return myValue; diff --git a/src/org/zlibrary/core/options/ZLOption.java b/src/org/zlibrary/core/options/ZLOption.java index ac62d8049..c2a39686c 100644 --- a/src/org/zlibrary/core/options/ZLOption.java +++ b/src/org/zlibrary/core/options/ZLOption.java @@ -26,8 +26,8 @@ public abstract class ZLOption { myCategory = category; myGroup = group; myOptionName = name; - myIsSynchronized = false; - myConfig.setCategory(group, name, category); + myIsSynchronized = false; + myConfig.setCategory(group, name, category); } /** diff --git a/src/org/zlibrary/core/options/config/ZLConfig.java b/src/org/zlibrary/core/options/config/ZLConfig.java index d4de8860c..360dd75b4 100644 --- a/src/org/zlibrary/core/options/config/ZLConfig.java +++ b/src/org/zlibrary/core/options/config/ZLConfig.java @@ -3,6 +3,6 @@ package org.zlibrary.core.options.config; public interface ZLConfig extends ZLSimpleConfig { public void applyDelta(); public void clearDelta(); - public ZLDeltaConfig getDelta(); - public void setCategory(String group, String name, String category); + public ZLDeltaConfig getDelta(); + public void setCategory(String group, String name, String category); } diff --git a/src/org/zlibrary/core/options/config/ZLConfigImpl.java b/src/org/zlibrary/core/options/config/ZLConfigImpl.java index 28ca861d3..6222ca030 100644 --- a/src/org/zlibrary/core/options/config/ZLConfigImpl.java +++ b/src/org/zlibrary/core/options/config/ZLConfigImpl.java @@ -11,10 +11,10 @@ import java.util.Map; myDeltaConfig = new ZLDeltaConfig(); } - public ZLDeltaConfig getDelta() { - return myDeltaConfig; - } - + public ZLDeltaConfig getDelta() { + return myDeltaConfig; + } + public Map getGroups() { return myMainConfig.getGroups(); } @@ -22,9 +22,9 @@ import java.util.Map; public String getValue(String group, String name, String defaultValue) { String value = myDeltaConfig.getValue(group, name, defaultValue); if (value == defaultValue) { - value = myMainConfig.getValue(group, name, defaultValue); + value = myMainConfig.getValue(group, name, defaultValue); } - return value; + return value; } public void setCategory(String group, String name, String cat) { @@ -55,9 +55,9 @@ import java.util.Map; Map deletedValues = myDeltaConfig.getDeletedValues().getGroups(); for (String group : deletedValues.keySet()) { - for (ZLOptionValue option : deletedValues.get(group).getValues()) { - myMainConfig.unsetValue(group, option.getName()); - } + for (ZLOptionValue option : deletedValues.get(group).getValues()) { + myMainConfig.unsetValue(group, option.getName()); + } } ZLSimpleConfigImpl setValues = myDeltaConfig.getSetValues(); diff --git a/src/org/zlibrary/core/options/config/ZLDeltaConfig.java b/src/org/zlibrary/core/options/config/ZLDeltaConfig.java index c85d5f689..d1c3d1e47 100644 --- a/src/org/zlibrary/core/options/config/ZLDeltaConfig.java +++ b/src/org/zlibrary/core/options/config/ZLDeltaConfig.java @@ -30,13 +30,13 @@ import java.util.*; public void setValue(String group, String name, String value, String category) { mySetValues.setValue(group, name, value, category); } - - public void setCategory(String group, String name, String cat) { - mySetValues.setCategory(group, name, cat); - } + + public void setCategory(String group, String name, String cat) { + mySetValues.setCategory(group, name, cat); + } public void unsetValue(String group, String name) { - //TODO ÝÒÎ ÏËÎÕÎ?? + //TODO ÝÒÎ ÏËÎÕÎ?? myDeletedValues.setValue(group, name, null, null); mySetValues.unsetValue(group, name); } @@ -51,34 +51,34 @@ import java.util.*; myDeletedGroups.clear(); mySetValues.clear(); } - - public String toString() { - StringBuffer sb = new StringBuffer("\n \n"); - for (String group : myDeletedGroups) { - sb.append(" \n"); - } + + public String toString() { + StringBuffer sb = new StringBuffer("\n \n"); + for (String group : myDeletedGroups) { + sb.append(" \n"); + } - Map values = myDeletedValues.getGroups(); - for (String group : values.keySet()) { - sb.append(" \n"); - for (ZLOptionValue option : values.get(group).getValues()) { - sb.append(" \n"); - } - sb.append(" \n"); - - values = mySetValues.getGroups(); - for (String group : values.keySet()) { - sb.append(" \n"); - for (ZLOptionValue option : values.get(group).getValues()) { - sb.append(" \n"); - } - sb.append(""); - return sb.toString(); - } + Map values = myDeletedValues.getGroups(); + for (String group : values.keySet()) { + sb.append(" \n"); + for (ZLOptionValue option : values.get(group).getValues()) { + sb.append(" \n"); + } + sb.append(" \n"); + + values = mySetValues.getGroups(); + for (String group : values.keySet()) { + sb.append(" \n"); + for (ZLOptionValue option : values.get(group).getValues()) { + sb.append(" \n"); + } + sb.append(""); + return sb.toString(); + } } diff --git a/src/org/zlibrary/core/options/config/ZLGroup.java b/src/org/zlibrary/core/options/config/ZLGroup.java index 3c816d4f6..cb34f6637 100644 --- a/src/org/zlibrary/core/options/config/ZLGroup.java +++ b/src/org/zlibrary/core/options/config/ZLGroup.java @@ -13,10 +13,10 @@ public final class ZLGroup { return Collections.unmodifiableCollection(myData.values()); } - protected ZLOptionValue getOption(String name) { - return myData.get(name); - } - + protected ZLOptionValue getOption(String name) { + return myData.get(name); + } + public String getValue(String name){ ZLOptionValue temp = myData.get(name); if (temp != null){ diff --git a/src/org/zlibrary/core/options/config/ZLOptionValue.java b/src/org/zlibrary/core/options/config/ZLOptionValue.java index 2e2d72a0b..491d8ea64 100644 --- a/src/org/zlibrary/core/options/config/ZLOptionValue.java +++ b/src/org/zlibrary/core/options/config/ZLOptionValue.java @@ -6,15 +6,15 @@ public class ZLOptionValue { private String myName = ""; public ZLOptionValue(String name, String value, String category) { - if (value != null) { - myValue = value.intern(); - } - if (category != null) { - myCategory = category.intern(); - } - if (name != null) { - myName = name.intern(); - } + if (value != null) { + myValue = value.intern(); + } + if (category != null) { + myCategory = category.intern(); + } + if (name != null) { + myName = name.intern(); + } } public void setValue(String value) { @@ -34,10 +34,10 @@ public class ZLOptionValue { public String getCategory() { return myCategory; } - - public void setCategory(String cat) { - myCategory = cat; - } + + public void setCategory(String cat) { + myCategory = cat; + } public String toString() { return "