yetangitu/Jamstash
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes the "non-finite value" error when volume has never been set

Browse source 
- When Volume has never been stored in local storage, it causes "non-finite value" errors in jPlayer. persistence-service will now return 1.0 if it's not set.
This commit is contained in:
Hyzual 2015-03-25 23:57:09 +01:00
parent 025be32fc7
commit a6854e33f6
3 changed files with 24 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

27
app/common/persistence-service_test.js
View file

@ -46,6 +46,9 @@ describe("Persistence service", function() {
locker.get.and.callFake(function(key) {
return fakeStorage[key];
});
locker.put.and.callFake(function(key, value) {
fakeStorage[key] = value;
});
});
describe("loadTrackPosition() -", function() {
@ -132,11 +135,12 @@ describe("Persistence service", function() {
expect(volume).toBe(0.46582);
});
it("Given that no volume value was previously saved in local storage, it returns undefined", function() {
it("Given that no volume value was previously saved in local storage, it will return 1.0 and set it in local storage", function() {
var volume = persistence.getVolume();
expect(locker.get).toHaveBeenCalledWith('Volume');
expect(volume).toBeUndefined();
expect(volume).toBe(1.0);
expect(locker.put).toHaveBeenCalledWith('Volume', 1.0);
});
});
@ -151,7 +155,17 @@ describe("Persistence service", function() {
});
describe("getSettings() -", function() {
it("Given previously saved user settings in local storage, it retrieves them", function() {
beforeEach(function() {
spyOn(persistence, 'upgradeVersion');
json.getChangeLog.and.callFake(function (callback) {
callback([
{version: '1.0.1'}
]);
});
fakeStorage.JamstashVersion = '1.0.1';
});
it("Given previously saved user settings in local storage, a promise will be resovled with the user settings", function() {
fakeStorage = {
"Settings": {
"url": "https://headed.com/aleurodidae/taistrel?a=roquet&b=trichophoric#cathole",
@ -170,13 +184,6 @@ describe("Persistence service", function() {
it("Given that the previously stored Jamstash version was '1.0.0' and given the latest version in changelog.json was '1.0.1', when I get the settings, then upgradeVersion will be called", function() {
fakeStorage.JamstashVersion = '1.0.0';
spyOn(persistence, 'upgradeVersion');
json.getChangeLog.and.callFake(function (callback) {
console.log('callback', callback);
callback([
{version: '1.0.1'}
]);
});
persistence.getSettings();