Enabling this can help with seeking within transcoded media.
Without knowing how big a file is, it's impossible to display an
accurate progress bar. This option asks the server to send a
"Content-Length" header with a guess (based on bitrate and song length)
of how big the streamed file is going to be, enabling a progress bar to
be shown.
This reliably works with CBR transcodes, but can have issues with VBR as
the server doesn't know how big the file will be before it's transcoded.
If the server estimates incorrectly then songs could stop playing before
they actually finish or cause other glitches.
For the most part servers are pretty good with their estimates and being
able to seek in a transcoded stream as it downloads is a substantial UX
improvement so the option is enabled by default.
- Moves the functions to make the jukebox-related API calls to the
subsonic service
- Initiate the API calls from the player directive to centralize the
logic.
- Using space to play/pause was broken due to an issue with data
binding. Running `$scope.$apply()` after updating the `player.pauseSong`
property using `player.togglePause()` seems to have fixed this.
- All of the key event processing has been moved into the JS. This means
that all the key event logic is all in one spot (easier to understand
IMO). Additionally, this removes the need to redefine functions for
each shortcut.
- Removed the now-unused `angular-ui-utils/keypress.js` package.
- Fixed key events being active when editing dropdown/checkbox controls
in the settings menu
- Removed the custom `[Home]` shortcut since this is done natively by
the browser already.
- Removed the 1-6 shortcuts for the tabs. Logic being that it seems
pretty rare that you would want to rapidly switch between them (you
would have to use the mouse to do anything on all tabs except the
subsonic one anyway), and they were already broken without anyone
complaining.
- Fixed tests
This fixes an issue where attempting to rapidly remove songs from the
queue would cause them to be played.
- When clicking the add/play/remove/star buttons quickly, the double
click event would propagate and start playing the song
- Fixed by extending the `stopEvent` directive to accept a
comma-delimited list of events to stop. This allowed for using
`stop-event="click,dblclick"` in the html to not propagate both click
and double click events.
- Also removed some duplicate directives that seemed to have snuck in
during a merge.
**Please do a 'bower install' and 'npm install' to update**
**You should probably also do a 'bower prune' and 'npm prune' to remove deprecated dependencies !**
* Fixestsquillario/Jamstash#217
* Remove subsonic.js getStarred()
* Rename subsonic's getSongs() to getDirectory()
* Remove songs_lite.html
* Refactor queue.js
* Added angular-ui's ui-sortable directive as a bower dependency
* Refactor song selection across the app
* Refactor subsonic.js' loadPlaylistsForMenu
* Refactor subsonic-service.js to improve readability
* Updated bower deps to their latest versions
* Add a VersionEye badge in the README to track our dependencies
* Minor code style adjustments to comply with our jscsrc.
* Changed the localStorage key used to store the genre playlists names
* Enable removing genre auto-playlists from the list
* Use angular cache when querying getMusicFolders and getIndexes
* Refactor getAlbumListBy()
* Rework of the JSCS and JSHint configs
* Refactor breadcrumbs into a directive.
* Removes getAlbums() in subsonic-service, replaced by getSongs()
* Removes getSongTemplate() in subsonic-service which appears unused.
* Replaced Underscore with Lodash
* Fetch users' ID3 genres using Subsonic
* Update all npm packages, removes the "undef" rule to enable johnpapa's style
* Display the loading spinner gif for all angular ajax requests
- Added angular-ui's ui-sortable directive
- Removed our custom drag & drop handlers, they are replaced by ui-sortable.
- Refactored queue.js to better comply with https://github.com/johnpapa/angular-styleguide#controllers. Having the exposed
- Added a new SelectedSongs service. Its purpose is to store an array of selected songs and all behaviour associated with it : adding songs to it, removing them, toggling a song, etc. It also changes each song's selected property.
- Removed selectAll, selectNone, playAll, playFrom, addSongsToQueue and selectSong from main-controller.js. Those are now defined either in queue.js, subsonic.js or archive.js, depending on where they are used. I know it does add some duplication between archive.js and subsonic.js, but this will be addressed in a later commit (maybe by creating a shared service).
- Refactored subsonic-service.js' addToPlaylist() and split it between subsonic-service.js and subsonic.js (like all the other playlist-related functions).
- Moved subsonic-service.js' songsRemoveSelected() to subsonic.js since it only removes songs from the scope.
- Removed $rootScope and utils (unused dependencies) from subsonic-service.js
I am aware that this means "wiping" users' choices of genre playlists, but consider the following :
- Previously, all they could choose from was a static list, whereas now one can choose from every genre available on the Subsonic server.
- We can't know what genres are available on the server when we're getting the saved value from localStorage. So a mapping might be possible but way too costly for a list of names that will only take a few clicks to recreate anyway.
- Added an svg "X" icon to enable removing auto-playlists
- Notice that the background-color and color change are done too, and since it's SVG, it takes only one image and some CSS to do both.
- Added a subsonic.css file. It is intended (long term) to have all subsonic view-related CSS styles.
- persistence-service now manages the selected genre auto-playlists names instead of utils.getValue().
- Rewrote persistence-service.js to comply with https://github.com/johnpapa/angular-styleguide#style-y052
- Rewrote many test descriptions in persistence-service_test.js to follow these recommendations : http://gojko.net/2015/02/25/how-to-get-the-most-out-of-given-when-then/
It saves us a few requests and helps making Jamstash faster.
It's unlikely that the artists list or the music folders will change during a Jamstash session. It's also an easy cache to reset: the user only has to reload the page.
