Jamstash

yetangitu/Jamstash

Fork 0

Commit graph

Author	SHA1	Message	Date
Hyzual	58829facd6	Minor code style adjustments to comply with our jscsrc.	2015-07-07 22:10:22 +02:00
Hyzual	392ef74eba	Rewrites notification service - showNotification takes a song as parameter and picks the information it needs itself. That way we avoid player-directive.js having utils as a dependency. - shortened the names of the methods a bit. Had to rename them in settings.js - Used $interval rather than window.setInterval in player-directive.js and in notification-service.js. It's easier to unit test them that way !	2015-01-17 19:15:08 +01:00

Author

SHA1

Message

Date

Hyzual

58829facd6

Minor code style adjustments to comply with our jscsrc.

2015-07-07 22:10:22 +02:00

Hyzual

392ef74eba

Rewrites notification service

- showNotification takes a song as parameter and picks the information it needs itself. That way we avoid player-directive.js having utils as a dependency.
- shortened the names of the methods a bit. Had to rename them in settings.js
- Used $interval rather than window.setInterval in player-directive.js and in notification-service.js. It's easier to unit test them that way !

2015-01-17 19:15:08 +01:00

2 commits