Commit graph

13 commits

Author SHA1 Message Date
Hyzual
b51e033c25 Merge branch 'rewrite_player' into develop 2015-01-17 19:42:30 +01:00
Hyzual
83869b7808 Adds angular-locker dependency.
- It makes it easier to use localStorage and sessionStorage "the angular way". It also does all the error handling so we don't need to.
- Adds back the automatic saving of the current track's position and playing queue in localStorage. It's fully unit tested.
- Adds back the notifications. Every time we change songs (if the setting is true), it displays a notification. Clicking on it goes to the next song, just like before.
- Bumps up the versions to the actual value on the various json files.
2015-01-17 19:13:43 +01:00
Hyzual
59762ae423 Adds unit tests on the jplayer directive.
The major functionnalities are tested :
- play the next song when the current song ends
- change the current song with the player service
- restart the current song with the player service
- Show the player controls and song details when playing a song

Adds jasmine-fixtures dev dependency (needed for the visibility test)
2015-01-17 19:13:42 +01:00
Hyzual
bf5f01d825 Replaces karma-growl-reporter by karma-notify-reporter
notify can use the native Windows 8, OS X and Linux notifications, and also supports Growl as a fallback.
2015-01-17 19:03:24 +01:00
Hyzual
ce53362fbb Adds the Growl reporter for karma.
Removes the sellout package, it can always be installed globally and is not needed.
2015-01-17 19:02:47 +01:00
Hyzual
b2a426eaa2 Adds karma-coverage to generate test coverage reports using Istanbul.
Test coverage files are in the /coverage folder.
They indicate us for each js file which lines we ran and which we didn't run during unit tests. This helps us know what to test next.

Conflicts:
	package.json
2015-01-17 18:59:44 +01:00
Trevor Squillario
c7b4ad4de0 4.3.1 jplayer update, chrome android debugging 2014-12-20 23:26:33 -05:00
Hyzual
f51391f4b9 Moves the new images to the app folder. Fixes some small issues.
Comments out the cssmin parts of the build since we no longer use split-pane css, which was the only one I could minify.
2014-11-09 18:39:03 +01:00
Hyzual
8f7a97d417 Puts ngAnnotate a little while after concat so there's no conflict. 2014-11-09 18:39:03 +01:00
Hyzual
696c51a64c Adds a wiredep config to automatically add bower dependencies to karma.conf.js.
Remove jasmine as a dev-dependency, already included in karma-jasmine
2014-11-09 18:39:01 +01:00
Hyzual
a9b4150272 Adds the complete subsonic ctrl function getRandomStarredSongs.
It has one parameter with 3 possible values :
- display: to display in the view,
- add: adds to the queue
- play: plays the first song and adds to the queue.

It is now called from the subsonic template.

All these are tested, errors from the server (both subsonic and http) are relayed to the user through notifications.

Conflicts:
	app/subsonic/subsonic.html
2014-11-09 16:21:14 +01:00
Hyzual
e18fbe2c5b Refactors the subsonic service test with jasmine promise matchers.
It makes them easier to read.

Conflicts:
	bower.json
2014-11-09 16:12:29 +01:00
Hyzual
a1d48bbd30 Reorganizes the entire app to follow Google's best practice recommendations for Angular App Structure.
see: https://docs.google.com/document/d/1XXMvReO8-Awi1EZXAXS4PzDzdNvV6pGcuaF4Q9821Es/pub

The files are now grouped by view / component.
Tests are located beside tested js files. The Grunt build will be responsible for only distributing actual files without the tests.
Each partial is at the same level as the js files related to it.
Ideally css files should be at the same level, maybe I'll refactor this later.

Moves all non-bower plugins to app/vendor.
Moves all images to app/images and styles to app/styles.
Merges the test and non-test jshintrc files.

Adds all the Jamstash contributors to the package.json file while I was refactoring.

Conflicts:
	app/app.js
	app/images/vgrabber.gif
	app/images/vgrabber2-active.gif
	app/images/vgrabber2-normal.gif
	app/index.html
2014-11-09 16:10:34 +01:00
Renamed from test/karma.conf.js (Browse further)