From 21e24c9e34c7b0fb5aaee0e0eb7c36d985f76808 Mon Sep 17 00:00:00 2001 From: whistlingwoods <72640314+whistlingwoods@users.noreply.github.com> Date: Sat, 6 Sep 2025 19:14:15 +0530 Subject: [PATCH] Apply review suggestions --- .../java/us/shandian/giga/service/DownloadManager.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/us/shandian/giga/service/DownloadManager.java b/app/src/main/java/us/shandian/giga/service/DownloadManager.java index 6aff4daf2..8d841a207 100644 --- a/app/src/main/java/us/shandian/giga/service/DownloadManager.java +++ b/app/src/main/java/us/shandian/giga/service/DownloadManager.java @@ -169,7 +169,7 @@ public class DownloadManager { // DON'T delete missions with storage issues - try to recover them if (mis.hasInvalidStorage() && mis.errCode != ERROR_PROGRESS_LOST) { // Only delete if it's truly unrecoverable (not just progress lost) - if (mis.storage == null && mis.errCode != ERROR_PROGRESS_LOST) { + if (mis.storage == null) { //noinspection ResultOfMethodCallIgnored sub.delete(); continue; @@ -612,11 +612,8 @@ public class DownloadManager { // Don't hide recoverable missions remove.removeIf(mission -> { - if (mission instanceof DownloadMission) { - DownloadMission dm = (DownloadMission) mission; - if (canRecoverMission(dm)) { - return false; // Don't remove recoverable missions - } + if (mission instanceof DownloadMission dm && canRecoverMission(dm)) { + return false; // Don't remove recoverable missions } return pending.remove(mission) || finished.remove(mission); });