yetangitu/OpenSTF
1
0
Fork 0
mirror of https://github.com/openstf/stf synced 2025-10-05 10:39:25 +02:00
Code Issues Releases Wiki Activity

Limit max number of DOM entries to 3000.

Browse source
This commit is contained in:
Gunther Brunner 2014-05-21 17:57:37 +09:00
parent 1b992d67a6
commit 3467cc6876
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
res/app/components/stf/logcat-table/logcat-table-directive.js
View file

@ -12,8 +12,18 @@ module.exports = function logcatTableDirective($rootScope, $timeout, LogcatServi
var scrollHeight = 0 var scrollHeight = 0
var parent = element[0] var parent = element[0]
var body = element.find('tbody')[0] var body = element.find('tbody')[0]
const maxEntriesBuffer = 3000
var numberOfEntries = 0
function incrementNumberEntry() {
numberOfEntries++
if (numberOfEntries > maxEntriesBuffer) {
scope.clearTable()
}
}
LogcatService.addEntryListener = function (entry) { LogcatService.addEntryListener = function (entry) {
incrementNumberEntry()
addRow(body, entry) addRow(body, entry)
} }
@ -22,6 +32,7 @@ module.exports = function logcatTableDirective($rootScope, $timeout, LogcatServi
//var fragment = document.createDocumentFragment() //var fragment = document.createDocumentFragment()
_.each(entries, function (entry) { _.each(entries, function (entry) {
// TODO: This is not adding all the entries after first scope creation // TODO: This is not adding all the entries after first scope creation
incrementNumberEntry()
addRow(body, entry, true) addRow(body, entry, true)
}) })
} }
@ -78,8 +89,6 @@ module.exports = function logcatTableDirective($rootScope, $timeout, LogcatServi
if (autoScroll && shouldAutoScroll() && !batchRequest) { if (autoScroll && shouldAutoScroll() && !batchRequest) {
_.throttle(scrollToBottom, 30)() _.throttle(scrollToBottom, 30)()
} }
console.log(data.message)
} }
function clearTable() { function clearTable() {
@ -91,6 +100,7 @@ module.exports = function logcatTableDirective($rootScope, $timeout, LogcatServi
scope.clearTable = function () { scope.clearTable = function () {
LogcatService.clear() LogcatService.clear()
numberOfEntries = 0
clearTable() clearTable()
} }

1
res/app/components/stf/logcat/logcat-service.js
View file

@ -4,7 +4,6 @@ var _s = require('underscore.string')
module.exports = function LogcatServiceFactory(socket, DeviceService, FilterStringService) { module.exports = function LogcatServiceFactory(socket, DeviceService, FilterStringService) {
var service = {} var service = {}
service.started = false service.started = false
service.maxEntriesBuffer = 5000
service.numberOfEntries = 0 service.numberOfEntries = 0
service.serverFilters = [ service.serverFilters = [