From 4234bb9e34b92a16200fb8e2adaa0d42f1e135aa Mon Sep 17 00:00:00 2001 From: Simo Kinnunen Date: Tue, 22 Jul 2014 12:55:33 +0900 Subject: [PATCH] Remove rutil in favor of the updated rethinkdb driver. --- lib/db/index.js | 9 +++++---- lib/db/setup.js | 7 +++---- lib/util/rutil.js | 26 -------------------------- 3 files changed, 8 insertions(+), 34 deletions(-) delete mode 100644 lib/util/rutil.js diff --git a/lib/db/index.js b/lib/db/index.js index cb71c9a6..55377fd7 100644 --- a/lib/db/index.js +++ b/lib/db/index.js @@ -1,5 +1,6 @@ +var r = require('rethinkdb') + var setup = require('./setup') -var rutil = require('../util/rutil') var logger = require('../util/logger') var lifecycle = require('../util/lifecycle') @@ -7,7 +8,7 @@ var db = module.exports = Object.create(null) var log = logger.createLogger('db') function connect() { - return rutil.connect({ + return r.connect({ // These environment variables are exposed when we --link to a // RethinkDB container. host: process.env.RETHINKDB_PORT_28015_TCP_ADDR || '127.0.0.1' @@ -42,14 +43,14 @@ db.connect = (function() { // Close connection, we don't really care if it hasn't been created yet or not db.close = function() { return db.connect().then(function(conn) { - return rutil.close(conn) + return conn.close() }) } // Small utility for running queries without having to acquire a connection db.run = function(q, options) { return db.connect().then(function(conn) { - return rutil.run(conn, q, options) + return q.run(conn, options) }) } diff --git a/lib/db/setup.js b/lib/db/setup.js index 07962fe5..374ba60c 100644 --- a/lib/db/setup.js +++ b/lib/db/setup.js @@ -2,7 +2,6 @@ var r = require('rethinkdb') var Promise = require('bluebird') var logger = require('../util/logger') -var rutil = require('../util/rutil') var tables = require('./tables') module.exports = function(conn) { @@ -17,7 +16,7 @@ module.exports = function(conn) { } function createDatabase() { - return rutil.run(conn, r.dbCreate(conn.db)) + return r.dbCreate(conn.db).run(conn) .then(function() { log.info('Database "%s" created', conn.db) }) @@ -31,7 +30,7 @@ module.exports = function(conn) { var tableOptions = { primaryKey: options.primaryKey } - return rutil.run(conn, r.tableCreate(table, tableOptions)) + return r.tableCreate(table, tableOptions).run(conn) .then(function() { log.info('Table "%s" created', table) }) @@ -54,7 +53,7 @@ module.exports = function(conn) { } function createIndex(table, index, fn) { - return rutil.run(conn, r.table(table).indexCreate(index, fn)) + return r.table(table).indexCreate(index, fn).run(conn) .then(function() { log.info('Index "%s"."%s" created', table, index) }) diff --git a/lib/util/rutil.js b/lib/util/rutil.js deleted file mode 100644 index ce1acce9..00000000 --- a/lib/util/rutil.js +++ /dev/null @@ -1,26 +0,0 @@ -var r = require('rethinkdb') -var re = require('rethinkdb/errors') -var Promise = require('bluebird') - -module.exports.errors = re - -module.exports.connect = function(options) { - var resolver = Promise.defer() - r.connect(options, resolver.callback) - return resolver.promise -} - -module.exports.close = function(conn, options) { - var resolver = Promise.defer() - if (!options) { - options = {} - } - conn.close(options, resolver.callback) - return resolver.promise -} - -module.exports.run = function(conn, q, options) { - var resolver = Promise.defer() - q.run(conn, options || {}, resolver.callback) - return resolver.promise -}