yetangitu/OpenSTF
1
0
Fork 0
mirror of https://github.com/openstf/stf synced 2025-10-05 02:29:26 +02:00
Code Issues Releases Wiki Activity

Get rid of switch statements in favor of an EventEmitter-based router for message handling.

Browse source
This commit is contained in:
Simo Kinnunen 2014-02-02 19:55:44 +09:00
parent ade611670e
commit 48d5648b9d
8 changed files with 224 additions and 188 deletions
Download patch file Download diff file Expand all files Collapse all files

52
lib/util/wireutil.js
View file

@ -30,7 +30,7 @@ module.exports = function(wire) {
, entry.identifier
)
return wireutil.envelope(wire.MessageType.DEVICE_LOG, message)
return wireutil.envelope(wire.MessageType.DeviceLogMessage, message)
}
, makeGroupMessage: function(channel, timeout, requirements) {
var message = new wire.GroupMessage(
@ -39,23 +39,23 @@ module.exports = function(wire) {
, requirements
)
return wireutil.envelope(wire.MessageType.GROUP, message)
return wireutil.envelope(wire.MessageType.GroupMessage, message)
}
, makeUngroupMessage: function(requirements) {
var message = new wire.UngroupMessage(requirements)
return wireutil.envelope(wire.MessageType.UNGROUP, message)
return wireutil.envelope(wire.MessageType.UngroupMessage, message)
}
, makeJoinGroupMessage: function(serial) {
var message = new wire.JoinGroupMessage(serial)
return wireutil.envelope(wire.MessageType.JOIN_GROUP, message)
return wireutil.envelope(wire.MessageType.JoinGroupMessage, message)
}
, makeLeaveGroupMessage: function(serial) {
var message = new wire.LeaveGroupMessage(serial)
return wireutil.envelope(wire.MessageType.LEAVE_GROUP, message)
return wireutil.envelope(wire.MessageType.LeaveGroupMessage, message)
}
, makeDevicePokeMessage: function(serial, channel) {
var message = new wire.DevicePokeMessage(serial, channel)
return wireutil.envelope(wire.MessageType.DEVICE_POKE, message)
return wireutil.envelope(wire.MessageType.DevicePokeMessage, message)
}
, makeDeviceIdentityMessage: function(serial, identity) {
var message = new wire.DeviceIdentityMessage(
@ -81,7 +81,7 @@ module.exports = function(wire) {
)
)
return wireutil.envelope(wire.MessageType.DEVICE_IDENTITY, message)
return wireutil.envelope(wire.MessageType.DeviceIdentityMessage, message)
}
, makeDevicePropertiesMessage: function(serial, properties) {
var message = new wire.DevicePropertiesMessage(
@ -91,7 +91,10 @@ module.exports = function(wire) {
})
)
return wireutil.envelope(wire.MessageType.DEVICE_PROPERTIES, message)
return wireutil.envelope(
wire.MessageType.DevicePropertiesMessage
, message
)
}
, makeDeviceStatusMessage: function(serial, type, provider) {
var message = new wire.DeviceStatusMessage(
@ -100,27 +103,36 @@ module.exports = function(wire) {
, provider
)
return wireutil.envelope(wire.MessageType.DEVICE_STATUS, message)
return wireutil.envelope(wire.MessageType.DeviceStatusMessage, message)
}
, makeProbeMessage: function() {
var message = new wire.ProbeMessage()
return wireutil.envelope(wire.MessageType.PROBE, message)
return wireutil.envelope(wire.MessageType.ProbeMessage, message)
}
, makeShellCommandMessage: function(channel, command) {
var message = new wire.ShellCommandMessage(channel, command)
return wireutil.envelope(wire.MessageType.SHELL_COMMAND, message)
return wireutil.envelope(wire.MessageType.ShellCommandMessage, message)
}
, makeDeviceDataMessage: function(serial, seq, chunk) {
var message = new wire.DeviceDataMessage(serial, seq, chunk)
return wireutil.envelope(wire.MessageType.DEVICE_DATA, message)
, makeShellCommandDataMessage: function(serial, seq, chunk) {
var message = new wire.ShellCommandDataMessage(serial, seq, chunk)
return wireutil.envelope(
wire.MessageType.ShellCommandDataMessage
, message
)
}
, makeDeviceDoneMessage: function(serial) {
var message = new wire.DeviceDoneMessage(serial)
return wireutil.envelope(wire.MessageType.DEVICE_DONE, message)
, makeShellCommandDoneMessage: function(serial) {
var message = new wire.ShellCommandDoneMessage(serial)
return wireutil.envelope(
wire.MessageType.ShellCommandDoneMessage
, message
)
}
, makeDeviceFailMessage: function(serial, reason) {
var message = new wire.DeviceFailMessage(serial, reason)
return wireutil.envelope(wire.MessageType.DEVICE_FAIL, message)
, makeShellCommandFailMessage: function(serial, reason) {
var message = new wire.ShellCommandFailMessage(serial, reason)
return wireutil.envelope(
wire.MessageType.ShellCommandFailMessage
, message
)
}
}