remove unnecessary options from api unit. Improve error messages... etc etc

lib/cli.js

@@ -871,22 +871,15 @@ program
       , 'secret (or $SECRET)'
       , String
       , process.env.SECRET)
-    .option('-a, --auth-url <url>'
-      , 'URL to auth client'
-      , String)
     .action(function(options) {
       if (!options.secret) {
         this.missingArgument('--secret')
       }
-      if (!options.authUrl) {
-        this.missingArgument('--auth-url')
-      }
 
       require('./units/api')({
         port: options.port
       , ssid: options.ssid
       , secret: options.secret
-      , authUrl: options.authUrl
       })
     })
 
@@ -1335,12 +1328,6 @@ program
           'api'
         , '--port', options.apiPort
         , '--secret', options.authSecret
-        , '--auth-url', options.authUrl || util.format(
-            'http://%s:%d/auth/%s/'
-          , options.publicIp
-          , options.poorxyPort
-          , ({oauth2: 'oauth'}[options.authType]) || options.authType
-          )
       ])
         // websocket
       , procutil.fork(__filename, [

lib/units/api/controllers/device.js

@@ -4,12 +4,12 @@ var dbapi = require('../../../db/api')
 var logger = require('../../../util/logger')
 var datautil = require('../../../util/datautil')
 
-var log = logger.createLogger('api:contoller:device')
+var log = logger.createLogger('api:controllers:device')
 
 module.exports = {
   getDevices: getDevices
 , getDeviceBySerial: getDeviceBySerial
-};
+}
 
 function getDevices(req, res) {
   dbapi.loadDevices()

lib/units/api/controllers/token.js

@@ -3,11 +3,11 @@ var Promise = require('bluebird')
 var dbapi = require('../../../db/api')
 var logger = require('../../../util/logger')
 
-var log = logger.createLogger('api:contoller:token')
+var log = logger.createLogger('api:controllers:token')
 
 module.exports = {
   getAccessTokens: getAccessTokens
-};
+}
 
 function getAccessTokens(req, res) {
   dbapi.loadAccessTokens(req.user.email)

lib/units/api/controllers/user.js

@@ -4,12 +4,12 @@ var dbapi = require('../../../db/api')
 var logger = require('../../../util/logger')
 var datautil = require('../../../util/datautil')
 
-var log = logger.createLogger('api:contoller:user')
+var log = logger.createLogger('api:controllers:user')
 
 module.exports = {
   getCurrentUser: getCurrentUser
 , getCurrentUserGroup: getCurrentUserGroup
-};
+}
 
 function getCurrentUser(req, res) {
   res.json({

lib/units/api/helpers/securityHandlers.js

@@ -3,7 +3,7 @@ var urlutil = require('../../../util/urlutil')
 var logger = require('../../../util/logger')
 var dbapi = require('../../../db/api')
 
-var log = logger.createLogger('api:auth')
+var log = logger.createLogger('api:helpers:securityHandlers')
 
 module.exports = {
   accessTokenAuth: accessTokenAuth
@@ -27,24 +27,30 @@ function accessTokenAuth(req, res, next) {
                   next()
                 }
               })
+            } else {
+              res.json(500, {
+                success: false
+              })
             }
           })
         .catch(function(err) {
           log.error('Failed to load token: ', err.stack)
-          res.json(500, {
+          res.json(401, {
             success: false,
-            description: "Bad Access Token"
+            description: 'Bad credentials'
           })
         })
     } else {
-      log.error("Bad Access Token Header")
-      res.json(500, {
+      log.error('Bad Access Token Header')
+      res.json(401, {
         success: false,
-        description: "Bad Access Token Header"
+        description: 'Bad credentials'
       })
     }
   }
+  // Request is coming from browser app
   // TODO: Remove this once frontend become stateless
+  //       and start sending request without session
   else if (req.session && req.session.jwt) {
     dbapi.loadUser(req.session.jwt.email)
       .then(function(user) {
@@ -54,17 +60,16 @@ function accessTokenAuth(req, res, next) {
         }
         else {
           res.json(500, {
-            success: false,
-            description: "Bad Request"
+            success: false
           })
         }
       })
       .catch(next)
   }
   else {
-    res.json(500, {
+    res.json(401, {
       success: false,
-      description: "Request does not have Authorization header"
+      description: 'Requires authentication'
     })
   }
 }