yetangitu/OpenSTF
1
0
Fork 0
mirror of https://github.com/openstf/stf synced 2025-10-05 02:29:26 +02:00
Code Issues Releases Wiki Activity

Remove unused errors and make STF error codes match Android error codes better.

Browse source
This commit is contained in:
Simo Kinnunen 2014-09-05 14:00:51 +09:00
parent 254994ce3b
commit 77261ffd43
2 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/units/device/plugins/install.js
View file

@ -161,14 +161,14 @@ module.exports = syrup.serial()
.then(function() {
push.send([
channel
, reply.okay('success')
, reply.okay('INSTALL_SUCCEEDED')
])
})
.catch(Promise.TimeoutError, function(err) {
log.error('Installation of package "%s" failed', pkg, err.stack)
push.send([
channel
, reply.fail('timeout')
, reply.fail('INSTALL_ERROR_TIMEOUT')
])
})
.catch(InstallationError, function(err) {
@ -186,7 +186,7 @@ module.exports = syrup.serial()
log.error('Installation of package "%s" failed', pkg, err.stack)
push.send([
channel
, reply.fail('fail')
, reply.fail('INSTALL_ERROR_UNKNOWN')
])
})
})

12
res/app/components/stf/install/install-error-filter.js
View file

@ -6,15 +6,9 @@ var responses = require('./response-codes.json')
module.exports = function installErrorFilter(gettext) {
return function (text) {
switch (text) {
case 'fail_invalid_app_file':
return gettext('Uploaded file is not valid.')
case 'fail_download':
return gettext('Failed to download specified URL.')
case 'fail_invalid_url':
return gettext('The specified URL is invalid.')
case 'fail':
return gettext('Upload failed to due unknown error.')
case 'timeout':
case 'INSTALL_ERROR_UNKNOWN':
return gettext('Installation failed due to an unknown error.')
case 'INSTALL_ERROR_TIMEOUT':
return gettext('Installation timed out.')
default:
return gettext(responses[text] || text)