yetangitu/Peertube
1
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2025-10-06 03:50:26 +02:00
Code Issues Releases Wiki Activity

Remove exif tags when processing images

Browse source
This commit is contained in:
Chocobozzz 2022-03-07 17:16:54 +01:00
parent 2c7d736bd3
commit 0c058f256a
No known key found for this signature in database
GPG key ID: 583A612D890159BE
6 changed files with 67 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

58
server/tests/helpers/image.ts
View file

@ -4,6 +4,7 @@ import 'mocha'
import { expect } from 'chai'
import { readFile, remove } from 'fs-extra'
import { join } from 'path'
import { execPromise } from '@server/helpers/core-utils'
import { buildAbsoluteFixturePath, root } from '@shared/core-utils'
import { processImage } from '../../../server/helpers/image-utils'
@ -20,40 +21,77 @@ async function checkBuffers (path1: string, path2: string, equals: boolean) {
}
}
async function hasTitleExif (path: string) {
const result = JSON.parse(await execPromise(`exiftool -json ${path}`))
return result[0]?.Title === 'should be removed'
}
describe('Image helpers', function () {
const imageDestDir = join(root(), 'test-images')
const imageDest = join(imageDestDir, 'test.jpg')
const imageDestJPG = join(imageDestDir, 'test.jpg')
const imageDestPNG = join(imageDestDir, 'test.png')
const thumbnailSize = { width: 223, height: 122 }
it('Should skip processing if the source image is okay', async function () {
const input = buildAbsoluteFixturePath('thumbnail.jpg')
await processImage(input, imageDest, thumbnailSize, true)
await processImage(input, imageDestJPG, thumbnailSize, true)
await checkBuffers(input, imageDest, true)
await checkBuffers(input, imageDestJPG, true)
})
it('Should not skip processing if the source image does not have the appropriate extension', async function () {
const input = buildAbsoluteFixturePath('thumbnail.png')
await processImage(input, imageDest, thumbnailSize, true)
await processImage(input, imageDestJPG, thumbnailSize, true)
await checkBuffers(input, imageDest, false)
await checkBuffers(input, imageDestJPG, false)
})
it('Should not skip processing if the source image does not have the appropriate size', async function () {
const input = buildAbsoluteFixturePath('preview.jpg')
await processImage(input, imageDest, thumbnailSize, true)
await processImage(input, imageDestJPG, thumbnailSize, true)
await checkBuffers(input, imageDest, false)
await checkBuffers(input, imageDestJPG, false)
})
it('Should not skip processing if the source image does not have the appropriate size', async function () {
const input = buildAbsoluteFixturePath('thumbnail-big.jpg')
await processImage(input, imageDest, thumbnailSize, true)
await processImage(input, imageDestJPG, thumbnailSize, true)
await checkBuffers(input, imageDest, false)
await checkBuffers(input, imageDestJPG, false)
})
it('Should strip exif for a jpg file that can not be copied', async function () {
const input = buildAbsoluteFixturePath('exif.jpg')
expect(await hasTitleExif(input)).to.be.true
await processImage(input, imageDestJPG, { width: 100, height: 100 }, true)
await checkBuffers(input, imageDestJPG, false)
expect(await hasTitleExif(imageDestJPG)).to.be.false
})
it('Should strip exif for a jpg file that could be copied', async function () {
const input = buildAbsoluteFixturePath('exif.jpg')
expect(await hasTitleExif(input)).to.be.true
await processImage(input, imageDestJPG, thumbnailSize, true)
await checkBuffers(input, imageDestJPG, false)
expect(await hasTitleExif(imageDestJPG)).to.be.false
})
it('Should strip exif for png', async function () {
const input = buildAbsoluteFixturePath('exif.png')
expect(await hasTitleExif(input)).to.be.true
await processImage(input, imageDestPNG, thumbnailSize, true)
expect(await hasTitleExif(imageDestPNG)).to.be.false
})
after(async function () {
await remove(imageDest)
await remove(imageDestDir)
})
})