yetangitu/Peertube
1
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2025-10-05 02:39:33 +02:00
Code Issues Releases Wiki Activity

replace numbers with typed http status codes (#3409)

Browse source
This commit is contained in:
Rigel Kent 2020-12-07 14:32:36 +01:00 • committed by GitHub
parent adc1f09c0d
commit 2d53be0267
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
149 changed files with 1721 additions and 1108 deletions
Download patch file Download diff file Expand all files Collapse all files

43
server/tests/api/check-params/live.ts
View file

@ -24,6 +24,7 @@ import {
userLogin,
waitUntilLiveStarts
} from '../../../../shared/extra-utils'
import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
describe('Test video lives API validator', function () {
const path = '/api/v1/videos/live'
@ -226,7 +227,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields: baseCorrectParams,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
videoId = res.body.video.id
@ -244,7 +245,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields: baseCorrectParams,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
@ -263,7 +264,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
@ -282,7 +283,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
})
@ -299,7 +300,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields: baseCorrectParams,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
@ -317,7 +318,7 @@ describe('Test video lives API validator', function () {
path,
token: server.accessToken,
fields: baseCorrectParams,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
})
@ -325,27 +326,27 @@ describe('Test video lives API validator', function () {
describe('When getting live information', function () {
it('Should fail without access token', async function () {
await getLive(server.url, '', videoId, 401)
await getLive(server.url, '', videoId, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail with a bad access token', async function () {
await getLive(server.url, 'toto', videoId, 401)
await getLive(server.url, 'toto', videoId, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail with access token of another user', async function () {
await getLive(server.url, userAccessToken, videoId, 403)
await getLive(server.url, userAccessToken, videoId, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail with a bad video id', async function () {
await getLive(server.url, server.accessToken, 'toto', 400)
await getLive(server.url, server.accessToken, 'toto', HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with an unknown video id', async function () {
await getLive(server.url, server.accessToken, 454555, 404)
await getLive(server.url, server.accessToken, 454555, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail with a non live video', async function () {
await getLive(server.url, server.accessToken, videoIdNotLive, 404)
await getLive(server.url, server.accessToken, videoIdNotLive, HttpStatusCode.NOT_FOUND_404)
})
it('Should succeed with the correct params', async function () {
@ -356,33 +357,33 @@ describe('Test video lives API validator', function () {
describe('When updating live information', async function () {
it('Should fail without access token', async function () {
await updateLive(server.url, '', videoId, {}, 401)
await updateLive(server.url, '', videoId, {}, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail with a bad access token', async function () {
await updateLive(server.url, 'toto', videoId, {}, 401)
await updateLive(server.url, 'toto', videoId, {}, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail with access token of another user', async function () {
await updateLive(server.url, userAccessToken, videoId, {}, 403)
await updateLive(server.url, userAccessToken, videoId, {}, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail with a bad video id', async function () {
await updateLive(server.url, server.accessToken, 'toto', {}, 400)
await updateLive(server.url, server.accessToken, 'toto', {}, HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with an unknown video id', async function () {
await updateLive(server.url, server.accessToken, 454555, {}, 404)
await updateLive(server.url, server.accessToken, 454555, {}, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail with a non live video', async function () {
await updateLive(server.url, server.accessToken, videoIdNotLive, {}, 404)
await updateLive(server.url, server.accessToken, videoIdNotLive, {}, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail with save replay and permanent live set to true', async function () {
const fields = { saveReplay: true, permanentLive: true }
await updateLive(server.url, server.accessToken, videoId, fields, 400)
await updateLive(server.url, server.accessToken, videoId, fields, HttpStatusCode.BAD_REQUEST_400)
})
it('Should succeed with the correct params', async function () {
@ -397,7 +398,7 @@ describe('Test video lives API validator', function () {
}
})
await updateLive(server.url, server.accessToken, videoId, { saveReplay: true }, 403)
await updateLive(server.url, server.accessToken, videoId, { saveReplay: true }, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail to update a live if it has already started', async function () {
@ -409,7 +410,7 @@ describe('Test video lives API validator', function () {
const command = sendRTMPStream(live.rtmpUrl, live.streamKey)
await waitUntilLiveStarts(server.url, server.accessToken, videoId)
await updateLive(server.url, server.accessToken, videoId, {}, 400)
await updateLive(server.url, server.accessToken, videoId, {}, HttpStatusCode.BAD_REQUEST_400)
await stopFfmpeg(command)
})