yetangitu/Peertube
1
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2025-10-05 10:49:28 +02:00
Code Issues Releases Wiki Activity

replace numbers with typed http status codes (#3409)

Browse source
This commit is contained in:
Rigel Kent 2020-12-07 14:32:36 +01:00 • committed by GitHub
parent adc1f09c0d
commit 2d53be0267
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
149 changed files with 1721 additions and 1108 deletions
Download patch file Download diff file Expand all files Collapse all files

210
server/tests/api/check-params/users.ts
View file

@ -43,6 +43,7 @@ import { waitJobs } from '../../../../shared/extra-utils/server/jobs'
import { getGoodVideoUrl, getMagnetURI, getMyVideoImports, importVideo } from '../../../../shared/extra-utils/videos/video-imports'
import { UserAdminFlag } from '../../../../shared/models/users/user-flag.model'
import { VideoPrivacy } from '../../../../shared/models/videos'
import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
describe('Test users API validators', function () {
const path = '/api/v1/users/'
@ -160,7 +161,7 @@ describe('Test users API validators', function () {
await makeGetRequest({
url: server.url,
path,
statusCodeExpected: 401
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
@ -169,7 +170,7 @@ describe('Test users API validators', function () {
url: server.url,
path,
token: userAccessToken,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
})
@ -263,7 +264,7 @@ describe('Test users API validators', function () {
path: path,
token: server.accessToken,
fields,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
})
@ -279,20 +280,32 @@ describe('Test users API validators', function () {
path,
token: 'super token',
fields: baseCorrectParams,
statusCodeExpected: 401
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
it('Should fail if we add a user with the same username', async function () {
const fields = immutableAssign(baseCorrectParams, { username: 'user1' })
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 409 })
await makePostBodyRequest({
url: server.url,
path,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
it('Should fail if we add a user with the same email', async function () {
const fields = immutableAssign(baseCorrectParams, { email: 'user1@example.com' })
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 409 })
await makePostBodyRequest({
url: server.url,
path,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
it('Should fail without a videoQuota', async function () {
@ -339,7 +352,7 @@ describe('Test users API validators', function () {
path,
token: server.accessToken,
fields,
statusCodeExpected: 409
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
@ -352,7 +365,7 @@ describe('Test users API validators', function () {
path,
token: moderatorAccessToken,
fields,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
}
})
@ -365,7 +378,7 @@ describe('Test users API validators', function () {
path,
token: moderatorAccessToken,
fields,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
})
@ -375,7 +388,7 @@ describe('Test users API validators', function () {
path,
token: server.accessToken,
fields: baseCorrectParams,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
})
@ -392,7 +405,7 @@ describe('Test users API validators', function () {
password: 'my super password',
videoQuota: 42000000
}
await makePostBodyRequest({ url: server.url, path, token: userAccessToken, fields, statusCodeExpected: 403 })
await makePostBodyRequest({ url: server.url, path, token: userAccessToken, fields, statusCodeExpected: HttpStatusCode.FORBIDDEN_403 })
})
})
@ -438,7 +451,13 @@ describe('Test users API validators', function () {
password: 'super'.repeat(61)
}
await makePutBodyRequest({ url: server.url, path: path + 'me', token: userAccessToken, fields, statusCodeExpected: 401 })
await makePutBodyRequest({
url: server.url,
path: path + 'me',
token: userAccessToken,
fields,
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
it('Should fail with an invalid NSFW policy attribute', async function () {
@ -479,7 +498,13 @@ describe('Test users API validators', function () {
password: 'my super password'
}
await makePutBodyRequest({ url: server.url, path: path + 'me', token: 'super token', fields, statusCodeExpected: 401 })
await makePutBodyRequest({
url: server.url,
path: path + 'me',
token: 'super token',
fields,
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
it('Should fail with a too long description', async function () {
@ -551,7 +576,13 @@ describe('Test users API validators', function () {
noWelcomeModal: true
}
await makePutBodyRequest({ url: server.url, path: path + 'me', token: userAccessToken, fields, statusCodeExpected: 204 })
await makePutBodyRequest({
url: server.url,
path: path + 'me',
token: userAccessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
it('Should succeed without password change with the correct params', async function () {
@ -560,7 +591,13 @@ describe('Test users API validators', function () {
autoPlayVideo: false
}
await makePutBodyRequest({ url: server.url, path: path + 'me', token: userAccessToken, fields, statusCodeExpected: 204 })
await makePutBodyRequest({
url: server.url,
path: path + 'me',
token: userAccessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
})
@ -591,7 +628,7 @@ describe('Test users API validators', function () {
path: path + '/me/avatar/pick',
fields,
attaches,
statusCodeExpected: 401
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
@ -606,7 +643,7 @@ describe('Test users API validators', function () {
token: server.accessToken,
fields,
attaches,
statusCodeExpected: 200
statusCodeExpected: HttpStatusCode.OK_200
})
})
})
@ -614,11 +651,11 @@ describe('Test users API validators', function () {
describe('When managing my scoped tokens', function () {
it('Should fail to get my scoped tokens with an non authenticated user', async function () {
await getUserScopedTokens(server.url, null, 401)
await getUserScopedTokens(server.url, null, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail to get my scoped tokens with a bad token', async function () {
await getUserScopedTokens(server.url, 'bad', 401)
await getUserScopedTokens(server.url, 'bad', HttpStatusCode.UNAUTHORIZED_401)
})
@ -627,11 +664,11 @@ describe('Test users API validators', function () {
})
it('Should fail to renew my scoped tokens with an non authenticated user', async function () {
await renewUserScopedTokens(server.url, null, 401)
await renewUserScopedTokens(server.url, null, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail to renew my scoped tokens with a bad token', async function () {
await renewUserScopedTokens(server.url, 'bad', 401)
await renewUserScopedTokens(server.url, 'bad', HttpStatusCode.UNAUTHORIZED_401)
})
it('Should succeed to renew my scoped tokens', async function () {
@ -642,15 +679,20 @@ describe('Test users API validators', function () {
describe('When getting a user', function () {
it('Should fail with an non authenticated user', async function () {
await makeGetRequest({ url: server.url, path: path + userId, token: 'super token', statusCodeExpected: 401 })
await makeGetRequest({
url: server.url,
path: path + userId,
token: 'super token',
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
it('Should fail with a non admin user', async function () {
await makeGetRequest({ url: server.url, path, token: userAccessToken, statusCodeExpected: 403 })
await makeGetRequest({ url: server.url, path, token: userAccessToken, statusCodeExpected: HttpStatusCode.FORBIDDEN_403 })
})
it('Should succeed with the correct params', async function () {
await makeGetRequest({ url: server.url, path: path + userId, token: server.accessToken, statusCodeExpected: 200 })
await makeGetRequest({ url: server.url, path: path + userId, token: server.accessToken, statusCodeExpected: HttpStatusCode.OK_200 })
})
})
@ -711,7 +753,13 @@ describe('Test users API validators', function () {
videoQuota: 42
}
await makePutBodyRequest({ url: server.url, path: path + userId, token: 'super token', fields, statusCodeExpected: 401 })
await makePutBodyRequest({
url: server.url,
path: path + userId,
token: 'super token',
fields,
statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
})
})
it('Should fail when updating root role', async function () {
@ -738,7 +786,7 @@ describe('Test users API validators', function () {
path: path + moderatorId,
token: moderatorAccessToken,
fields,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
@ -752,7 +800,7 @@ describe('Test users API validators', function () {
path: path + userId,
token: moderatorAccessToken,
fields,
statusCodeExpected: 204
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
@ -764,13 +812,19 @@ describe('Test users API validators', function () {
role: UserRole.USER
}
await makePutBodyRequest({ url: server.url, path: path + userId, token: server.accessToken, fields, statusCodeExpected: 204 })
await makePutBodyRequest({
url: server.url,
path: path + userId,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
})
describe('When getting my information', function () {
it('Should fail with a non authenticated user', async function () {
await getMyUserInformation(server.url, 'fake_token', 401)
await getMyUserInformation(server.url, 'fake_token', HttpStatusCode.UNAUTHORIZED_401)
})
it('Should success with the correct parameters', async function () {
@ -780,15 +834,15 @@ describe('Test users API validators', function () {
describe('When getting my video rating', function () {
it('Should fail with a non authenticated user', async function () {
await getMyUserVideoRating(server.url, 'fake_token', videoId, 401)
await getMyUserVideoRating(server.url, 'fake_token', videoId, HttpStatusCode.UNAUTHORIZED_401)
})
it('Should fail with an incorrect video uuid', async function () {
await getMyUserVideoRating(server.url, server.accessToken, 'blabla', 400)
await getMyUserVideoRating(server.url, server.accessToken, 'blabla', HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with an unknown video', async function () {
await getMyUserVideoRating(server.url, server.accessToken, '4da6fde3-88f7-4d16-b119-108df5630b06', 404)
await getMyUserVideoRating(server.url, server.accessToken, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
})
it('Should succeed with the correct parameters', async function () {
@ -812,51 +866,57 @@ describe('Test users API validators', function () {
})
it('Should fail with a unauthenticated user', async function () {
await makeGetRequest({ url: server.url, path, statusCodeExpected: 401 })
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401 })
})
it('Should fail with a another user', async function () {
await makeGetRequest({ url: server.url, path, token: server.accessToken, statusCodeExpected: 403 })
await makeGetRequest({ url: server.url, path, token: server.accessToken, statusCodeExpected: HttpStatusCode.FORBIDDEN_403 })
})
it('Should fail with a bad type', async function () {
await makeGetRequest({ url: server.url, path, token: userAccessToken, query: { rating: 'toto ' }, statusCodeExpected: 400 })
await makeGetRequest({
url: server.url,
path,
token: userAccessToken,
query: { rating: 'toto ' },
statusCodeExpected: HttpStatusCode.BAD_REQUEST_400
})
})
it('Should succeed with the correct params', async function () {
await makeGetRequest({ url: server.url, path, token: userAccessToken, statusCodeExpected: 200 })
await makeGetRequest({ url: server.url, path, token: userAccessToken, statusCodeExpected: HttpStatusCode.OK_200 })
})
})
describe('When blocking/unblocking/removing user', function () {
it('Should fail with an incorrect id', async function () {
await removeUser(server.url, 'blabla', server.accessToken, 400)
await blockUser(server.url, 'blabla', server.accessToken, 400)
await unblockUser(server.url, 'blabla', server.accessToken, 400)
await removeUser(server.url, 'blabla', server.accessToken, HttpStatusCode.BAD_REQUEST_400)
await blockUser(server.url, 'blabla', server.accessToken, HttpStatusCode.BAD_REQUEST_400)
await unblockUser(server.url, 'blabla', server.accessToken, HttpStatusCode.BAD_REQUEST_400)
})
it('Should fail with the root user', async function () {
await removeUser(server.url, rootId, server.accessToken, 400)
await blockUser(server.url, rootId, server.accessToken, 400)
await unblockUser(server.url, rootId, server.accessToken, 400)
await removeUser(server.url, rootId, server.accessToken, HttpStatusCode.BAD_REQUEST_400)
await blockUser(server.url, rootId, server.accessToken, HttpStatusCode.BAD_REQUEST_400)
await unblockUser(server.url, rootId, server.accessToken, HttpStatusCode.BAD_REQUEST_400)
})
it('Should return 404 with a non existing id', async function () {
await removeUser(server.url, 4545454, server.accessToken, 404)
await blockUser(server.url, 4545454, server.accessToken, 404)
await unblockUser(server.url, 4545454, server.accessToken, 404)
await removeUser(server.url, 4545454, server.accessToken, HttpStatusCode.NOT_FOUND_404)
await blockUser(server.url, 4545454, server.accessToken, HttpStatusCode.NOT_FOUND_404)
await unblockUser(server.url, 4545454, server.accessToken, HttpStatusCode.NOT_FOUND_404)
})
it('Should fail with a non admin user', async function () {
await removeUser(server.url, userId, userAccessToken, 403)
await blockUser(server.url, userId, userAccessToken, 403)
await unblockUser(server.url, userId, userAccessToken, 403)
await removeUser(server.url, userId, userAccessToken, HttpStatusCode.FORBIDDEN_403)
await blockUser(server.url, userId, userAccessToken, HttpStatusCode.FORBIDDEN_403)
await unblockUser(server.url, userId, userAccessToken, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail on a moderator with a moderator', async function () {
await removeUser(server.url, moderatorId, moderatorAccessToken, 403)
await blockUser(server.url, moderatorId, moderatorAccessToken, 403)
await unblockUser(server.url, moderatorId, moderatorAccessToken, 403)
await removeUser(server.url, moderatorId, moderatorAccessToken, HttpStatusCode.FORBIDDEN_403)
await blockUser(server.url, moderatorId, moderatorAccessToken, HttpStatusCode.FORBIDDEN_403)
await unblockUser(server.url, moderatorId, moderatorAccessToken, HttpStatusCode.FORBIDDEN_403)
})
it('Should succeed on a user with a moderator', async function () {
@ -867,7 +927,7 @@ describe('Test users API validators', function () {
describe('When deleting our account', function () {
it('Should fail with with the root account', async function () {
await deleteMe(server.url, server.accessToken, 400)
await deleteMe(server.url, server.accessToken, HttpStatusCode.BAD_REQUEST_400)
})
})
@ -930,7 +990,7 @@ describe('Test users API validators', function () {
path: registrationPath,
token: server.accessToken,
fields,
statusCodeExpected: 409
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
@ -942,7 +1002,7 @@ describe('Test users API validators', function () {
path: registrationPath,
token: server.accessToken,
fields,
statusCodeExpected: 409
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
@ -954,7 +1014,7 @@ describe('Test users API validators', function () {
path: registrationPath,
token: server.accessToken,
fields,
statusCodeExpected: 409
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
@ -989,7 +1049,13 @@ describe('Test users API validators', function () {
const fields = immutableAssign(baseCorrectParams, { channel: { name: 'existing_channel', displayName: 'toto' } })
await makePostBodyRequest({ url: server.url, path: registrationPath, token: server.accessToken, fields, statusCodeExpected: 409 })
await makePostBodyRequest({
url: server.url,
path: registrationPath,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.CONFLICT_409
})
})
it('Should succeed with the correct params', async function () {
@ -1000,7 +1066,7 @@ describe('Test users API validators', function () {
path: registrationPath,
token: server.accessToken,
fields: fields,
statusCodeExpected: 204
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
@ -1016,14 +1082,14 @@ describe('Test users API validators', function () {
path: registrationPath,
token: serverWithRegistrationDisabled.accessToken,
fields,
statusCodeExpected: 403
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
})
})
})
describe('When registering multiple users on a server with users limit', function () {
it('Should fail when after 3 registrations', async function () {
await registerUser(server.url, 'user42', 'super password', 403)
await registerUser(server.url, 'user42', 'super password', HttpStatusCode.FORBIDDEN_403)
})
})
@ -1036,7 +1102,7 @@ describe('Test users API validators', function () {
videoQuota: 42
})
await uploadVideo(server.url, server.accessToken, {}, 403)
await uploadVideo(server.url, server.accessToken, {}, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail with a registered user having too many videos', async function () {
@ -1054,7 +1120,7 @@ describe('Test users API validators', function () {
await uploadVideo(server.url, userAccessToken, videoAttributes)
await uploadVideo(server.url, userAccessToken, videoAttributes)
await uploadVideo(server.url, userAccessToken, videoAttributes)
await uploadVideo(server.url, userAccessToken, videoAttributes, 403)
await uploadVideo(server.url, userAccessToken, videoAttributes, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail to import with HTTP/Torrent/magnet', async function () {
@ -1093,7 +1159,7 @@ describe('Test users API validators', function () {
videoQuotaDaily: 42
})
await uploadVideo(server.url, server.accessToken, {}, 403)
await uploadVideo(server.url, server.accessToken, {}, HttpStatusCode.FORBIDDEN_403)
})
})
@ -1107,7 +1173,7 @@ describe('Test users API validators', function () {
videoQuotaDaily: 1024 * 1024 * 1024
})
await uploadVideo(server.url, server.accessToken, {}, 403)
await uploadVideo(server.url, server.accessToken, {}, HttpStatusCode.FORBIDDEN_403)
})
it('Should fail if exceeding daily quota', async function () {
@ -1119,7 +1185,7 @@ describe('Test users API validators', function () {
videoQuotaDaily: 42
})
await uploadVideo(server.url, server.accessToken, {}, 403)
await uploadVideo(server.url, server.accessToken, {}, HttpStatusCode.FORBIDDEN_403)
})
})
@ -1141,7 +1207,13 @@ describe('Test users API validators', function () {
it('Should success with the correct params', async function () {
const fields = { email: 'admin@example.com' }
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 204 })
await makePostBodyRequest({
url: server.url,
path,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
})
@ -1163,7 +1235,13 @@ describe('Test users API validators', function () {
it('Should succeed with the correct params', async function () {
const fields = { email: 'admin@example.com' }
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 204 })
await makePostBodyRequest({
url: server.url,
path,
token: server.accessToken,
fields,
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
})
})
})