Correctly display multi select header

client/src/app/+admin/config/edit-custom-config/edit-advanced-configuration.component.ts

@@ -1,14 +1,13 @@
+import { NgClass, NgIf } from '@angular/common'
 import { Component, input } from '@angular/core'
 import { FormGroup, FormsModule, ReactiveFormsModule } from '@angular/forms'
-import { PeerTubeTemplateDirective } from '../../../shared/shared-main/common/peertube-template.directive'
 import { HelpComponent } from '../../../shared/shared-main/buttons/help.component'
-import { NgClass, NgIf } from '@angular/common'
 
 @Component({
   selector: 'my-edit-advanced-configuration',
   templateUrl: './edit-advanced-configuration.component.html',
   styleUrls: [ './edit-custom-config.component.scss' ],
-  imports: [ FormsModule, ReactiveFormsModule, NgClass, NgIf, HelpComponent, PeerTubeTemplateDirective ]
+  imports: [ FormsModule, ReactiveFormsModule, NgClass, NgIf, HelpComponent ]
 })
 export class EditAdvancedConfigurationComponent {
   readonly form = input<FormGroup>(undefined)

client/src/app/+admin/overview/users/user-edit/user-create.component.ts

@@ -24,7 +24,6 @@ import { PeertubeCheckboxComponent } from '../../../../shared/shared-forms/peert
 import { SelectCustomValueComponent } from '../../../../shared/shared-forms/select/select-custom-value.component'
 import { HelpComponent } from '../../../../shared/shared-main/buttons/help.component'
 import { BytesPipe } from '../../../../shared/shared-main/common/bytes.pipe'
-import { PeerTubeTemplateDirective } from '../../../../shared/shared-main/common/peertube-template.directive'
 import { UserRealQuotaInfoComponent } from '../../../shared/user-real-quota-info.component'
 import { UserEdit } from './user-edit'
 import { UserPasswordComponent } from './user-password.component'
@@ -42,7 +41,6 @@ import { UserPasswordComponent } from './user-password.component'
     ReactiveFormsModule,
     NgClass,
     HelpComponent,
-    PeerTubeTemplateDirective,
     InputTextComponent,
     NgFor,
     SelectCustomValueComponent,

client/src/app/+admin/overview/users/user-edit/user-update.component.ts

@@ -22,7 +22,6 @@ import { PeertubeCheckboxComponent } from '../../../../shared/shared-forms/peert
 import { SelectCustomValueComponent } from '../../../../shared/shared-forms/select/select-custom-value.component'
 import { HelpComponent } from '../../../../shared/shared-main/buttons/help.component'
 import { BytesPipe } from '../../../../shared/shared-main/common/bytes.pipe'
-import { PeerTubeTemplateDirective } from '../../../../shared/shared-main/common/peertube-template.directive'
 import { UserRealQuotaInfoComponent } from '../../../shared/user-real-quota-info.component'
 import { UserEdit } from './user-edit'
 import { UserPasswordComponent } from './user-password.component'
@@ -40,7 +39,6 @@ import { UserPasswordComponent } from './user-password.component'
     ReactiveFormsModule,
     NgClass,
     HelpComponent,
-    PeerTubeTemplateDirective,
     InputTextComponent,
     NgFor,
     SelectCustomValueComponent,

client/src/app/+video-watch/shared/comment/video-comment-add.component.ts

@@ -9,7 +9,6 @@ import { FormReactiveService } from '@app/shared/shared-forms/form-reactive.serv
 import { TextareaAutoResizeDirective } from '@app/shared/shared-forms/textarea-autoresize.directive'
 import { GlobalIconComponent } from '@app/shared/shared-icons/global-icon.component'
 import { HelpComponent } from '@app/shared/shared-main/buttons/help.component'
-import { PeerTubeTemplateDirective } from '@app/shared/shared-main/common/peertube-template.directive'
 import { LoginLinkComponent } from '@app/shared/shared-main/users/login-link.component'
 import { Video } from '@app/shared/shared-main/video/video.model'
 import { RemoteSubscribeComponent } from '@app/shared/shared-user-subscription/remote-subscribe.component'
@@ -30,7 +29,6 @@ import { Observable } from 'rxjs'
     TextareaAutoResizeDirective,
     NgClass,
     HelpComponent,
-    PeerTubeTemplateDirective,
     NgIf,
     GlobalIconComponent,
     RemoteSubscribeComponent,

client/src/app/+videos-publish-manage/+video-publish/import/video-import-torrent.component.ts

@@ -16,7 +16,6 @@ import { SelectChannelItem } from 'src/types'
 import { SelectChannelComponent } from '../../../shared/shared-forms/select/select-channel.component'
 import { GlobalIconComponent } from '../../../shared/shared-icons/global-icon.component'
 import { HelpComponent } from '../../../shared/shared-main/buttons/help.component'
-import { PeerTubeTemplateDirective } from '../../../shared/shared-main/common/peertube-template.directive'
 import { VideoManageContainerComponent } from '../../shared-manage/video-manage-container.component'
 import { DragDropDirective } from '../shared/drag-drop.directive'
 
@@ -33,7 +32,6 @@ const debugLogger = debug('peertube:video-publish')
     GlobalIconComponent,
     NgbTooltip,
     HelpComponent,
-    PeerTubeTemplateDirective,
     FormsModule,
     DragDropDirective,
     SelectChannelComponent,

client/src/app/+videos-publish-manage/+video-publish/import/video-import-url.component.ts

@@ -19,7 +19,6 @@ import { SelectChannelItem } from 'src/types'
 import { SelectChannelComponent } from '../../../shared/shared-forms/select/select-channel.component'
 import { GlobalIconComponent } from '../../../shared/shared-icons/global-icon.component'
 import { HelpComponent } from '../../../shared/shared-main/buttons/help.component'
-import { PeerTubeTemplateDirective } from '../../../shared/shared-main/common/peertube-template.directive'
 import { VideoManageContainerComponent } from '../../shared-manage/video-manage-container.component'
 
 const debugLogger = debug('peertube:video-publish')
@@ -32,7 +31,6 @@ const debugLogger = debug('peertube:video-publish')
     NgIf,
     GlobalIconComponent,
     HelpComponent,
-    PeerTubeTemplateDirective,
     FormsModule,
     RouterLink,
     SelectChannelComponent,

client/src/app/+videos-publish-manage/shared-manage/video-manage-menu.component.ts

@@ -7,9 +7,8 @@ import { NgbTooltipModule } from '@ng-bootstrap/ng-bootstrap'
 import { GlobalIconComponent } from '../../shared/shared-icons/global-icon.component'
 import { getReplaceFileUnavailability, getStudioUnavailability } from './common/unavailable-features'
 import { VideoEdit } from './common/video-edit.model'
-import { VideoManageController } from './video-manage-controller.service'
-import { HelpComponent } from '../../shared/shared-main/buttons/help.component'
 import { UnavailableMenuEntryComponent } from './unavailable-menu-entry.component'
+import { VideoManageController } from './video-manage-controller.service'
 
 @Component({
   selector: 'my-video-manage-menu',
@@ -22,7 +21,6 @@ import { UnavailableMenuEntryComponent } from './unavailable-menu-entry.componen
     ReactiveFormsModule,
     NgbTooltipModule,
     GlobalIconComponent,
-    HelpComponent,
     UnavailableMenuEntryComponent
   ]
 })

client/src/app/shared/shared-forms/peertube-checkbox.component.ts

@@ -1,7 +1,7 @@
-import { AfterContentInit, Component, forwardRef, TemplateRef, input, model, contentChildren } from '@angular/core'
-import { ControlValueAccessor, NG_VALUE_ACCESSOR, FormsModule } from '@angular/forms'
-import { HelpComponent } from '../shared-main/buttons/help.component'
 import { NgIf, NgTemplateOutlet } from '@angular/common'
+import { AfterContentInit, Component, contentChildren, forwardRef, input, model, TemplateRef } from '@angular/core'
+import { ControlValueAccessor, FormsModule, NG_VALUE_ACCESSOR } from '@angular/forms'
+import { HelpComponent } from '../shared-main/buttons/help.component'
 import { PeerTubeTemplateDirective } from '../shared-main/common/peertube-template.directive'
 
 @Component({
@@ -15,7 +15,7 @@ import { PeerTubeTemplateDirective } from '../shared-main/common/peertube-templa
       multi: true
     }
   ],
-  imports: [ FormsModule, NgIf, NgTemplateOutlet, HelpComponent, PeerTubeTemplateDirective ]
+  imports: [ FormsModule, NgIf, NgTemplateOutlet, HelpComponent ]
 })
 export class PeertubeCheckboxComponent implements ControlValueAccessor, AfterContentInit {
   readonly checked = model(false)

client/src/app/shared/shared-forms/select/select-checkbox-default-all.component.ts

@@ -18,6 +18,7 @@ import { SelectCheckboxComponent } from './select-checkbox.component'
     [selectedItemsLabel]="selectedItemsLabel"
 
     showClear="false"
+    showToggleAll="true"
 
     [virtualScroll]="virtualScroll()"
 

client/src/app/shared/shared-forms/select/select-checkbox.component.html

@@ -8,13 +8,11 @@
   [placeholder]="placeholder()"
 
   [showClear]="showClear()"
-  [showHeader]="showHeader()"
   [showToggleAll]="showToggleAll()"
 
   optionValue="id"
 
   [selectedItemsLabel]="selectedItemsLabel()"
-  [selectionLimit]="selectionLimit()"
 
   [virtualScroll]="virtualScroll()"
   [virtualScrollItemSize]="virtualScrollItemSize()"

client/src/app/shared/shared-forms/select/select-checkbox.component.ts

@@ -26,15 +26,12 @@ export class SelectCheckboxComponent implements ControlValueAccessor {
   readonly selectableGroupAsModel = input<boolean>(undefined)
   readonly placeholder = input<string>(undefined)
 
-  readonly selectionLimit = input<number>(undefined)
-
   readonly selectedItemsLabel = input<string>(undefined)
 
   readonly virtualScroll = input(false, { transform: booleanAttribute })
   readonly virtualScrollItemSize = input(33, { transform: numberAttribute })
 
   readonly showClear = input<boolean, unknown>(undefined, { transform: booleanAttribute })
-  readonly showHeader = input<boolean, unknown>(undefined, { transform: booleanAttribute })
   readonly showToggleAll = input<boolean, unknown>(undefined, { transform: booleanAttribute })
 
   readonly panelHide = output()

client/src/app/shared/shared-instance/instance-features-table.component.ts

@@ -6,7 +6,6 @@ import { ServerConfig, ServerStats } from '@peertube/peertube-models'
 import { of } from 'rxjs'
 import { HelpComponent } from '../shared-main/buttons/help.component'
 import { BytesPipe } from '../shared-main/common/bytes.pipe'
-import { PeerTubeTemplateDirective } from '../shared-main/common/peertube-template.directive'
 import { DaysDurationFormatterPipe } from '../shared-main/date/days-duration-formatter.pipe'
 import { FeatureBooleanComponent } from './feature-boolean.component'
 
@@ -14,7 +13,7 @@ import { FeatureBooleanComponent } from './feature-boolean.component'
   selector: 'my-instance-features-table',
   templateUrl: './instance-features-table.component.html',
   styleUrls: [ './instance-features-table.component.scss' ],
-  imports: [ NgIf, FeatureBooleanComponent, HelpComponent, PeerTubeTemplateDirective, NgFor, BytesPipe ]
+  imports: [ NgIf, FeatureBooleanComponent, HelpComponent, NgFor, BytesPipe ]
 })
 export class InstanceFeaturesTableComponent implements OnInit {
   private serverService = inject(ServerService)

client/src/app/shared/shared-user-settings/user-video-settings.component.ts

@@ -1,18 +1,16 @@
-import { pick } from 'lodash-es'
+import { NgIf } from '@angular/common'
-import { Subject, Subscription } from 'rxjs'
-import { first } from 'rxjs/operators'
 import { Component, OnDestroy, OnInit, inject, input } from '@angular/core'
+import { FormsModule, ReactiveFormsModule } from '@angular/forms'
 import { AuthService, Notifier, ServerService, User, UserService } from '@app/core'
 import { FormReactive } from '@app/shared/shared-forms/form-reactive'
 import { FormReactiveService } from '@app/shared/shared-forms/form-reactive.service'
 import { NSFWPolicyType, UserUpdateMe } from '@peertube/peertube-models'
-import { NgIf } from '@angular/common'
+import { pick } from 'lodash-es'
-
+import { Subject, Subscription } from 'rxjs'
+import { first } from 'rxjs/operators'
 import { PeertubeCheckboxComponent } from '../shared-forms/peertube-checkbox.component'
 import { SelectLanguagesComponent } from '../shared-forms/select/select-languages.component'
-import { PeerTubeTemplateDirective } from '../shared-main/common/peertube-template.directive'
 import { HelpComponent } from '../shared-main/buttons/help.component'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
 
 @Component({
   selector: 'my-user-video-settings',
@@ -22,7 +20,6 @@ import { FormsModule, ReactiveFormsModule } from '@angular/forms'
     FormsModule,
     ReactiveFormsModule,
     HelpComponent,
-    PeerTubeTemplateDirective,
     SelectLanguagesComponent,
     PeertubeCheckboxComponent,
     NgIf

client/src/app/shared/shared-user-subscription/remote-subscribe.component.ts

@@ -1,19 +1,18 @@
+import { NgIf } from '@angular/common'
 import { Component, OnInit, inject, input } from '@angular/core'
+import { FormsModule, ReactiveFormsModule } from '@angular/forms'
 import { Notifier } from '@app/core'
 import { FormReactive } from '@app/shared/shared-forms/form-reactive'
 import { FormReactiveService } from '@app/shared/shared-forms/form-reactive.service'
 import { logger } from '@root-helpers/logger'
-import { USER_HANDLE_VALIDATOR } from '../form-validators/user-validators'
-import { PeerTubeTemplateDirective } from '../shared-main/common/peertube-template.directive'
-import { HelpComponent } from '../shared-main/buttons/help.component'
-import { NgIf } from '@angular/common'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
 import { isIOS } from '@root-helpers/web-browser'
+import { USER_HANDLE_VALIDATOR } from '../form-validators/user-validators'
+import { HelpComponent } from '../shared-main/buttons/help.component'
 
 @Component({
   selector: 'my-remote-subscribe',
   templateUrl: './remote-subscribe.component.html',
-  imports: [ FormsModule, ReactiveFormsModule, NgIf, HelpComponent, PeerTubeTemplateDirective ]
+  imports: [ FormsModule, ReactiveFormsModule, NgIf, HelpComponent ]
 })
 export class RemoteSubscribeComponent extends FormReactive implements OnInit {
   protected formReactiveService = inject(FormReactiveService)