yetangitu/PrivateBin
1
0
Fork 0
mirror of https://github.com/PrivateBin/PrivateBin.git synced 2025-10-03 01:39:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

enable tests to pass

Browse source 
The path is only optional when it is / and the very last element, otherwise it is required. As soon as it is in the middle of a URL it helps the parser to identify which part is the username and domain and what is path and GET parameters. The @ sign is legitimate, if unusual, in the latter two.
This commit is contained in:
El RIDO 2025-09-03 20:13:33 +02:00
parent a6034ace1b
commit bd61a3d021
No known key found for this signature in database
GPG key ID: 0F5C940A6BD81F92
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tst/YourlsProxyTest.php
View file

@ -45,6 +45,10 @@ class YourlsProxyTest extends TestCase
$yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
$this->assertFalse($yourls->isError());
$this->assertEquals($yourls->getUrl(), 'https://example.com/1');
$yourls = new YourlsProxy($this->_conf, 'https://example.com/?@foreign.malicious.example?foo#bar');
$this->assertFalse($yourls->isError());
$this->assertEquals($yourls->getUrl(), 'https://example.com/1');
}
/**
@ -67,7 +71,7 @@ class YourlsProxyTest extends TestCase
array('https://example.com'), // missing path and query parameter,
array('https://example.com/'), // missing query parameter
array('https://example.com?paste=something'), // missing path parameter
array('https://example.com@foreign.malicious.example?foo#bar'), // shall belong to providerForeignUrlUsernameTrick, but for some reason PHP considers this an invalid URL
array('https://example.com@foreign.malicious.example?foo#bar'), // missing path parameter
);
}
@ -87,9 +91,8 @@ class YourlsProxyTest extends TestCase
public function providerForeignUrlUsernameTrick(): array
{
return array(
// array('https://example.com@foreign.malicious.example?foo#bar'),
array('https://example.com@foreign.malicious.example/?foo#bar'),
array('https://example.com/@foreign.malicious.example?foo#bar'),
array('https://example.com/?@foreign.malicious.example?foo#bar'),
);
}