yetangitu/airsonic
1
0
Fork 0
mirror of https://github.com/airsonic/airsonic.git synced 2025-10-04 10:19:27 +02:00
Code Issues Releases Wiki Activity

Catch Exceptions instead of only Throwables in JAudiotaggerParser

Browse source 
Since JAudioTagger isn't the rock-solidest software
in the world, we should catch as much things as possible
This commit is contained in:
jvoisin 2020-02-02 18:25:11 +01:00
parent a13552b6f5
commit c6eed14db5
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
airsonic-main/src/main/java/org/airsonic/player/service/metadata/JaudiotaggerParser.java
View file

@ -86,7 +86,7 @@ public class JaudiotaggerParser extends MetaDataParser {
AudioFile audioFile; AudioFile audioFile;
try { try {
audioFile = AudioFileIO.read(file); audioFile = AudioFileIO.read(file);
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Error when parsing tags in " + file, x); LOG.warn("Error when parsing tags in " + file, x);
return metaData; return metaData;
} }
@ -229,7 +229,7 @@ public class JaudiotaggerParser extends MetaDataParser {
audioFile.commit(); audioFile.commit();
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Failed to update tags for file " + file, x); LOG.warn("Failed to update tags for file " + file, x);
throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x); throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x);
} }