removed images that were not being used, added icons and started the iconification!

admin/users.php

@@ -1,8 +1,7 @@
 <?php
-
 /*
 
- Copyright (c) 2001 - 2005 Ampache.org
+ Copyright (c) 2001 - 2006 Ampache.org
  All rights reserved.
 
  This program is free software; you can redistribute it and/or
@@ -29,7 +28,7 @@
 
 require_once ('../lib/init.php');
 
-if (!$user->has_access(100)) { 
+if (!$GLOBALS['user']->has_access(100)) { 
 	access_denied();
 }
 
@@ -43,17 +42,16 @@ $user_id = scrub_in($_REQUEST['user']);
 $temp_user = new User($user_id);
  
 switch ($action) {
-    case 'edit':
-        if (conf('demo_mode')) { break; }
-	show_user_form($temp_user->username, 
-		$temp_user->fullname,
-		$temp_user->email,
-		$temp_user->access,
-		'edit_user',
-		'');
+	case 'edit':
+        	if (conf('demo_mode')) { break; }
+		$username	= $temp_user->username;
+		$fullname	= $temp_user->fullname;
+		$email		= $temp_user->email;
+		$access		= $temp_user->access;
+		$id		= $temp_user->id;
+		require_once(conf('prefix') . '/templates/show_edit_user.inc.php');
 	break;
-
-    case 'update_user':
+	case 'update_user':
 	        if (conf('demo_mode')) { break; }
 
 		/* Clean up the variables */
@@ -162,20 +160,19 @@ switch ($action) {
 	show_user_form('','','','','new_user','');
 	break;
 
-    case 'update':
-    case 'disabled':
-        if (conf('demo_mode')) { break; }
-	$level = scrub_in($_REQUEST['level']);
-	$thisuser = new User($_REQUEST['user']);
-	if ($GLOBALS['user']->has_access(100)) { 
-		$thisuser->update_access($level);
-	} 
-	show_manage_users();
+	case 'update':
+	case 'disabled':
+	        if (conf('demo_mode')) { break; }
+		$level = scrub_in($_REQUEST['level']);
+		$thisuser = new User($_REQUEST['user']);
+		if ($GLOBALS['user']->has_access(100)) { 
+			$thisuser->update_access($level);
+		} 
+		show_manage_users();
+	break;
+	default:
+		show_manage_users();
 	break;
-
-    default:
-	show_manage_users();
-
 }
 
 /* Show the footer */

lib/ui.lib.php

@@ -1312,4 +1312,27 @@ function show_box_bottom() {
 
 } // show_box_bottom
 
+/**
+ * get_user_icon
+ * this function takes a name and a returns either a text representation
+ * or an <img /> tag 
+ */
+function get_user_icon($name) { 
+
+	$icon_name = 'icon_' . $name . '.gif';
+
+	if (file_exists(conf('prefix') . '/themes/' . $GLOBALS['theme']['path'] . '/images/' . $icon_name)) { 
+		$img_url = conf('web_path') . conf('theme_path') . '/images/' . $icon_name;
+	}
+	else { 
+		$img_url = conf('web_path') . '/images/' . $icon_name; 
+	}
+
+	$string = "<img src=\"$img_url\" border=\"0\" alt=\"$name\" title=\"$name\" />";
+
+	return $string;
+
+} // show_icon
+
+
 ?>

modules/admin.php

@@ -51,17 +51,6 @@ function show_manage_users () {
 } // show_manage_users()
 
 
-/*!
-	@function show_user_form
-	@discussion shows the user form
-*/
-function show_user_form ($username, $fullname, $email, $access, $type, $error) {
-
-	require(conf('prefix').'/templates/userform.inc');
-    
-} // show_user_form()
-
-
 /*
  * show_change_password
  *

templates/show_edit_user.inc.php

@@ -21,23 +21,23 @@
 */
 
 if ($type === 'new_user') { 
-	$userfield = "<input type=\"text\" name=\"new_username\" size=\"30\" value=\"$username\" />";
-	$title = _("Adding a New User");
+	$userfield = "<input type=\"text\" name=\"new_username\" size=\"30\" value=\"" . scrub_out($username) . "\" />";
+	$title = _('Adding a New User');
 }
 else {
-	$userfield = $username;
-	$title = _("Editing existing User");
+	$userfield = scrub_out($username);
+	$title = _('Editing existing User');
 }
 ?>
 
 <br />
-<div class="header2"><?php echo $title; ?></div>
+<?php show_box_top($title); ?>
 <?php $GLOBALS['error']->print_error('general'); ?>
 <form name="update_user" method="post" action="<?php echo conf('web_path') . "/admin/users.php"; ?>">
-<table class="text-box" cellspacing="0" cellpadding="0" border="0">
+<table cellspacing="0" cellpadding="0" border="0">
 <tr>
 	<td>
-		<?php echo  _("Username"); ; ?>:
+		<?php echo  _('Username'); ?>:
 	</td>
 	<td>
 		<?php echo $userfield; ?>
@@ -45,22 +45,22 @@ else {
 	</td>
 </tr>
 <tr>
-	<td><?php echo  _("Full Name"); ; ?>:</td>
+	<td><?php echo  _('Full Name'); ?>:</td>
 	<td>
-		<input type="text" name="new_fullname" size="30" value="<?php echo $fullname; ?>" />
+		<input type="text" name="new_fullname" size="30" value="<?php echo scrub_out($fullname); ?>" />
 	</td>
 </tr>
 <tr>
 	<td>
-		<?php echo  _("E-mail"); ?>:
+		<?php echo  _('E-mail'); ?>:
 	</td>
 	<td>
-		<input type="text" name="new_email" size="30" value="<?php echo $email; ?>" />
+		<input type="text" name="new_email" size="30" value="<?php echo scrub_out($email); ?>" />
 	</td>
 </tr>
 <tr>
 	<td>
-		<?php echo  _("Password"); ?> :
+		<?php echo  _('Password'); ?> :
 	</td>
 	<td>
 		<input type="password" name="new_password_1" size="30" value="" />
@@ -69,7 +69,7 @@ else {
 </tr>
 <tr>
 	<td>
-		<?php echo  _("Confirm Password"); ?>:
+		<?php echo  _('Confirm Password'); ?>:
 	</td>
 	<td>
 		<input type="password" name="new_password_2" size="30" value="" />
@@ -77,7 +77,7 @@ else {
 </tr>
 <tr>
 	<td>
-		<?php echo  _("User Access Level"); ; ?>:
+		<?php echo  _('User Access Level'); ?>:
 	</td>
 	<td>
 		<select name="user_access">
@@ -91,12 +91,13 @@ else {
 <?php
 if ($type == 'new_user') {
 	echo "<input type=\"hidden\" name=\"action\" value=\"add_user\" />";
-	echo "<input type=\"submit\" value=\"" . _("Add User") . "\" />";
+	echo "<input type=\"submit\" value=\"" . _('Add User') . "\" />";
 }
 else {
 	echo "<input type=\"hidden\" name=\"action\" value=\"update_user\" />\n";
-	echo "<input type=\"submit\" value=\"" . _("Update User") . "\" />\n";
-	echo "<input type=\"hidden\" name=\"new_username\" value=\"$username\" />";
+	echo "<input type=\"submit\" value=\"" . _('Update User') . "\" />\n";
+	echo "<input type=\"hidden\" name=\"new_username\" value=\"$id\" />";
 }
 ?>
 </form>
+<?php show_box_bottom(); ?>

templates/show_users.inc

@@ -54,7 +54,8 @@ $admin_menu = "admin/";
 		<b><?php echo _("Registration Date"); ?></b>
 		</a>
 	</td>
-
+	<td colspan="5">&nbsp;</td>
+	<!--
         <td align="center">
 		<b><?php echo _("Edit"); ?></b>
 	</td>
@@ -70,6 +71,7 @@ $admin_menu = "admin/";
 	<td align="center">
 		<b><?php echo _("Delete"); ?></b>
 	</td>
+	-->
         <td align="center">
 		<b><?php echo _("On-line"); ?></b>
 	</td>
@@ -83,46 +85,46 @@ while ($results = mysql_fetch_object($db_result)) {
         if (!$user->create_date) { $create_date = "Unknown"; }
 ?>
 
-<tr class="<?php echo flip_class(); ?>">
-	<td>
-		<a href="<?php echo $web_path; ?>/admin/users.php?action=edit&amp;user=<?php echo $user->username; ?>">
+<tr class="<?php echo flip_class(); ?>" align="center">
+	<td align="left">
+		<a href="<?php echo $web_path; ?>/admin/users.php?action=edit&amp;user=<?php echo $user->id; ?>">
 			<?php echo $user->fullname; ?> (<?php echo $user->username; ?>)
 		</a>
 	</td>
-        <td align="center">
+        <td>
 		<?php echo $last_seen; ?>
 	</td>
-        <td align="center">
+        <td>
 		<?php echo $create_date; ?>
 	</td>
 
         <td>
 		<a href="<?php echo $web_path; ?>/admin/users.php?action=edit&amp;user=<?php echo $user->username; ?>">
-			<?php echo _("Edit"); ?>
+			<?php echo get_user_icon('edit'); ?>
 		</a>
 	</td>
         <td>
 		<a href="<?php echo $web_path; ?>/admin/preferences.php?action=user&amp;user_id=<?php echo $user->username; ?>">
-			<?php echo _("Prefs"); ?>
+			<?php echo get_user_icon('preferences'); ?>
 		</a>
 	</td>
 	<td>
 		<a href="<?php echo $web_path; ?>/stats.php?user_id=<?php echo $user->username; ?>">
-			<?php echo _("Stats"); ?>
+			<?php echo get_user_icon('statistics'); ?>
 		</a>
 	</td>
 	<?php
 	//FIXME: Fix this for the extra permission levels
 	if ($user->disabled == '1') { 
-		echo "<td><a href=\"".$web_path."/admin/users.php?action=update&amp;user=$user->username&amp;level=enabled\">" . _("Enable") . "</a></td>";
+		echo "<td><a href=\"".$web_path."/admin/users.php?action=update&amp;user=$user->username&amp;level=enabled\">" . get_user_icon('enable') . "</a></td>";
 	}
 	else {
-		echo "<td><a href=\"".$web_path."/admin/users.php?action=update&amp;user=$user->username&amp;level=disabled\">" . _("Disable") ."</a></td>";
+		echo "<td><a href=\"".$web_path."/admin/users.php?action=update&amp;user=$user->username&amp;level=disabled\">" . get_user_icon('disable') ."</a></td>";
 	}
 	?>
 	<td>
 		<a href="<?php echo $web_path; ?>/admin/users.php?action=delete&amp;user=<?php echo $user->username; ?>">
-		<?php echo _("delete"); ?>
+		<?php echo get_user_icon('delete'); ?>
 		</a>
 	</td>
        <?php