Fix coding guidelines incoherences. Code should match PSR1/2 now, and
php-cs is set to check it on each commit.
Also fixed the Git hook to take into account only added, modified,
copied and renamed files (preventing errors when trying to check deleted
files).
Closes#1260.
Wrong gettext function calls
There were some issues when gettext is not installed on the system, due
to direct function calls to gettext and not to the encapsulated ones.
Closes#1211.
It's always better to keep those variable user-, plugin-, etc-names as
dynamic as possible. Otherwise it's sometimes extremely problematic to
find the right sentence-formatting. In German I would translate it that
way:
"Klicke um `$plugin_name` den Zugriff zu erlauben"
And does this English sentence in the source fit better? As I see from
the context, the user is asked to give `$plugin_name`the right to access
Ampache, is this right?
:-)
config/ampache.cfg.php.dist
+ updated version because the changes depend on database and base code
changes
+ renamed variable `%SAMPLE%` -> `%BITRATE%`
lib/class/stream.class.php
+ changed `AmpConfig::get('sample_rate');` ->
`AmpConfig::get('transcode_bitrate');` due to db changes
+ renamed variable `%SAMPLE%` -> `%BITRATE`
+ renamed variable `$sample_rate` -> `$bit_rate`
+ renamed variable `$user_sample_rate` -> `$user_bit_rate`
lib/class/update.class.php
+ New update function to change preference name `sample_rate` ->
`transcode_bitrate`
lib/init.php
+ changed config file version for config autoupdate
lib/preference.php
+ changed case `sample_rate` -> `transcode_bitrate` due to db changes
Upgrade the scrobbler class, Lastfm and Librefm plugins to use the new API.
Authentication is changed:
-admin needs to create a last.fm API account, set their API key and secret in the ampache.cfg file,
-users need to grant Ampache application to last.fm / Libre.fm services by using preference tab > plugins.
Resolvesampache/ampache#922
Add the "spread the love" function to share your favorites on Last.fm and Libre.fm.
Change-Id: Ia81334f4f4506258a27d40b6c257a1e38bd69097
Signed-off-by: nioc <nioc@users.noreply.github.com>
