Paul Arthur
744e6bb994
Make remote catalogs actually work
2013-03-28 16:56:21 -04:00
Paul Arthur
eee48871e9
Try to be more robust in Dba
2013-03-28 16:56:21 -04:00
Paul Arthur
b3e78cc4b7
Remove sole use of Dba::seek
...
Can't be cleanly supported by PDO, so it was removed from Dba's
interface. This change was supposed to be done then, but was missed.
2013-02-11 17:33:24 -05:00
Paul Arthur
05498397f3
Dba: return false on errors
...
I'm pretty sure this is the correct thing to do.
2013-02-11 17:24:17 -05:00
Paul Arthur
f29e416e04
Fix setting ACLs
...
_verify_range should be static.
2013-02-11 17:23:35 -05:00
Paul Arthur
5bc48fd3b2
Fix xml.server.php after changes to session
...
It was calling the wrong method in Session, which is entirely my fault.
Also, the correct method was broken. Gah.
2013-02-11 17:23:33 -05:00
Paul Arthur
3a8feaeeff
FS#272 - Adding songs to democratic playlist
...
This is more likely to fix democratic handling. Untested.
2013-02-07 22:42:44 -05:00
Paul Arthur
453a161a78
Scrub user data in User->update()
...
Fixes another persistent XSS vulnerability.
2013-02-07 16:36:44 -05:00
Paul Arthur
79b6eb98e7
Fix scrub_in to be safer
2013-02-07 15:17:24 -05:00
Paul Arthur
46cb6c81c5
FS#272 - Adding songs to democratic playlist
...
This might fix democratic handling. Untested.
2013-02-07 14:35:03 -05:00
Paul Arthur
239ea81fdf
Some cleanup of play URL handling
...
Move parsing from Song into Stream_URL and make it parse more things.
Add the type parameter to all generated URLs instead of adding video to
Video URLs.
2013-02-07 14:24:40 -05:00
Paul Arthur
31afde9fc0
Drop Dba::escape in vainfo
2013-02-05 11:48:31 -05:00
Paul Arthur
0905271377
Clean up vainfo somewhat
...
Handling of unknown tags was wrong (we should just pass them through and
hope for the best, not do some weird-ass id3v2 thing). Add matroska to
the list of known tags. Switch the video types to a generic cleanup
function and move the several-times-duplicated general information
gathering into the general information gathering function where it
belongs. Treat the general information as another tag type instead of
special-casing it as a complete override through array_merge. Drop the
useless iconv stuff (getID3 already translates tags to our requested
charset). Rename some functions to more closely match their purpose.
Fix some private functions that were marked public. Fix encoding
detection, which has been completely broken for a while.
2013-02-05 11:42:56 -05:00
Paul Arthur
02286a12b8
Add fallback title to filename metadata source
...
If we didn't parse anything out, set it to the filename.
2013-02-05 01:41:39 -05:00
Paul Arthur
860b7d3ed3
Parameterise query in Api
2013-02-04 17:56:11 -05:00
Paul Arthur
287ddc4345
Dba: fix more things
...
Check that things are things before thing.
2013-02-03 04:03:35 -05:00
Paul Arthur
ab18569013
UI: Fix $hover_name 'Undefined variable' warnings
2013-02-02 20:51:26 -05:00
Paul Arthur
544aae5431
Fix Dba::quote()
...
It's still ugly, but it won't get too greedy.
2013-02-02 18:56:14 -05:00
Paul Arthur
4cbb5db6df
Make Dba::query() a bit more correct
...
Check the DB handle and the statement handle before we try to use them.
2013-02-02 18:53:02 -05:00
Paul Arthur
4acffa613d
Add $target back
...
No being lazy for us. interfaces are interfaces, not abstract classes.
2013-01-31 16:00:03 -05:00
Paul Arthur
0cf02f8590
Remove $target from media->get_transcode_settings()
2013-01-31 15:55:27 -05:00
Paul Arthur
205ce073b5
Fix the session type exception for use_auth=false
...
The table definition changed slightly and the old workaround didn't
work. If auth is disabled, we really don't care that much, so just drop
the attempt to constrain type in that case.
2013-01-31 15:37:19 -05:00
Paul Arthur
0b0f4d1634
Fix Random class
...
I blame the ghosts.
2013-01-31 15:19:47 -05:00
Paul Arthur
a553204083
Actually fix Random
...
Test first, then push would be better, but I'm not that smart.
2013-01-31 15:04:41 -05:00
Paul Arthur
923aa7f3e8
Fix Random class
...
Random extends media, but the new abstract methods from the transcoding
rework hadn't been defined yet. Reported by deselby.
2013-01-31 14:58:15 -05:00
Paul Arthur
7c43b63109
Ignore errors from json_encode in Dba debugging
2013-01-29 14:26:37 -05:00
Paul Arthur
f03122d6fc
Clean up Config
2013-01-29 14:24:30 -05:00
Paul Arthur
0e10923ff8
Clean up Auth; use parameterised query.
2013-01-29 14:20:40 -05:00
Paul Arthur
dbe7d5695d
Rename Ampache_Mail to Mailer
2013-01-29 14:10:26 -05:00
Paul Arthur
4d11733622
Parameterise query in Ampache_Mail
2013-01-29 14:08:36 -05:00
Paul Arthur
963efd7afc
Clean up Access; use parameterised queries
2013-01-29 12:30:31 -05:00
Paul Arthur
04347b9a59
Move UTF-8 cleanup into its own method
2013-01-29 11:33:32 -05:00
Paul Arthur
252abb8bea
Use parameterised queries in Stream
2013-01-29 11:14:55 -05:00
Paul Arthur
253f2e621a
Use parameterised queries in Stream_Playlist
2013-01-29 10:48:44 -05:00
Paul Arthur
54ccd127d7
Use Horde_Browser for browser detection in Session
...
That's one of the reasons we have it, after all.
2013-01-29 10:42:33 -05:00
Paul Arthur
4c03d447a5
Use parameterised queries in Session
2013-01-29 10:42:33 -05:00
Paul Arthur
b7c9678012
Switch Dba from mysql to PDO-MySQL
...
The mysql extension is deprecated in PHP 5.5 and will be removed in the
future.
2013-01-29 03:08:52 -05:00
Paul Arthur
3010ae8c85
Log stderr when we transcode
...
Now you shouldn't need to manually run the command to see what went
wrong.
2013-01-28 22:00:08 -05:00
Paul Arthur
75b2af2464
Fix flip_class
2013-01-28 21:48:17 -05:00
Paul Arthur
0d569db17b
Fix incorrect updates
...
Starting with a fresh 3.3.3.5 import these updates failed. Kick them to
the curb.
2013-01-28 21:48:10 -05:00
Paul Arthur
1b4fe6a2b1
Drop unnecessary updates
...
We only claim to support updates from 3.3.3.5, and that tarball has
340002.
2013-01-28 21:46:00 -05:00
Paul Arthur
101f4a047a
Cosmetics: s/Itterate/Iterate/
2013-01-28 21:46:00 -05:00
Paul Arthur
a80c969202
Clean up updates
...
Drop useless updates that created or modified tables which were later
dropped.
2013-01-28 21:46:00 -05:00
Paul Arthur
8b061518cb
Make the update process potentially sane
...
Make sure our writes succeed before declaring the update a success and
updating the DB version.
2013-01-28 21:46:00 -05:00
Paul Arthur
fbbb015950
Use Session for stream sessions
2013-01-28 21:46:00 -05:00
Paul Arthur
0451840fa3
Add 'external' auth method
...
Based on merge request #11
2013-01-28 21:23:15 -05:00
Paul Arthur
ad4ba9ff9a
Drop stale references to 'xml-rpc'
2013-01-28 21:23:15 -05:00
Paul Arthur
a6b70f9eba
Rename the 'local' auth method to 'pam'
...
It's what it should have been from the start.
2013-01-28 21:23:14 -05:00
Paul Arthur
ead4cf2a0e
Rename vauth to Auth
2013-01-28 21:23:05 -05:00
Paul Arthur
58a3ab692e
Move sessiony things from vauth into Session
2013-01-28 16:57:34 -05:00