yetangitu/ampache
1
0
Fork 0
mirror of https://github.com/Yetangitu/ampache synced 2025-10-05 02:39:47 +02:00
Code Issues Releases Wiki Activity
2812 commits 4 branches 18 tags 116 MiB
Commit graph

1295 commits

Author SHA1 Message Date
Paul Arthur
25b77a6c75 Partial fix for ASF tags 
Actually transfer all ASF tags into the asf tag array.  I suspect that
some things like 'genre' may actually be multivalued, but I don't have
any samples to back that up.
 2012-09-06 12:56:20 -04:00
Paul Arthur
33d07e8910 Make a debug message less alarming 
It's expected that reading from sessions will fail after expiry or
before login.  Remove the word 'error' from the logged message and bump
it down a few levels.
 2012-07-24 16:46:21 -04:00
Paul Arthur
408e71344a escapeshellarg's behaviour is locale-dependent 
Reimplement it locally so it isn't.  Might fix FS#252.
 2012-05-25 16:52:57 -04:00
Paul Arthur
5f2f81fa8f Use spl_autoload_register instead of __autoload 
Might be useful in the future, __autoload is discouraged according to
the PHP documentation.
 2012-04-18 00:54:54 -04:00
Paul Arthur
8a93c849e2 FS#226 - does not catch MySQL errors before passing to num_rows() 
Clean up Dba::num_rows (based on a patch by Natureshadow)

We could check before every call instead, but screw that.
 2012-04-15 23:32:03 -04:00
Paul Arthur
4aa37feccc Fix disk number parsing for ID3v2 
According to the changelog, getID3 1.7.9 standardised on part_of_a_set
as the key for this info (pulled from TPOS or TPA, depending on the
minor version of ID3v2); we were looking for 'pos', which is wrong.
 2012-04-15 03:02:29 -04:00
Paul Arthur
512f77a70c Support setting a custom format for the rss feed 2012-04-13 17:59:16 -04:00
Paul Arthur
8af2544b27 Refactor getting MBIDs from ID3 tags 
Just grab the info from the TXXX bit, instead of relying on a
correlation between the raw tags and the cooked ones.
 2012-04-12 21:56:27 -04:00
Paul Arthur
ecdb8bc02d Add support for pulling ratings from id3 tags 
Not used by anything yet, but it might work.
 2012-04-12 21:42:44 -04:00
Paul Arthur
774e53db7d Switch from ngettext() to T_ngettext() 2012-04-12 21:13:29 -04:00
Paul Arthur
f65076b93d Switch from _() to T_() 
Even if we move away from php-gettext in the future, it's easy to
write a quick T_() as a simple wrapper; it's not so easy to rewrite
PHP to allow redeclaration of a function.
 2012-04-12 21:13:29 -04:00
Paul Arthur
1c2de30150 Add support for parsing MBIDs in M4A files 2012-04-11 19:13:32 -04:00
Paul Arthur
91603e9800 Don't throw away data that getID3 has deigned to parse 
Fixes M4A tag parsing, probably other things.
 2012-04-11 18:17:54 -04:00
Brian Hasselbeck
2888851fa3 FS#224 - generated .pls playlist doesn't work in some players 
Initial tag is case sensitive; we were emitting [Playlist] but some
players don't accept that. There is unfortunately no real standard to
check, but this does match what Winamp (ack, pthbbt) does.
 2012-04-11 16:52:16 -04:00
Paul Arthur
ec9389f5c6 Make Art->get_from_source() static 
Half the calls to it were already trying to call it as a static method
anyway.  The only time $this was referenced was to get the type, so pass
type as a parameter.
 2012-04-09 16:18:13 -04:00
Paul Arthur
2e2c0919cb Increment the correct variable during verify 
Final displayed count was always 0 because we were incrementing a
different variable than we were using.
 2012-03-31 22:34:37 -04:00
Paul Arthur
ac81e2b0e3 Drop mtime check during verify 
It does more harm than good, by making it difficult to update records if
you've changed your metadata settings (or fixed a bug).
 2012-03-31 22:32:20 -04:00
Paul Arthur
f2e01ab7d5 Increase the size of the mbid column in artist 
Picard is putting multiple MBIDs in the tags now that MusicBrainz' new
schema is live.  The easiest way to deal with this is to store all of
them as an aggregate value and match against that.
 2012-03-31 22:29:09 -04:00
Paul Arthur
6f8673b5c7 Don't use LIKE when looking for an artist by MBID 
There's no reason to do pattern matching.
 2012-03-31 21:08:44 -04:00
Paul Arthur
425ecbbb3a Don't run filename patterns through preg_quote twice 
This would result in extra slashes, e.g.
    '/\/([0-9]+?)\s\\\-\s(.+?)\..+$/' instead of
    '/\/([0-9]+?)\s\-\s(.+?)\..+$/'

There are some unrelated cosmetic changes as well.
 2012-03-31 20:44:41 -04:00
Paul Arthur
ccb9edbf2d Clean up get_preferences a little bit 
Don't use userid as some sort of weird flag value. Especially when
your flag value is a valid value for userid. Just...no.
 2012-03-31 17:52:07 -04:00
Paul Arthur
f2e3668528 Fix regex for parsing rules 
ID can be multiple digits, so we should capture all of them.
 2012-03-19 12:21:22 -04:00
Paul Arthur
ca60de30bc Add CLI tool for running database updates 2012-03-06 16:42:04 -05:00
Paul Arthur
f40866b6d5 Use '$a ?: $b' instead of '$a ? $a : $b' in vainfo 
Now that we require PHP 5.3, we can use the more compact format.
 2012-03-06 12:55:17 -05:00
Paul Arthur
34b0eaf233 Clean up uses of Config::set and Config::set_by_array 
Consistently pass in a boolean instead of a string or an int for the
clobber flag.
 2012-03-06 12:18:57 -05:00
Paul Arthur
08a4f848be Clean up Config::set and Config::set_by_array 
Boolean parameters should be boolean.
 2012-03-06 12:18:10 -05:00
Paul Arthur
585382422c Allow multiple valid forms of the same type 
Use the SID for the primary key, instead of the non-unique form name.
Also add some debugging to the form functions in Core.
 2012-03-06 10:58:07 -05:00
Paul Arthur
3d8e3ac86c Minor clean up of vauth::session_extend 2012-03-02 00:08:57 -05:00
Paul Arthur
dd3d42d644 FS#198 - Export To CSV - Blank Genre 
Clean up Catalog->export.  Genre doesn't exist any more.
 2012-03-01 14:24:26 -05:00
Paul Arthur
40e8484a57 FS#213 - User Registration 
Add an option to have newly registered accounts disabled by default.
 2012-03-01 14:06:03 -05:00
Paul Arthur
55ed43c332 Clean up xmlData::songs 
Drop call to Song->format(); two of the values that we use are exposed
via public getters anyway, and it's not particularly ugly to call
Tag::get_top_tags instead of relying on Song to do that for us.

Remove genre cruft.

Based on a patch by lotan_rm in FS#215
 2012-03-01 13:36:41 -05:00
Paul Arthur
6b33ec9be8 Clean up xmlData::tags_string 
Drop unused parameters.  Make sure $tags is an array before we treat it
as one.  Correct count value.

Based on a patch by lotan_rm in FS#215
 2012-03-01 13:14:42 -05:00
Paul Arthur
bac2618846 Cosmetics: clean up SQL statement in Tag::get_top_tags 2012-03-01 13:03:36 -05:00
Paul Arthur
b5965d2513 Add Art cache to the caches built by Song::build_cache 2012-03-01 12:48:11 -05:00
lotan_rm
500b6cbdb3 Avoid unnecessary work in Song::play_url 
The only thing we're using that's set by format() is f_artist_full,
which is exactly the same as what's returned by get_artist_name().
 2012-03-01 12:45:20 -05:00
Paul Arthur
3bd110181c Add some caching to the Art class 
Based on a patch by lotan_rm in FS#215
 2012-03-01 12:39:55 -05:00
Paul Arthur
6f0c651075 FS#216 - Cannot add music to catalog with 21 February commit 
The wrong version of this change got pushed, somehow.  Fix parse errors.
 2012-02-21 19:19:19 -05:00
Paul Arthur
e9e350b71e Lengthen varchar for tmp_playlist.session 
Sessions can be longer than 32 characters.  Bump to 64.
 2012-02-21 00:08:20 -05:00
lotan_rm
073f49c3e8 FS#212 - Incorrect album art uri 
Missing ampersand.
 2012-02-20 23:38:48 -05:00
Paul Arthur
e36d29434e vainfo: unset disk if totaldiscs is 1 
ID3 should only set disk if it's part of a set, but the same is not true
of other metadata sources.

Also drop no-op attempted cleanup of disk; we've already run intval, so
it won't contain a slash.
 2012-02-20 23:11:48 -05:00
Paul Arthur
a40824a96b Drop unnecessary case branch. 2012-02-20 22:50:41 -05:00
momo-i
95620b40a1 Fixed messages translatable. 2011-12-27 15:30:25 +09:00
momo-i
9f491c064a Fixed messages translatable. 2011-12-27 15:15:06 +09:00
Karl Vollmer
0c779f36f7 Switched Ping date to ISO 8601, added expire to handshake also ISO 8601 2011-12-19 12:43:51 -04:00
Paul Arthur
0c90811df4 Fix catalog clean 2011-12-02 10:28:20 -05:00
Karl Vollmer
312052f235 Fix some missing documentation, remove some obsolete functions 2011-12-01 22:00:40 -04:00
Karl Vollmer
a350ae1dbc Fix Libre.FM scrobbling, remove errant data in handshake response 2011-12-01 21:47:24 -04:00
Karl Vollmer
56eb2ac7dc Fixed two PHP warnings, and some issues with how users were being constructed 
in init (which makes me wonder) and started trying to figure out why libre.fm broke
 2011-12-01 15:59:33 -04:00
Karl Vollmer
d1af05595c Typo caused songs to be put in null catalog :S 2011-12-01 15:15:32 -04:00
Karl Vollmer
96ea4a9655 Song and Album Art from remote catalogs now inserts locally, can't play the remote 
songs yet.
 2011-12-01 09:33:18 -04:00