Homogeneize `username` field length in SQL database.
Set the `VARCHAR` field used for `username` to have a maximum size of
255, which was the highest value used across the tables. This should fix
some errors with MySQL strict mode (and potentially unnoticed previous
errors).
Also edited the `fullname` field length to match the `username` field
length.
Closes#1214.
XML API version is now assumed to be the latest available if not
specified as a parameter. Also fix the issue that an empty XML document
was issued when the version was not specified.
Closes issue #1247.
* Fix php-cs according to https://github.com/ampache/ampache/issues/1251
to fix travis build. Use composer to force the 1.* version to be used.
* Add `encoding` fixer.
* Use the same set of fixers in Git commit hook and test script.
* Update hooks and scripts.
* Fix a braces issue detected by php-cs.
Closes issue #1251.
This commit introduces a `nT_` function to handle pluralization in
localizations, and avoid the need to call ngettext, which was resulting
in errors if PHP Gettext module was not available (and this was not
enforced by Ampache).
Any occurrence of `ngettext` has been replaced by this `nT_` call.
Also removed the useless keywords in the `gather-messages.sh` script,
and added the newly introduced `nT_` keyword.
Closes issue #123.
Image size checking did not handle empty values (e.g. max height/width was not set in config).
As result, any image would be "not in range" even when the user would expect that it would.
To get better information while debugging the error message has also be expanded to include
the configured/assumed min/max value and the current height/width which was checked.
Second fix in this commit addresses broken google image search.
Google has changed the image search page some time ago. This causes the old code to get an error 404
when trying to retrive images.
In addition to the broken URL, the way to parse the HTML result was also broken.
Google now sends some sort of JSON and HTML mix string.
Currently some simple regex will try to find all image urls, maybe someone will find a better solution.
add support for 'state' and 'city' in external auths
add support for an 'auto_update' of the users date from external auths
add support for 'state' and 'city' in LDAP
Since ever, I hated it that the Update notification is within the
headerbox. Now it's on the top of the content div like the "updated
config" notification.
I also kicked out one permission check so the
"autoupdate" notification and/or the "new config" notification is only
shown if the permission is 100... Like before but in another way.
^^
Before, there was a `<span>...</span>`, no matter what user was
logged in. Now there is a div with `id="update_notify"` what is also
only shown, if the admin is logged in.
I also cleaned the depending CSS
rule in `/reborn/templates/default.css`
Songs skip disabled songs so the handshake count should do the same
Also makes the counts for artists and albums not depend on included
song rows but on the number of rows in their own tables
Disabled songs was hidden after the limit parameter was applied causing
the returned number of songs to be less than limit even if there were
more songs. Also caused offset to be a bit weird, example:
> Request offset=0&limit=1000
< Get 995 songs as 5 of them was disabled
So the client must use offset=N*1000 for the next
requests regardless of the number of songs in the
response until zero are returned as we truly was at
the end
move it from Auth::ldap_auth to LDAP::auth
add support for other protocol versions
add support for StartTLS
add support for custom name field
=> if (givenName = John) and (sn = Doe), "givenName sn" gives "John Doe"
add support for custom attribute name for group's member attribute
clean code
