yetangitu/bitjs
1
0
Fork 0
mirror of https://github.com/codedread/bitjs synced 2025-10-03 09:39:16 +02:00
Code Issues Releases Wiki Activity

Add handling when codec_name is set but codec_tag_string is not parse-able

Browse source
This commit is contained in:
Jeff Schiller 2022-11-06 01:09:43 -07:00
parent 744162ec5b
commit 2a37f87242
3 changed files with 41 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/codecs.spec.js
View file

@ -125,7 +125,7 @@ describe('codecs test suite', () => {
})).to.throw();
});
describe('AVC1', () => {
describe('AVC1 / H264', () => {
/** @type {ProbeInfo} */
let info;
@ -201,6 +201,16 @@ describe('codecs test suite', () => {
.and.satisfy(s => s.endsWith('0A"'));
});
});
it('Handles codec_name=h264, but no codec_tag_string', () => {
info.streams[0].codec_name = 'h264';
info.streams[0].profile = 'Main';
info.streams[0].codec_tag_string = '[0][0][0][0]';
info.streams[0].level = 20;
expect(getFullMIMEString(info))
.to.be.a('string')
.and.satisfy(s => s.startsWith('video/mp4; codecs="avc1.4D00'));
});
});
});
@ -260,7 +270,7 @@ describe('codecs test suite', () => {
});
});
describe('AAC', () => {
describe('MP4A / AAC', () => {
/** @type {ProbeInfo} */
let info;
@ -286,5 +296,14 @@ describe('codecs test suite', () => {
.and.equals('audio/mp4; codecs="mp4a.40.2"');
});
});
it('handles codec_name=aac but no codec_tag_string', () => {
info.streams[0].profile = 'LC';
info.streams[0].codec_tag_string = '[0][0][0][0]';
info.streams[0].codec_name = 'aac';
expect(getFullMIMEString(info))
.to.be.a('string')
.and.equals('audio/mp4; codecs="mp4a.40.2"');
});
});
});