yetangitu/bitjs
1
0
Fork 0
mirror of https://github.com/codedread/bitjs synced 2025-10-05 18:34:17 +02:00
Code Issues Releases Wiki Activity

Fix bug where we are holding on to a reference to the WASM runtime HEAP, but the HEAP could become detached

Browse source
This commit is contained in:
codedread 2020-03-14 17:47:43 -07:00
parent c1f0b6bc2a
commit 9dc09e22f4
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
image/webp-shim/webp-shim.js
View file

@ -1,12 +1,5 @@
/**
* webp-shim.js
*
* Loads in the WASM module and exposes methods to convert a WebP image into
* alternative raster graphics formats (PNG/JPG).
*
* Licensed under the MIT License
*
* Copyright(c) 2020 Google Inc.
*
*/
const url = import.meta.url;
@ -37,7 +30,7 @@ function loadWebPShimApi() {
getPNGHandle: Module.cwrap('get_png_handle_from_webp', 'number', ['number', 'number']),
getImageBytesFromHandle: Module.cwrap('get_image_bytes_from_handle', 'number', ['number']),
getNumBytesFromHandle: Module.cwrap('get_num_bytes_from_handle', 'number', ['number']),
heap: Module.HEAPU8,
module: Module,
releaseImageHandle: Module.cwrap('release_image_handle', '', ['number']),
};
resolve(api);
@ -59,13 +52,13 @@ export function convertWebPtoPNG(webpBuffer) {
const webpArray = new Uint8Array(webpBuffer);
const size = webpArray.byteLength;
const webpWASMBuffer = api.createWASMBuffer(size);
api.heap.set(webpArray, webpWASMBuffer);
api.module.HEAPU8.set(webpArray, webpWASMBuffer);
// Convert to PNG.
const pngHandle = api.getPNGHandle(webpWASMBuffer, size);
const numBytes = api.getNumBytesFromHandle(pngHandle);
const pngBufPtr = api.getImageBytesFromHandle(pngHandle);
const pngBuffer = api.heap.slice(pngBufPtr, pngBufPtr + numBytes - 1);
let pngBuffer = api.module.HEAPU8.slice(pngBufPtr, pngBufPtr + numBytes - 1);
// Cleanup.
api.releaseImageHandle(pngHandle);