yetangitu/canvas-based-HTML5-Comic-Book-Reader
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

use arrow function syntax where possible

Browse source
This commit is contained in:
Bala Clark 2015-07-15 10:47:44 +02:00
parent 7772805c25
commit 7ccbdac37b
2 changed files with 23 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/comic-book.js
View file

@ -22,13 +22,11 @@ module.exports = class ComicBook extends EventEmitter {
} }
preload () { preload () {
this.emit('preload:start')
this.srcs.forEach(loadImage.bind(this))
}
}
function loadImage (src, pageIndex) {
let self = this let self = this
this.emit('preload:start')
this.srcs.forEach((src, pageIndex) => {
let image = new window.Image() let image = new window.Image()
image.src = src image.src = src
@ -42,5 +40,8 @@ function loadImage (src, pageIndex) {
self.emit('preload:finish') self.emit('preload:finish')
} }
} }
})
}
} }

8
test/comic-book.test.js
View file

@ -12,13 +12,13 @@ describe('ComicBook', function () {
describe('preload images', function () { describe('preload images', function () {
it('should preload all given image srcs and emit preload:image, preload:finish events', function (done) { it('should preload all given image srcs and emit preload:image, preload:finish events', done => {
let comic = new ComicBook(srcs) let comic = new ComicBook(srcs)
let loaded = [] let loaded = []
comic.on('preload:image', image => loaded.push(image.src)) comic.on('preload:image', image => loaded.push(image.src))
comic.on('preload:finish', function () { comic.on('preload:finish', () => {
assert.deepEqual(loaded, srcs, 'all requested images should have been loaded') assert.deepEqual(loaded, srcs, 'all requested images should have been loaded')
done() done()
}) })
@ -30,7 +30,7 @@ describe('ComicBook', function () {
it('should preload images in both directions') it('should preload images in both directions')
it('should emit a preload:start event', function (done) { it('should emit a preload:start event', done => {
let comic = new ComicBook(srcs) let comic = new ComicBook(srcs)
comic.on('preload:start', () => done()) comic.on('preload:start', () => done())
@ -42,7 +42,7 @@ describe('ComicBook', function () {
it('preload:ready should make sure that double page mode can show two images') it('preload:ready should make sure that double page mode can show two images')
it('should show the load indicator on preload:start', function (done) { it('should show the load indicator on preload:start', done => {
let comic = new ComicBook(srcs) let comic = new ComicBook(srcs)
assert.equal(comic.loadIndicator.el.style.display, 'none') assert.equal(comic.loadIndicator.el.style.display, 'none')
comic.loadIndicator.on('show', () => done()) comic.loadIndicator.on('show', () => done())