diff --git a/res/menu/conversation_context.xml b/res/menu/conversation_context.xml index 7316ef546..0b3c9ffbd 100644 --- a/res/menu/conversation_context.xml +++ b/res/menu/conversation_context.xml @@ -1,10 +1,5 @@ - - + app:showAsAction="never" /> diff --git a/src/org/thoughtcrime/securesms/ConversationFragment.java b/src/org/thoughtcrime/securesms/ConversationFragment.java index c93709fee..3287add0d 100644 --- a/src/org/thoughtcrime/securesms/ConversationFragment.java +++ b/src/org/thoughtcrime/securesms/ConversationFragment.java @@ -473,9 +473,6 @@ public class ConversationFragment extends Fragment getActivity().overridePendingTransition(R.anim.slide_from_right, R.anim.fade_scale_out); } - private void handleResendMessage(final DcMsg message) { - } - @SuppressLint("RestrictedApi") private void handleReplyMessage(final DcMsg message) { if (getActivity() != null) { @@ -784,6 +781,7 @@ public class ConversationFragment extends Fragment setCorrectMenuVisibility(menu); ConversationAdaptiveActionsToolbar.adjustMenuActions(menu, 10, requireActivity().getWindow().getDecorView().getMeasuredWidth()); actionMode.setTitle(String.valueOf(getListAdapter().getSelectedItems().size())); + actionMode.setTitleOptionalHint(false); // the title represents important information, also indicating implicitly, more items can be selected } } else if(messageRecord.isSetupMessage()) { @@ -928,10 +926,6 @@ public class ConversationFragment extends Fragment handleForwardMessage(getListAdapter().getSelectedItems()); actionMode.finish(); return true; - case R.id.menu_context_resend: - handleResendMessage(getSelectedMessageRecord()); - actionMode.finish(); - return true; case R.id.menu_context_save_attachment: handleSaveAttachment(getSelectedMessageRecord()); return true; diff --git a/src/org/thoughtcrime/securesms/util/views/ConversationAdaptiveActionsToolbar.java b/src/org/thoughtcrime/securesms/util/views/ConversationAdaptiveActionsToolbar.java index 40754b135..1f77e4b7d 100644 --- a/src/org/thoughtcrime/securesms/util/views/ConversationAdaptiveActionsToolbar.java +++ b/src/org/thoughtcrime/securesms/util/views/ConversationAdaptiveActionsToolbar.java @@ -19,6 +19,7 @@ import org.thoughtcrime.securesms.util.ViewUtil; public class ConversationAdaptiveActionsToolbar extends Toolbar { private static final int NAVIGATION_DP = 56; + private static final int TITLE_DP = 48; // estimated, only a number (if >1 items are selected there is more room anyway as there are fewer options) private static final int ACTION_VIEW_WIDTH_DP = 48; private static final int OVERFLOW_VIEW_WIDTH_DP = 36; @@ -61,7 +62,7 @@ public class ConversationAdaptiveActionsToolbar extends Toolbar { } } - int widthAllowed = toolbarWidthPx - ViewUtil.dpToPx(NAVIGATION_DP); + int widthAllowed = toolbarWidthPx - ViewUtil.dpToPx(NAVIGATION_DP + TITLE_DP); int nItemsToShow = Math.min(maxToShow, widthAllowed / ViewUtil.dpToPx(ACTION_VIEW_WIDTH_DP)); if (nItemsToShow < menuSize) {