remove useless name requirement from JobManager

This commit is contained in:
B. Petersen 2020-09-09 23:18:24 +02:00
parent 4350fe120c
commit ddee52171e
No known key found for this signature in database
GPG key ID: 3B88E92DEA8E9AFC
2 changed files with 2 additions and 20 deletions

View file

@ -148,7 +148,6 @@ public class ApplicationContext extends MultiDexApplication implements DefaultLi
private void initializeJobManager() { private void initializeJobManager() {
this.jobManager = JobManager.newBuilder(this) this.jobManager = JobManager.newBuilder(this)
.withName("TextSecureJobs")
.withConsumerThreads(5) .withConsumerThreads(5)
.build(); .build();
} }

View file

@ -24,7 +24,7 @@ public class JobManager implements RequirementListener {
private final Context context; private final Context context;
private final List<RequirementProvider> requirementProviders; private final List<RequirementProvider> requirementProviders;
private JobManager(Context context, String name, private JobManager(Context context,
List<RequirementProvider> requirementProviders, List<RequirementProvider> requirementProviders,
int consumers) int consumers)
{ {
@ -91,7 +91,6 @@ public class JobManager implements RequirementListener {
public static class Builder { public static class Builder {
private final Context context; private final Context context;
private String name;
private List<RequirementProvider> requirementProviders; private List<RequirementProvider> requirementProviders;
private int consumerThreads; private int consumerThreads;
@ -100,18 +99,6 @@ public class JobManager implements RequirementListener {
this.consumerThreads = 5; this.consumerThreads = 5;
} }
/**
* A name for the {@link org.thoughtcrime.securesms.jobmanager.JobManager}. This is a required parameter,
* and is linked to the durable queue used by persistent jobs.
*
* @param name The name for the JobManager to build.
* @return The builder.
*/
public Builder withName(String name) {
this.name = name;
return this;
}
/** /**
* Set the number of threads dedicated to consuming Jobs from the queue and executing them. * Set the number of threads dedicated to consuming Jobs from the queue and executing them.
* *
@ -127,15 +114,11 @@ public class JobManager implements RequirementListener {
* @return A constructed JobManager. * @return A constructed JobManager.
*/ */
public JobManager build() { public JobManager build() {
if (name == null) {
throw new IllegalArgumentException("You must specify a name!");
}
if (requirementProviders == null) { if (requirementProviders == null) {
requirementProviders = new LinkedList<>(); requirementProviders = new LinkedList<>();
} }
return new JobManager(context, name, requirementProviders, return new JobManager(context, requirementProviders,
consumerThreads); consumerThreads);
} }
} }