yetangitu/deltachat
1
0
Fork 0
mirror of https://github.com/deltachat/deltachat-android.git synced 2025-10-04 10:19:15 +02:00
Code Issues Releases Wiki Activity

tune down copying email address

Browse source 
copying email addresses to the clipboard
is not proper way to get in contact in the light of chatmail -
even if the account is non-chatmail, the receiver may use chatmail.
or the copied contact.

it is better to point ppl to use 'Share' or 'Attach Contact' therfore
and not offer failing/corner-case things in the primary menu.

therefore, we do basically the same what desktop is doing all the years:
no special function, however, if you select text (desktop)
or long tap it (android now), you can copy it.
This commit is contained in:
B. Petersen 2024-07-17 17:38:20 +02:00 • committed by bjoern
parent e7a9f60a12
commit ff9fe93a75
4 changed files with 34 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/main/java/org/thoughtcrime/securesms/ProfileActivity.java
View file

@ -1,13 +1,12 @@
package org.thoughtcrime.securesms;
import static org.thoughtcrime.securesms.util.RelayUtil.setForwardingMessageIds;
import android.app.Activity;
import android.content.Intent;
import android.media.RingtoneManager;
import android.net.Uri;
import android.os.Bundle;
import android.provider.Settings;
import android.view.ContextMenu;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
@ -29,7 +28,6 @@ import com.b44t.messenger.DcChat;
import com.b44t.messenger.DcContact;
import com.b44t.messenger.DcContext;
import com.b44t.messenger.DcEvent;
import com.b44t.messenger.DcMsg;
import com.google.android.material.tabs.TabLayout;
import org.thoughtcrime.securesms.connect.DcEventCenter;
@ -108,6 +106,9 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
titleView = (ConversationTitleView) supportActionBar.getCustomView();
titleView.setOnBackClickedListener(view -> onBackPressed());
titleView.setOnClickListener(view -> onEnlargeAvatar());
if (isContactProfile() && !isSelfProfile() && !chatIsDeviceTalk) {
titleView.registerForContextMenu(this);
}
}
updateToolbar();
@ -138,7 +139,6 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
if (chatIsDeviceTalk) {
menu.findItem(R.id.edit_name).setVisible(false);
menu.findItem(R.id.show_encr_info).setVisible(false);
menu.findItem(R.id.copy_addr_to_clipboard).setVisible(false);
menu.findItem(R.id.share).setVisible(false);
} else if (chatIsMultiUser) {
if (chatIsBroadcast) {
@ -149,7 +149,6 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
menu.findItem(R.id.edit_name).setVisible(false);
}
}
menu.findItem(R.id.copy_addr_to_clipboard).setVisible(false);
menu.findItem(R.id.share).setVisible(false);
}
} else {
@ -187,6 +186,12 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
return true;
}
@Override
public void onCreateContextMenu(ContextMenu menu, View v, ContextMenu.ContextMenuInfo menuInfo) {
super.onCreateContextMenu(menu, v, menuInfo);
getMenuInflater().inflate(R.menu.profile_title_context, menu);
}
boolean backPressed = false;
@Override
public void onBackPressed() {
@ -425,9 +430,6 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
case R.id.share:
onShare();
break;
case R.id.copy_addr_to_clipboard:
onCopyAddrToClipboard();
break;
case R.id.show_encr_info:
onEncrInfo();
break;
@ -442,6 +444,17 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity
return false;
}
@Override
public boolean onContextItemSelected(MenuItem item) {
super.onContextItemSelected(item);
switch (item.getItemId()) {
case R.id.copy_addr_to_clipboard:
onCopyAddrToClipboard();
break;
}
return false;
}
private void onNotifyOnOff() {
if (dcContext.getChat(chatId).isMuted()) {
setMuted(0);