From 2d3f1cc039b436c91dfe13b838a88181bb4b9dd7 Mon Sep 17 00:00:00 2001
From: Fred Chasen <fchasen@gmail.com>
Date: Tue, 9 May 2017 16:42:30 -0400
Subject: [PATCH] Fix for column rendering in Safari (#614)

* Fix for column rendering in Safari

* Set body to display inline in Columns css
---
 examples/spreads.html            | 10 ++++--
 src/contents.js                  | 62 +++++++++++++++++++-------------
 src/managers/continuous/index.js |  3 +-
 src/managers/helpers/stage.js    |  6 ++--
 src/utils/core.js                |  3 +-
 5 files changed, 51 insertions(+), 33 deletions(-)

diff --git a/examples/spreads.html b/examples/spreads.html
index 40540ea..b7bfc7e 100644
--- a/examples/spreads.html
+++ b/examples/spreads.html
@@ -18,9 +18,12 @@
   <a id="next" href="#next" class="arrow">›</a>
 
   <script>
-    var currentSectionIndex = 0;
+    var params = new URLSearchParams(document.location.search.substring(1));
+    var url = params && params.get("url") && decodeURIComponent(params.get("url"));
+    var currentSectionIndex = (params && params.get("loc")) ? params.get("loc") : 0;
+
     // Load the opf
-    var book = ePub("https://s3.amazonaws.com/moby-dick/moby-dick.epub");
+    var book = ePub(url || "https://s3.amazonaws.com/moby-dick/moby-dick.epub");
     var rendition = book.renderTo("viewer", {
       width: "100%",
       height: 600
@@ -64,7 +67,8 @@
     rendition.on("rendered", function(section){
       var nextSection = section.next();
       var prevSection = section.prev();
-      var current = book.navigation.get(section.href);
+
+      var current = book.navigation && book.navigation.get(section.href);
 
       if (current) {
         title.textContent = current.label;
diff --git a/src/contents.js b/src/contents.js
index 3fff58b..eff87c8 100644
--- a/src/contents.js
+++ b/src/contents.js
@@ -185,7 +185,15 @@ class Contents {
 		var _width, _height, _scale, _minimum, _maximum, _scalable;
 		var width, height, scale, minimum, maximum, scalable;
 		var $viewport = this.document.querySelector("meta[name='viewport']");
-		var newContent = "";
+		var parsed = {
+			"width": undefined,
+			"height": undefined,
+			"scale": undefined,
+			"minimum": undefined,
+			"maximum": undefined,
+			"scalable": undefined
+		};
+		var newContent = [];
 
 		/*
 		* check for the viewport size
@@ -199,37 +207,42 @@ class Contents {
 			let _minimum = content.match(/minimum-scale\s*=\s*([^,]*)/g);
 			let _maximum = content.match(/maximum-scale\s*=\s*([^,]*)/g);
 			let _scalable = content.match(/user-scalable\s*=\s*([^,]*)/g);
-			if(_width[1]){
-				width = _width[1];
+			if(_width && _width.length && typeof _width[1] !== "undefined"){
+				parsed.width = _width[1];
 			}
-			if(_height[1]){
-				height = _height[1];
+			if(_height && _height.length && typeof _height[1] !== "undefined"){
+				parsed.height = _height[1];
 			}
-			if(_scale[1]){
-				scale = _scale[1];
+			if(_scale && _scale.length && typeof _scale[1] !== "undefined"){
+				parsed.scale = _scale[1];
 			}
-			if(_minimum[1]){
-				minimum = _minimum[1];
+			if(_minimum && _minimum.length && typeof _minimum[1] !== "undefined"){
+				parsed.minimum = _minimum[1];
 			}
-			if(_maximum[1]){
-				maximum = _maximum[1];
+			if(_maximum && _maximum.length && typeof _maximum[1] !== "undefined"){
+				parsed.maximum = _maximum[1];
 			}
-			if(_scalable[1]){
-				scalable = _scalable[1];
+			if(_scalable && _scalable.length && typeof _scalable[1] !== "undefined"){
+				parsed.scalable = _scalable[1];
 			}
 		}
 
 		if (options) {
-
-			newContent += "width=" + (options.width || width);
-			newContent += ", height=" + (options.height || height);
-			if (options.scale || scale) {
-				newContent += ", initial-scale=" + (options.scale || scale);
+			if (options.width || parsed.width) {
+				newContent.push("width=" + (options.width || parsed.width));
 			}
-			if (options.scalable || scalable) {
-				newContent += ", minimum-scale=" + (options.scale || minimum);
-				newContent += ", maximum-scale=" + (options.scale || maximum);
-				newContent += ", user-scalable=" + (options.scalable || scalable);
+
+			if (options.height || parsed.height) {
+				newContent.push("height=" + (options.height || parsed.height));
+			}
+
+			if (options.scale || parsed.scale) {
+				newContent.push("initial-scale=" + (options.scale || parsed.scale));
+			}
+			if (options.scalable || parsed.scalable) {
+				newContent.push("minimum-scale=" + (options.scale || parsed.minimum));
+				newContent.push("maximum-scale=" + (options.scale || parsed.maximum));
+				newContent.push("user-scalable=" + (options.scalable || parsed.scalable));
 			}
 
 			if (!$viewport) {
@@ -238,7 +251,7 @@ class Contents {
 				this.document.querySelector("head").appendChild($viewport);
 			}
 
-			$viewport.setAttribute("content", newContent);
+			$viewport.setAttribute("content", newContent.join(", "));
 		}
 
 
@@ -316,7 +329,6 @@ class Contents {
 			};
 
 			this.pane && this.pane.render();
-
 			this.emit("resize", this._size);
 		}
 
@@ -699,7 +711,7 @@ class Contents {
 		// Deal with Mobile trying to scale to viewport
 		this.viewport({ width: width, height: height, scale: 1.0, scalable: "no" });
 
-		// this.overflowY("hidden");
+		this.css("display", "inline-block"); // Fixes Safari column cut offs
 		this.css("overflow-y", "hidden");
 		this.css("margin", "0", true);
 		this.css("padding", "0", true);
diff --git a/src/managers/continuous/index.js b/src/managers/continuous/index.js
index ff05d00..8e98309 100644
--- a/src/managers/continuous/index.js
+++ b/src/managers/continuous/index.js
@@ -113,6 +113,7 @@ class ContinuousViewManager extends DefaultViewManager {
 
 		this._stageSize = this.stage.size(width, height);
 		this._bounds = this.bounds();
+		console.log("set bounds", this._bounds);
 
 		// Update for new views
 		this.viewSettings.width = this._stageSize.width;
@@ -275,7 +276,7 @@ class ContinuousViewManager extends DefaultViewManager {
 		var offset = horizontal ? this.scrollLeft : this.scrollTop;
 		var visibleLength = horizontal ? bounds.width : bounds.height;
 		var contentLength = horizontal ? this.container.scrollWidth : this.container.scrollHeight;
-
+		console.log(bounds);
 		if (offset + visibleLength + delta >= contentLength) {
 			last = this.views.last();
 			next = last && last.section.next();
diff --git a/src/managers/helpers/stage.js b/src/managers/helpers/stage.js
index eb95f84..4e45ac3 100644
--- a/src/managers/helpers/stage.js
+++ b/src/managers/helpers/stage.js
@@ -187,11 +187,11 @@ class Stage {
 	}
 
 	bounds(){
-
-		if(!this.container) {
+		let box = this.container && this.container.getBoundingClientRect();
+		if(!box || !box.width || !box.height) {
 			return windowBounds();
 		} else {
-			return this.container.getBoundingClientRect();
+			return box;
 		}
 
 	}
diff --git a/src/utils/core.js b/src/utils/core.js
index fcc7bfe..848c59b 100644
--- a/src/utils/core.js
+++ b/src/utils/core.js
@@ -475,7 +475,8 @@ export function querySelectorByType(html, element, type){
 	if(!query || query.length === 0) {
 		query = qsa(html, element);
 		for (var i = 0; i < query.length; i++) {
-			if(query[i].getAttributeNS("http://www.idpf.org/2007/ops", "type") === type) {
+			if(query[i].getAttributeNS("http://www.idpf.org/2007/ops", "type") === type ||
+				 query[i].getAttribute("epub:type") === type) {
 				return query[i];
 			}
 		}