yetangitu/epub.js
1
0
Fork 0
mirror of https://github.com/futurepress/epub.js.git synced 2025-10-04 15:09:16 +02:00
Code Issues Releases Wiki Activity

Navigation href fallback for parent detection

Browse source 
The navItem function assumes that every item has an id attribute.
In practice this is not always the case, this will use the href attribute as fallback for the id attribute.
This commit is contained in:
Niels Lanting 2018-10-03 16:37:03 +02:00 • committed by GitHub
parent 7fd362bb82
commit 6d328c02dc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/navigation.js
View file

@ -162,6 +162,10 @@ class Navigation {
} }
let src = content.getAttribute("href") || ""; let src = content.getAttribute("href") || "";
if (!id) {
id = src;
}
let text = content.textContent || ""; let text = content.textContent || "";
let subitems = []; let subitems = [];
let parentItem = getParentByTagName(item, "li"); let parentItem = getParentByTagName(item, "li");
@ -169,12 +173,20 @@ class Navigation {
if (parentItem) { if (parentItem) {
parent = parentItem.getAttribute("id"); parent = parentItem.getAttribute("id");
if (!parent) {
const parentContent = filterChildren(parentItem, "a", true);
parent = parentContent && parentContent.getAttribute("href");
}
} }
while (!parent && parentItem) { while (!parent && parentItem) {
parentItem = getParentByTagName(parentItem, "li"); parentItem = getParentByTagName(parentItem, "li");
if (parentItem) { if (parentItem) {
parent = parentItem.getAttribute("id"); parent = parentItem.getAttribute("id");
if (!parent) {
const parentContent = filterChildren(parentItem, "a", true);
parent = parentContent && parentContent.getAttribute("href");
}
} }
} }