yetangitu/funkwhale
1
0
Fork 0
mirror of https://code.eliotberriot.com/funkwhale/funkwhale.git synced 2025-10-06 02:20:01 +02:00
Code Issues Releases Wiki Activity

Fixed #469: parsing of embedded file cover for ogg files tagged with MusicBrainz Picard

Browse source
This commit is contained in:
Eliot Berriot 2019-01-14 14:50:33 +01:00
parent 2703c61c48
commit 08ce00e3cd
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
4 changed files with 96 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
api/tests/music/test_metadata.py
View file

@ -1,9 +1,11 @@
import datetime
import os
import uuid
import pytest
import mutagen.oggtheora
import mutagen.oggvorbis
from funkwhale_api.music import metadata
DATA_DIR = os.path.dirname(os.path.abspath(__file__))
@ -145,7 +147,7 @@ def test_can_get_metadata_from_id3_mp3_file(field, value):
assert data.get(field) == value
@pytest.mark.parametrize("name", ["test.mp3", "sample.flac"])
@pytest.mark.parametrize("name", ["test.mp3", "sample.flac", "with_cover.ogg"])
def test_can_get_pictures(name):
path = os.path.join(DATA_DIR, name)
data = metadata.Metadata(path)
@ -243,3 +245,20 @@ def test_metadata_all_ignore_parse_errors_false(mocker):
mocker.patch.object(data, "get", side_effect=metadata.ParseError("Failure"))
with pytest.raises(metadata.ParseError):
data.all(ignore_parse_errors=False)
def test_metadata_fallback_ogg_theora(mocker):
path = os.path.join(DATA_DIR, "with_cover.ogg")
data = metadata.Metadata(path)
assert isinstance(data._file, mutagen.oggtheora.OggTheora)
assert isinstance(data.fallback, metadata.Metadata)
assert isinstance(data.fallback._file, mutagen.oggvorbis.OggVorbis)
expected_result = data.fallback.get("pictures")
fallback_get = mocker.spy(data.fallback, "get")
assert expected_result is not None
assert data.get("pictures", "default") == expected_result
fallback_get.assert_called_once_with("pictures", "default")