yetangitu/funkwhale
1
0
Fork 0
mirror of https://code.eliotberriot.com/funkwhale/funkwhale.git synced 2025-10-05 05:29:23 +02:00
Code Issues Releases Wiki Activity

Fix #776: Don't store unhandled ActivityPub messages in database

Browse source
This commit is contained in:
Eliot Berriot 2019-03-27 12:53:35 +01:00
parent b9b1e1e26a
commit 46f1d96206
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
3 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

26
api/tests/federation/test_activity.py
View file

@ -14,6 +14,9 @@ from funkwhale_api.federation import (
def test_receive_validates_basic_attributes_and_stores_activity(factories, now, mocker):
mocker.patch.object(
activity.InboxRouter, "get_matching_handlers", return_value=True
)
mocked_dispatch = mocker.patch("funkwhale_api.common.utils.on_commit")
local_to_actor = factories["users.User"]().create_actor()
local_cc_actor = factories["users.User"]().create_actor()
@ -48,6 +51,9 @@ def test_receive_validates_basic_attributes_and_stores_activity(factories, now,
def test_receive_calls_should_reject(factories, now, mocker):
should_reject = mocker.patch.object(activity, "should_reject", return_value=True)
mocker.patch.object(
activity.InboxRouter, "get_matching_handlers", return_value=True
)
local_to_actor = factories["users.User"]().create_actor()
remote_actor = factories["federation.Actor"]()
a = {
@ -65,6 +71,26 @@ def test_receive_calls_should_reject(factories, now, mocker):
assert copy is None
def test_receive_skips_if_no_matching_route(factories, now, mocker):
get_matching_handlers = mocker.patch.object(
activity.InboxRouter, "get_matching_handlers", return_value=[]
)
local_to_actor = factories["users.User"]().create_actor()
remote_actor = factories["federation.Actor"]()
a = {
"@context": [],
"actor": remote_actor.fid,
"type": "Noop",
"id": "https://test.activity",
"to": [local_to_actor.fid, remote_actor.fid],
}
copy = activity.receive(activity=a, on_behalf_of=remote_actor)
get_matching_handlers.assert_called_once_with(a)
assert copy is None
assert models.Activity.objects.count() == 0
@pytest.mark.parametrize(
"params, policy_kwargs, expected",
[