yetangitu/funkwhale
1
0
Fork 0
mirror of https://code.eliotberriot.com/funkwhale/funkwhale.git synced 2025-10-05 06:29:23 +02:00
Code Issues Releases Wiki Activity

Fix #740: Do not consider tracks as duplicates during import if they have different positions

Browse source
This commit is contained in:
Eliot Berriot 2019-03-27 12:27:23 +01:00
parent b9b1e1e26a
commit ca7b39c692
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
3 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

19
api/tests/music/test_tasks.py
View file

@ -156,6 +156,25 @@ def test_can_create_track_from_file_metadata_distinct_release_mbid(factories):
assert new_track != track
def test_can_create_track_from_file_metadata_distinct_position(factories):
"""Cf https://dev.funkwhale.audio/funkwhale/funkwhale/issues/740"""
artist = factories["music.Artist"]()
album = factories["music.Album"](artist=artist)
track = factories["music.Track"](album=album, artist=artist)
metadata = {
"artist": artist.name,
"album": album.title,
"title": track.title,
"track_number": track.position + 1,
"musicbrainz_artistid": artist.mbid,
"musicbrainz_albumid": album.mbid,
}
new_track = tasks.get_track_from_import_metadata(metadata)
assert new_track != track
def test_can_create_track_from_file_metadata_federation(factories, mocker, r_mock):
metadata = {
"artist": "Artist",