yetangitu/funkwhale
1
0
Fork 0
mirror of https://code.eliotberriot.com/funkwhale/funkwhale.git synced 2025-10-04 02:49:15 +02:00
Code Issues Releases Wiki Activity

See #1100: clean compat and XXX in the code

Browse source
This commit is contained in:
Agate 2020-08-03 15:47:14 +02:00
parent b7f1c02c6f
commit e271851f67
67 changed files with 203 additions and 328 deletions
Download patch file Download diff file Expand all files Collapse all files

14
api/funkwhale_api/common/serializers.py
View file

@ -299,20 +299,6 @@ class AttachmentSerializer(serializers.Serializer):
urls["medium_square_crop"] = o.download_url_medium_square_crop
return urls
def to_representation(self, o):
repr = super().to_representation(o)
# XXX: BACKWARD COMPATIBILITY
# having the attachment urls in a nested JSON obj is better,
# but we can't do this without breaking clients
# So we extract the urls and include these in the parent payload
repr.update({k: v for k, v in repr["urls"].items() if k != "source"})
# also, our legacy images had lots of variations (400x400, 200x200, 50x50)
# but we removed some of these, so we emulate these by hand (by redirecting)
# to actual, existing attachment variations
repr["square_crop"] = repr["medium_square_crop"]
repr["small_square_crop"] = repr["medium_square_crop"]
return repr
def create(self, validated_data):
return models.Attachment.objects.create(
file=validated_data["file"], actor=validated_data["actor"]