yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-06 03:50:02 +02:00
Code Issues Releases Wiki Activity

GP-3498 - Fixed IndexOutOfBoundsException

Browse source
This commit is contained in:
dragonmacher 2023-05-30 09:06:40 -04:00
parent d6fa1d9768
commit 05aac4b81e
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Ghidra/Features/DecompilerDependent/src/main/java/ghidra/app/extension/datatype/finder/DecompilerFieldAccess.java
View file

@ -51,7 +51,6 @@ public class DecompilerFieldAccess extends DecompilerVariable {
DataType dt = field.getDataType(); DataType dt = field.getDataType();
dt = getBaseType(dt); dt = getBaseType(dt);
if (!(dt instanceof Composite)) { if (!(dt instanceof Composite)) {
// can the dt be a pointer?
Msg.error(this, "Have a field for a type that is not a Composite type"); Msg.error(this, "Have a field for a type that is not a Composite type");
return dt; return dt;
} }
@ -65,6 +64,11 @@ public class DecompilerFieldAccess extends DecompilerVariable {
} }
} }
int n = composite.getNumComponents();
if (offset >= n) {
// how sure when this condition can happen, but we have seen this in the wild
return null;
}
DataTypeComponent component = composite.getComponent(offset); DataTypeComponent component = composite.getComponent(offset);
if (component == null) { if (component == null) {
return null; // not sure what else to do return null; // not sure what else to do