yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-04 18:29:37 +02:00
Code Issues Releases Wiki Activity

GP-4035 updated to not use address.subtract to determine inst offset,

Browse source 
which could in some cases cause an overflow error.
This commit is contained in:
ghidra007 2023-11-13 17:18:43 +00:00
parent 07f0f57cab
commit 07c9fb3f45
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/actions/AutoVersionTrackingTask.java
View file

@ -1224,10 +1224,14 @@ public class AutoVersionTrackingTask extends Task {
if (map.keySet().isEmpty()) {
continue;
}
// get offset from top of function to use in function to operandMap map
Long offset =
inst.getAddress().subtract(function.getEntryPoint().getOffset()).getOffset();
// can be positive or negative offset (positive means instruction address is after
// the entry address, negative means instruction address is before entry address)
Long entryOffset = function.getEntryPoint().getOffset();
Long instOffset = inst.getAddress().getOffset();
Long offset = instOffset - entryOffset;
offsetToOperandsMap.put(offset, map);
}