yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-04 18:29:37 +02:00
Code Issues Releases Wiki Activity

dont let subfunction parameter names override unaffected/input names

Browse source
This commit is contained in:
caheckman 2019-06-21 12:32:22 -04:00 • committed by James
parent 8cc9b4aa5f
commit 0d058ec35c
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Ghidra/Features/Decompiler/src/decompile/cpp/coreaction.cc
View file

@ -2150,11 +2150,11 @@ void ActionNameVars::makeRec(ProtoParameter *param,Varnode *vn,map<HighVariable
PcodeOp *castop = vn->getDef();
if (castop->code() == CPUI_CAST) {
vn = castop->getIn(0);
ct = (Datatype *)0; // Indicate that this is a less prefered name
ct = (Datatype *)0; // Indicate that this is a less preferred name
}
}
HighVariable *high = vn->getHigh();
if (!high->isMark()) return; // Not one of the
if (!high->isMark()) return; // Not one of the variables needing a name
map<HighVariable *,OpRecommend>::iterator iter = recmap.find(high);
if (iter != recmap.end()) { // We have seen this varnode before
@ -2191,6 +2191,7 @@ void ActionNameVars::lookForFuncParamNames(Funcdata &data,const vector<Varnode *
for(uint4 i=0;i<varlist.size();++i) { // Mark all the varnodes that can accept a name from a parameter
Varnode *vn = varlist[i];
if (vn->isFree()) continue;
if (vn->isInput()) continue; // Don't override unaffected or input naming strategy
Symbol *sym = vn->getHigh()->getSymbol();
if (sym == (Symbol *)0) continue;
if (!sym->isNameUndefined()) continue;