diff --git a/Ghidra/Features/Decompiler/src/decompile/cpp/op.cc b/Ghidra/Features/Decompiler/src/decompile/cpp/op.cc index d80da176cd..af89c583ac 100644 --- a/Ghidra/Features/Decompiler/src/decompile/cpp/op.cc +++ b/Ghidra/Features/Decompiler/src/decompile/cpp/op.cc @@ -415,8 +415,9 @@ void PcodeOp::saveXml(ostream &s) const else if (vn->getSpace()->getType()==IPTR_CONSTANT) { if ((i==0)&&((code()==CPUI_STORE)||(code()==CPUI_LOAD))) { AddrSpace *spc = Address::getSpaceFromConst(vn->getAddr()); - s << "getName() << "\"/>\n"; + s << "getName()); + s << "/>\n"; } else s << "getCreateIndex() << "\"/>\n"; diff --git a/Ghidra/Features/Decompiler/src/decompile/cpp/prettyprint.cc b/Ghidra/Features/Decompiler/src/decompile/cpp/prettyprint.cc index 4b687b53f1..fac4c0ca13 100644 --- a/Ghidra/Features/Decompiler/src/decompile/cpp/prettyprint.cc +++ b/Ghidra/Features/Decompiler/src/decompile/cpp/prettyprint.cc @@ -259,8 +259,9 @@ void EmitXml::tagField(const char *ptr,syntax_highlight hl,const Datatype *ct,in void EmitXml::tagComment(const char *ptr,syntax_highlight hl, const AddrSpace *spc,uintb off) { *s << "getName(); - *s << "\" off=\"0x" << hex << off << "\">"; + a_v(*s,"space",spc->getName()); + a_v_u(*s,"off",off); + *s << '>'; xml_escape(*s,ptr); *s << ""; } @@ -276,8 +277,9 @@ void EmitXml::tagComment(const char *ptr,syntax_highlight hl, void EmitXml::tagLabel(const char *ptr,syntax_highlight hl, const AddrSpace *spc,uintb off) { *s << ""; } diff --git a/Ghidra/Features/Decompiler/src/decompile/datatests/convert.xml b/Ghidra/Features/Decompiler/src/decompile/datatests/convert.xml index 7c9823c426..467bd18f80 100644 --- a/Ghidra/Features/Decompiler/src/decompile/datatests/convert.xml +++ b/Ghidra/Features/Decompiler/src/decompile/datatests/convert.xml @@ -62,5 +62,5 @@ ffffffbfdff7ffffe811ffffffbf6100 recv_signed\(-0b1100110011001100\) recv_unsigned\(0b1110111011101110\) recv_unsigned\(0b11111111111111111111011111011111\) -recv_signed\('a'\) +recv_signed\(L'a'\) diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/app/plugin/processors/sleigh/SleighLanguage.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/app/plugin/processors/sleigh/SleighLanguage.java index db679bc9be..9311adf11b 100644 --- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/app/plugin/processors/sleigh/SleighLanguage.java +++ b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/app/plugin/processors/sleigh/SleighLanguage.java @@ -1433,7 +1433,7 @@ public class SleighLanguage implements Language { if ((element instanceof OverlayAddressSpace)) { OverlayAddressSpace ospace = (OverlayAddressSpace) element; resBuf.append("