yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 09:49:23 +02:00
Code Issues Releases Wiki Activity

GP-5697 - PDB Provide post-analysis pop-up when PDB file not found

Browse source
This commit is contained in:
ghizard 2025-05-16 10:47:00 -04:00
parent 657215ddbe
commit 2f51ec305c
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ghidra/Features/PDB/src/main/java/ghidra/app/plugin/core/analysis/PdbAnalyzer.java
View file

@ -87,7 +87,9 @@ public class PdbAnalyzer extends AbstractAnalyzer {
File pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor); File pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor);
if (pdbFile == null) { if (pdbFile == null) {
// warnings have already been logged // Warnings have already been logged, but nice to have a post-analysis pop-up that
// PDB analysis was not done
log.appendMsg(NAME, "Aborted: Could not find an appropriate PDB file; see log");
return false; return false;
} }
@ -156,7 +158,7 @@ public class PdbAnalyzer extends AbstractAnalyzer {
* Normally the analyzer would locate the PDB file on its own, but if a * Normally the analyzer would locate the PDB file on its own, but if a
* headless script wishes to override the analyzer's behaivor, it can * headless script wishes to override the analyzer's behaivor, it can
* use this method to specify a file. * use this method to specify a file.
* *
* @param program {@link Program} * @param program {@link Program}
* @param pdbFile the pdb file * @param pdbFile the pdb file
*/ */
@ -171,7 +173,7 @@ public class PdbAnalyzer extends AbstractAnalyzer {
* Normally when the analyzer attempts to locate a matching PDB file it * Normally when the analyzer attempts to locate a matching PDB file it
* will default to NOT searching untrusted symbol servers. A headless script could * will default to NOT searching untrusted symbol servers. A headless script could
* use this method to allow the analyzer to search untrusted symbol servers. * use this method to allow the analyzer to search untrusted symbol servers.
* *
* @param program {@link Program} * @param program {@link Program}
* @param allowUntrusted boolean flag, true means analyzer can search untrusted symbol * @param allowUntrusted boolean flag, true means analyzer can search untrusted symbol
* servers * servers

4
Ghidra/Features/PDB/src/main/java/ghidra/app/plugin/core/analysis/PdbUniversalAnalyzer.java
View file

@ -167,7 +167,9 @@ public class PdbUniversalAnalyzer extends AbstractAnalyzer {
pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor); pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor);
} }
if (pdbFile == null) { if (pdbFile == null) {
// warnings have already been logged // Warnings have already been logged, but nice to have a post-analysis pop-up that
// PDB analysis was not done
log.appendMsg(NAME, "Aborted: Could not find an appropriate PDB file; see log");
return false; return false;
} }