yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-06 03:50:02 +02:00
Code Issues Releases Wiki Activity

GP-959 - decompiler function hover tweaks to PR

Browse source
This commit is contained in:
dragonmacher 2021-05-19 16:53:01 -04:00
parent e8ed3a28ae
commit 312fa6393d
1 changed files with 51 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

43
Ghidra/Features/Decompiler/src/main/java/ghidra/app/decompiler/component/hover/FunctionSignatureDecompilerHover.java
View file

@ -24,6 +24,7 @@ import docking.widgets.fieldpanel.support.FieldLocation;
import ghidra.GhidraOptions;
import ghidra.app.decompiler.*;
import ghidra.app.decompiler.component.ClangTextField;
import ghidra.app.decompiler.component.DecompilerUtils;
import ghidra.app.plugin.core.hover.AbstractConfigurableHover;
import ghidra.app.util.ToolTipUtils;
import ghidra.framework.plugintool.PluginTool;
@ -34,7 +35,6 @@ import ghidra.program.model.listing.Program;
import ghidra.program.model.pcode.HighConstant;
import ghidra.program.model.pcode.Varnode;
import ghidra.program.model.scalar.Scalar;
import ghidra.program.model.symbol.*;
import ghidra.program.util.ProgramLocation;
/**
@ -83,7 +83,7 @@ public class FunctionSignatureDecompilerHover extends AbstractConfigurableHover
ClangToken token = ((ClangTextField) field).getToken(fieldLocation);
if (token instanceof ClangFuncNameToken) {
Function function = ((ClangFuncNameToken)token).getHighFunction().getFunction();
Function function = DecompilerUtils.getFunction(program, (ClangFuncNameToken) token);
String content = ToolTipUtils.getToolTipText(function, false);
return createTooltipComponent(content);
}
@ -91,6 +91,20 @@ public class FunctionSignatureDecompilerHover extends AbstractConfigurableHover
// Reference to function-address: "x = &foo;" where 'foo' is a function
Varnode vn = ((ClangVariableToken) token).getVarnode();
Scalar scalar = getScalar(vn);
Function function = getFunctionAtAddress(program, scalar);
if (function != null) {
String content = ToolTipUtils.getToolTipText(function, false);
content = content.replaceFirst(HTML,
HTML + italic(bold("Reference to Function")) + "<br/><br/>");
return createTooltipComponent(content);
}
}
return null;
}
private Scalar getScalar(Varnode vn) {
if (vn == null) {
return null;
}
@ -108,31 +122,28 @@ public class FunctionSignatureDecompilerHover extends AbstractConfigurableHover
}
if (sz > 8) {
// our Scalar can currently only handle long values
return null; // our Scalar can currently only handle long values
}
return new Scalar(sz * 8, offset, isSigned);
}
private Function getFunctionAtAddress(Program program, Scalar scalar) {
if (scalar == null) {
return null;
}
Scalar scalar = new Scalar(sz * 8, offset, isSigned);
long scalarLong = scalar.getValue();
AddressFactory factory = program.getAddressFactory();
AddressSpace space = factory.getDefaultAddressSpace();
try {
Address asAddress = factory.getAddress(space.getSpaceID(), scalarLong);
Function function = program.getListing().getFunctionAt(asAddress);
if (function != null) {
String content = ToolTipUtils.getToolTipText(function, false);
content = content.replaceFirst(HTML,
HTML + italic(bold("Reference to Function")) + "<br/><br/>");
return createTooltipComponent(content);
}
return program.getListing().getFunctionAt(asAddress);
}
catch (AddressOutOfBoundsException ex) {
return null; // Constant does not make sense as an address
return null; // scalar is not an address
}
}
return null;
}
}