GP-0 Restored the correct action names, and edited help description.

GP-0 Added help for EditPrototypeOverrideAction and MyToggleExactConstantMatching action. Corrected the name of the help that OpenVersionTrackingSessionAction and OverridePrototypeAction were referring to so they were directed to the correct help location.
This commit is contained in:
isabella3412 2024-02-23 15:41:10 +00:00
parent 52e6360d96
commit 367f088162
7 changed files with 53 additions and 9 deletions

View file

@ -496,6 +496,12 @@
<BLOCKQUOTE> <BLOCKQUOTE>
<P> This toggles the decompiler panels between a vertical split and a horizontal split. </P> <P> This toggles the decompiler panels between a vertical split and a horizontal split. </P>
</BLOCKQUOTE> </BLOCKQUOTE>
<H4><A name="Toggle_Exact_Constant_Matching"></A>Toggle Exact Constant Matching</H4>
<BLOCKQUOTE>
<P> This toggles whether or not constants must be exactly the same value to be a match in
the Decompiler Diff View. </P>
</BLOCKQUOTE>
</BLOCKQUOTE> </BLOCKQUOTE>
<H2><A name="Compare Multiple Functions"></A>Comparing Multiple Functions</H2> <H2><A name="Compare Multiple Functions"></A>Comparing Multiple Functions</H2>

View file

@ -20,17 +20,25 @@ import java.util.List;
import javax.swing.Icon; import javax.swing.Icon;
import docking.ActionContext; import docking.ActionContext;
import docking.action.*; import docking.action.DockingAction;
import docking.widgets.fieldpanel.internal.FieldPanelCoordinator; import docking.action.ToggleDockingAction;
import docking.action.ToolBarData;
import generic.theme.GIcon; import generic.theme.GIcon;
import ghidra.app.decompiler.component.*; import ghidra.app.decompiler.component.DecompileData;
import ghidra.app.decompiler.component.DecompilerCodeComparisonPanel;
import ghidra.app.decompiler.component.DualDecompileResultsListener;
import ghidra.app.decompiler.component.DualDecompilerActionContext;
import ghidra.codecompare.graphanalysis.TokenBin; import ghidra.codecompare.graphanalysis.TokenBin;
import ghidra.framework.options.OptionsChangeListener; import ghidra.framework.options.OptionsChangeListener;
import ghidra.framework.options.ToolOptions; import ghidra.framework.options.ToolOptions;
import ghidra.framework.plugintool.PluginTool; import ghidra.framework.plugintool.PluginTool;
import ghidra.util.HTMLUtilities; import ghidra.util.HTMLUtilities;
import ghidra.util.HelpLocation;
import ghidra.util.exception.CancelledException; import ghidra.util.exception.CancelledException;
import ghidra.util.task.*; import ghidra.util.task.Task;
import ghidra.util.task.TaskBuilder;
import ghidra.util.task.TaskLauncher;
import ghidra.util.task.TaskListener;
import resources.Icons; import resources.Icons;
import resources.MultiIcon; import resources.MultiIcon;
@ -44,6 +52,7 @@ public class DecompilerDiffCodeComparisonPanel
implements DualDecompileResultsListener, OptionsChangeListener { implements DualDecompileResultsListener, OptionsChangeListener {
public static final String CODE_DIFF_VIEW = "Decompiler Diff View"; public static final String CODE_DIFF_VIEW = "Decompiler Diff View";
private static final String HELP_TOPIC = "FunctionComparison";
private DecompileDataDiff decompileDataDiff; private DecompileDataDiff decompileDataDiff;
private DiffClangHighlightController leftHighlightController; private DiffClangHighlightController leftHighlightController;
private DiffClangHighlightController rightHighlightController; private DiffClangHighlightController rightHighlightController;
@ -199,6 +208,7 @@ public class DecompilerDiffCodeComparisonPanel
*/ */
public MyToggleExactConstantMatching(String owner) { public MyToggleExactConstantMatching(String owner) {
super("Toggle Exact Constant Matching", owner); super("Toggle Exact Constant Matching", owner);
setHelpLocation(new HelpLocation(HELP_TOPIC, "Toggle Exact Constant Matching"));
this.setToolBarData(new ToolBarData(NO_EXACT_CONSTANT_MATCHING_ICON, "toggles")); this.setToolBarData(new ToolBarData(NO_EXACT_CONSTANT_MATCHING_ICON, "toggles"));

View file

@ -4939,6 +4939,19 @@
</para> </para>
</sect2> </sect2>
<sect2 id="ActionEditOverride">
<title>Edit Signature Override</title>
<para>
Edit the existing overriding function prototype to the called function under the cursor.
</para>
<para>
This action can only be triggered at call sites with an existing signature override. As with the Override
Signature command, users must select either the token representing the called function's name or the
tokens representing the function pointer at the call site. The action brings up a dialog where the user
can edit the current overriding function prototype.
</para>
</sect2>
<sect2 id="ActionReference"> <sect2 id="ActionReference">
<title>References</title> <title>References</title>
<sect3 id="ActionFindUses"> <sect3 id="ActionFindUses">

View file

@ -1111,6 +1111,21 @@
</p> </p>
</div> </div>
<div class="sect2">
<div class="titlepage"><div><div><h3 class="title">
<a name="ActionEditOverride"></a>Edit Signature Override</h3></div></div></div>
<p>
Edit the overriding function prototype applied previously to the called function under the cursor.
</p>
<p>
This action can only be triggered at call sites with an existing signature override. As with the Override
Signature command, users must select either the token representing the called function's name or the
tokens representing the function pointer at the call site. The action brings up a dialog where the user
can edit the current overriding function prototype.
</p>
</div>
<div class="sect2"> <div class="sect2">
<div class="titlepage"><div><div><h3 class="title"> <div class="titlepage"><div><div><h3 class="title">
<a name="ActionReference"></a>References</h3></div></div></div> <a name="ActionReference"></a>References</h3></div></div></div>

View file

@ -38,7 +38,7 @@ public class OpenVersionTrackingSessionAction extends DockingAction {
String[] menuPath = { ToolConstants.MENU_FILE, "Open Session..." }; String[] menuPath = { ToolConstants.MENU_FILE, "Open Session..." };
setMenuBarData(new MenuData(menuPath, "AAA")); setMenuBarData(new MenuData(menuPath, "AAA"));
setDescription("Opens a Version Tracking Session"); setDescription("Opens a Version Tracking Session");
setHelpLocation(new HelpLocation("VersionTrackingPlugin", "Open_Session")); setHelpLocation(new HelpLocation("VersionTrackingPlugin", "Version_Tracking_Tool"));
} }
@Override @Override