yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 02:39:44 +02:00
Code Issues Releases Wiki Activity

GP-4661 - Added the structure member comment to the tooltip

Browse source
This commit is contained in:
dragonmacher 2024-06-04 15:41:00 -04:00
parent c19facf226
commit 3bf5dcfbb3
1 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Ghidra/Features/Decompiler/src/main/java/ghidra/app/decompiler/component/hover/DataTypeDecompilerHover.java
View file

@ -17,6 +17,8 @@ package ghidra.app.decompiler.component.hover;
import javax.swing.JComponent; import javax.swing.JComponent;
import org.apache.commons.lang3.StringUtils;
import docking.widgets.fieldpanel.field.Field; import docking.widgets.fieldpanel.field.Field;
import docking.widgets.fieldpanel.support.FieldLocation; import docking.widgets.fieldpanel.support.FieldLocation;
import ghidra.GhidraOptions; import ghidra.GhidraOptions;
@ -97,10 +99,19 @@ public class DataTypeDecompilerHover extends AbstractConfigurableHover
int offset = fieldToken.getOffset(); int offset = fieldToken.getOffset();
DataType fieldType = getFieldDataType(fieldToken); DataType fieldType = getFieldDataType(fieldToken);
String comment = null;
if (parentType instanceof Structure structure) {
DataTypeComponent dtc = structure.getComponentAt(offset);
if (dtc != null) {
comment = StringUtils.truncate(dtc.getComment(), 80); // arbitrary limit
}
}
// //
// Parent: BarBar // Parent: BarBar
// Offset: 0x8 // Offset: 0x8
// Field Name: fooField // Field Name: fooField
// Comment: This is a comment
// //
StringBuilder buffy = new StringBuilder(HTMLUtilities.HTML); StringBuilder buffy = new StringBuilder(HTMLUtilities.HTML);
@ -113,6 +124,12 @@ public class DataTypeDecompilerHover extends AbstractConfigurableHover
row("Offset: ", NumericUtilities.toHexString(offset))); row("Offset: ", NumericUtilities.toHexString(offset)));
buffy.append( buffy.append(
row("Field Name: ", HTMLUtilities.friendlyEncodeHTML(token.getText()))); row("Field Name: ", HTMLUtilities.friendlyEncodeHTML(token.getText())));
if (comment != null) {
buffy.append(
row("Comment: ", HTMLUtilities.friendlyEncodeHTML(comment)));
}
buffy.append("</TABLE>"); buffy.append("</TABLE>");
//@formatter:on //@formatter:on