yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 10:49:34 +02:00
Code Issues Releases Wiki Activity

GP-3775 corrected FloatFormat.decodeHostFloat(long) treatment of

Browse source 
subnormal values.
This commit is contained in:
ghidra1 2023-08-23 18:58:06 -04:00
parent 0233f35d1f
commit 3ef9a19166
2 changed files with 80 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

54
Ghidra/Framework/SoftwareModeling/src/test/java/ghidra/pcode/floatformat/FloatFormatTest.java
View file

@ -32,21 +32,6 @@ public class FloatFormatTest extends AbstractGenericTest {
super();
}
@Test
public void testCreateFloat() {
int i = 0;
for (double x : BigFloatTest.testDoubleList) {
if (!Double.isFinite(x)) {
continue;
}
FloatFormat.SmallFloatData data = FloatFormat.getSmallFloatData(x);
double y = FloatFormat.createDouble(data.sign < 0,
data.unscaled << (64 - data.fracbits), data.scale);
Assert.assertEquals("case #" + Integer.toString(i), x, y, 0);
++i;
}
}
@Test
public void testGetEncodingMinval() {
FloatFormat ff = new FloatFormat(4);
@ -269,6 +254,30 @@ public class FloatFormatTest extends AbstractGenericTest {
Assert.assertEquals(intbits, encoding.longValue());
Assert.assertEquals(big, ff.decodeBigFloat(encoding));
big = ff.getBigFloat(Float.MIN_VALUE);
encoding = ff.getEncoding(big);
intbits = Float.floatToRawIntBits(Float.MIN_VALUE);
Assert.assertEquals(intbits, encoding.longValue());
Assert.assertEquals(Float.MIN_VALUE, (float) ff.decodeHostFloat(intbits), 0);
big = ff.getBigFloat(Float.MAX_VALUE);
encoding = ff.getEncoding(big);
intbits = Float.floatToRawIntBits(Float.MAX_VALUE);
Assert.assertEquals(intbits, encoding.longValue());
Assert.assertEquals(Float.MAX_VALUE, (float) ff.decodeHostFloat(intbits), 0);
big = ff.getBigFloat(-Float.MIN_VALUE);
encoding = ff.getEncoding(big);
intbits = Float.floatToRawIntBits(-Float.MIN_VALUE);
Assert.assertEquals(intbits, (int) encoding.longValue());
Assert.assertEquals(-Float.MIN_VALUE, (float) ff.decodeHostFloat(intbits), 0);
big = ff.getBigFloat(-Float.MAX_VALUE);
encoding = ff.getEncoding(big);
intbits = Float.floatToRawIntBits(-Float.MAX_VALUE);
Assert.assertEquals(intbits, (int) encoding.longValue());
Assert.assertEquals(-Float.MAX_VALUE, (float) ff.decodeHostFloat(intbits), 0);
f = 3.75f;
intbits = Float.floatToRawIntBits(f);
big = ff.getBigFloat(f);
@ -430,6 +439,12 @@ public class FloatFormatTest extends AbstractGenericTest {
Assert.assertEquals(intbits, encoding);
Assert.assertEquals(f, (float) ff.decodeHostFloat(encoding), 0);
intbits = 1; // smallest subnormal value
Assert.assertEquals(Float.MIN_VALUE, (float) ff.decodeHostFloat(intbits), 0);
intbits = 0x80000001; // smallest subnormal value
Assert.assertEquals(-Float.MIN_VALUE, (float) ff.decodeHostFloat(intbits), 0);
f = 8.908155E-39f;
intbits = Float.floatToRawIntBits(f);
encoding = ff.getEncoding(f);
@ -1473,11 +1488,10 @@ public class FloatFormatTest extends AbstractGenericTest {
doTestValueOfBigInteger(BigDecimal.valueOf(2.1234567890123456789e123));
doTestValueOfBigInteger(BigDecimal.valueOf(2.1234567890123456789e123).negate());
// NOTE: BigDecimal.valueOf(Double.MAX_VALUE) produces a value greater than Double.MAX_VALUE
// doTestValueOfBigInteger(BigDecimal.valueOf(Double.MAX_VALUE));
BigFloat bf = ff.decodeBigFloat(Double.doubleToRawLongBits(Double.MAX_VALUE));
bf = ff.getBigFloat(bf.toBigInteger());
assertEquals("1.797693134862316E+308", ff.toDecimalString(bf));
@ -1640,14 +1654,12 @@ public class FloatFormatTest extends AbstractGenericTest {
ff.toDecimalString(ff.decodeBigFloat(0x0065006700610050L)));
assertEquals("2.123456789012346",
ff.toDecimalString(ff.decodeBigFloat(0x4000FCD6E9BA37B3L)));
assertEquals("0.3",
ff.toDecimalString(ff.decodeBigFloat(0x3FD3333333333333L)));
assertEquals("0.3", ff.toDecimalString(ff.decodeBigFloat(0x3FD3333333333333L)));
}
@Test
public void testFloatDecodeWithToString() {
FloatFormat ff = FloatFormatFactory.getFloatFormat(4);
assertEquals("-1.4682312",
ff.toDecimalString(ff.decodeBigFloat(0xbfbbef00L), true));
assertEquals("-1.4682312", ff.toDecimalString(ff.decodeBigFloat(0xbfbbef00L), true));
}
}